Skip to content

Fix 1px header nav gap at iPad 768px breakpoint#28146

Merged
pelikhan merged 2 commits intomainfrom
copilot/update-header-navigation-gap
Apr 23, 2026
Merged

Fix 1px header nav gap at iPad 768px breakpoint#28146
pelikhan merged 2 commits intomainfrom
copilot/update-header-navigation-gap

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

At exactly 768px (iPad), the header showed neither nav links nor the tablet hamburger — .custom-header-links was hidden via max-width: 768px but the hamburger only activated at min-width: 769px.

Change

In docs/src/styles/custom.css, close the 1px gap by aligning the tablet hamburger trigger with the mobile hide breakpoint:

/* Before */
@media (min-width: 769px) and (max-width: 900px) { … }

/* After */
@media (min-width: 768px) and (max-width: 900px) { … }

Change tablet hamburger trigger from min-width: 769px to min-width: 768px
so an iPad at exactly 768px sees the hamburger menu instead of neither
the header nav links nor the hamburger.

Fixes #multi-device-docs-testing-report-2026-04-23

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/803b3606-14b4-47af-9e22-dd890a57d58a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix header navigation gap for iPad at 768px Fix 1px header nav gap at iPad 768px breakpoint Apr 23, 2026
Copilot AI requested a review from pelikhan April 23, 2026 18:48
@pelikhan pelikhan marked this pull request as ready for review April 23, 2026 18:51
Copilot AI review requested due to automatic review settings April 23, 2026 18:51
@pelikhan pelikhan merged commit 0d920ae into main Apr 23, 2026
3 checks passed
@pelikhan pelikhan deleted the copilot/update-header-navigation-gap branch April 23, 2026 18:51
@github-actions github-actions Bot mentioned this pull request Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the tablet header hamburger breakpoint to eliminate a 1px “dead zone” at exactly 768px where neither header links nor the tablet hamburger were visible.

Changes:

  • Updates the tablet-specific header hamburger @media query to start at min-width: 768px (was 769px).
  • Updates the related comment to reflect iPad (768px) coverage.
Show a summary per file
File Description
docs/src/styles/custom.css Aligns tablet hamburger visibility with the 768px breakpoint to close the header nav gap.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines +1618 to +1619
/* Tablet-specific fixes (iPad at 768px, iPad Pro 11 at 834px) — header hamburger */
@media (min-width: 768px) and (max-width: 900px) {
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tablet media query starts at 768px, which means at exactly 768px it overlaps with the existing @media (max-width: 768px) rules in this file (media queries are inclusive). If the intent is for 768px to behave strictly as “tablet” (not both mobile+tablet), consider adjusting one side of the breakpoint (e.g., make the mobile max-width < 768px or start tablet at > 768px) to avoid double-applying potentially conflicting styles.

Suggested change
/* Tablet-specific fixes (iPad at 768px, iPad Pro 11 at 834px) — header hamburger */
@media (min-width: 768px) and (max-width: 900px) {
/* Tablet-specific fixes (769px to 900px, including iPad Pro 11 at 834px) — header hamburger */
@media (min-width: 769px) and (max-width: 900px) {

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔍 Multi-Device Docs Testing Report - 2026-04-23

3 participants