Fix 1px header nav gap at iPad 768px breakpoint#28146
Conversation
Change tablet hamburger trigger from min-width: 769px to min-width: 768px so an iPad at exactly 768px sees the hamburger menu instead of neither the header nav links nor the hamburger. Fixes #multi-device-docs-testing-report-2026-04-23 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/803b3606-14b4-47af-9e22-dd890a57d58a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adjusts the tablet header hamburger breakpoint to eliminate a 1px “dead zone” at exactly 768px where neither header links nor the tablet hamburger were visible.
Changes:
- Updates the tablet-specific header hamburger
@mediaquery to start atmin-width: 768px(was769px). - Updates the related comment to reflect iPad (768px) coverage.
Show a summary per file
| File | Description |
|---|---|
| docs/src/styles/custom.css | Aligns tablet hamburger visibility with the 768px breakpoint to close the header nav gap. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| /* Tablet-specific fixes (iPad at 768px, iPad Pro 11 at 834px) — header hamburger */ | ||
| @media (min-width: 768px) and (max-width: 900px) { |
There was a problem hiding this comment.
The new tablet media query starts at 768px, which means at exactly 768px it overlaps with the existing @media (max-width: 768px) rules in this file (media queries are inclusive). If the intent is for 768px to behave strictly as “tablet” (not both mobile+tablet), consider adjusting one side of the breakpoint (e.g., make the mobile max-width < 768px or start tablet at > 768px) to avoid double-applying potentially conflicting styles.
| /* Tablet-specific fixes (iPad at 768px, iPad Pro 11 at 834px) — header hamburger */ | |
| @media (min-width: 768px) and (max-width: 900px) { | |
| /* Tablet-specific fixes (769px to 900px, including iPad Pro 11 at 834px) — header hamburger */ | |
| @media (min-width: 769px) and (max-width: 900px) { |
At exactly 768px (iPad), the header showed neither nav links nor the tablet hamburger —
.custom-header-linkswas hidden viamax-width: 768pxbut the hamburger only activated atmin-width: 769px.Change
In
docs/src/styles/custom.css, close the 1px gap by aligning the tablet hamburger trigger with the mobile hide breakpoint: