fix: add render_template.cjs and is_truthy.cjs to SAFE_OUTPUTS_FILES#28331
Merged
fix: add render_template.cjs and is_truthy.cjs to SAFE_OUTPUTS_FILES#28331
Conversation
…in setup.sh Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8da07556-ed8b-4551-9c95-8beaa7d7b6f4 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 24, 2026 20:02
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SAFE_OUTPUTS_FILES list in actions/setup/setup.sh to include missing transitive dependencies needed by the safe-outputs MCP server, fixing a failing JS test shard.
Changes:
- Added
render_template.cjstoSAFE_OUTPUTS_FILES. - Added
is_truthy.cjstoSAFE_OUTPUTS_FILES.
Show a summary per file
| File | Description |
|---|---|
actions/setup/setup.sh |
Ensures the safe-outputs packaging step copies all required transitive .cjs dependencies so runtime/tests don’t fail due to missing modules. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAFE_OUTPUTS_FILESinsetup.shwas missing two transitive dependencies ofsafe-outputs-mcp-server.cjs, causing the JS shard 4/4 test to fail.Dependency chain:
firewall_blocked_domains.cjs(already listed) →render_template.cjs→is_truthy.cjsChange:
render_template.cjsandis_truthy.cjstoSAFE_OUTPUTS_FILESinactions/setup/setup.sh