Apply progressive disclosure to firewall blocked domains alert#28332
Merged
Apply progressive disclosure to firewall blocked domains alert#28332
Conversation
…mmary Agent-Logs-Url: https://github.com/github/gh-aw/sessions/40375956-49f5-42ea-9461-0487043090ac Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 24, 2026 20:02
View session
pelikhan
reviewed
Apr 24, 2026
| const domainList = blockedDomains.map(domain => `> - \`${domain}\`\n`).join(""); | ||
| let section = "\n\n> [!WARNING]\n"; | ||
| section += `> <details>\n`; | ||
| section += `> <summary>⚠️ Firewall blocked ${domainCount} ${domainWord}</summary>\n`; |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b8aaadba-06d5-4735-bbed-60f10a919560 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
…sive-disclosure-firewall-alert # Conflicts: # actions/setup/js/firewall_blocked_domains.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Merge conflicts resolved in 1f84c74. Main branch had refactored |
pelikhan
approved these changes
Apr 24, 2026
pelikhan
deleted the
copilot/apply-progressive-disclosure-firewall-alert
branch
Contributor
There was a problem hiding this comment.
Pull request overview
Applies progressive disclosure to the “firewall blocked domains” warning so the alert content is collapsed by default (via <details>/<summary>), reducing comment noise while preserving full troubleshooting guidance.
Changes:
- Updated the firewall blocked domains markdown template to wrap the alert body in
<details>/<summary>, with the summary showing only the blocked count. - Updated unit tests to assert the new
<details>structure in the generated warning section.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/md/firewall_blocked_domains.md | Wrapes the warning body in <details>/<summary> so the domain list/config snippet/docs link are collapsed by default. |
| actions/setup/js/firewall_blocked_domains.test.cjs | Updates assertions to match the new <details>/<summary> output structure. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firewall blocked domains
[!WARNING]alert dumped all content (domain list, YAML config snippet, docs link) inline, making it noisy in comments. Wrapping the body in<details>/<summary>collapses it by default, matching the pattern already used by the integrity filter alert.Changes
firewall_blocked_domains.cjs—generateBlockedDomainsSectionnow emits<details>/<summary>inside the[!WARNING]block; the summary shows only the count, full details expand on clickfirewall_blocked_domains.test.cjs— updated assertions to match new structure (<details>,<summary>Firewall blocked N …</summary>,</details>)Before:
After: