Skip to content

Fix integration test: check run_ids_or_urls (plural) in audit error envelope #28519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 25, 2026
Merged

Fix integration test: check run_ids_or_urls (plural) in audit error envelope #28519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e34e68
Initial plan
Copilot Apr 25, 2026
6e3311c
fix: update test assertion to check run_ids_or_urls (plural) in audit…
Copilot Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cli/mcp_server_error_codes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ func TestMCPServer_ErrorCodes_InternalError(t *testing.T) {
if _, hasError := envelope["error"]; !hasError {
t.Errorf("Expected 'error' field in audit JSON response, got: %s", textContent.Text)
}
if _, hasRunID := envelope["run_id_or_url"]; !hasRunID {
t.Errorf("Expected 'run_id_or_url' field in audit JSON response, got: %s", textContent.Text)
if _, hasRunID := envelope["run_ids_or_urls"]; !hasRunID {
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean variable name hasRunID no longer matches the key being checked (run_ids_or_urls). Consider renaming it (e.g., hasRunIDsOrURLs / hasRunIDs) to keep the assertion self-explanatory and avoid confusion when reading failures.

Suggested change
if _, hasRunID := envelope["run_ids_or_urls"]; !hasRunID {
if _, hasRunIDsOrURLs := envelope["run_ids_or_urls"]; !hasRunIDsOrURLs {

Copilot uses AI. Check for mistakes.
t.Errorf("Expected 'run_ids_or_urls' field in audit JSON response, got: %s", textContent.Text)
}
if _, hasSuggestions := envelope["suggestions"]; !hasSuggestions {
t.Errorf("Expected 'suggestions' field in audit JSON response, got: %s", textContent.Text)
Expand Down
Loading