Skip to content

fix(ai-moderator): stop false cache-miss alarms when spam-log.json is absent#28610

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-ai-moderator-cache-miss
Apr 26, 2026
Merged

fix(ai-moderator): stop false cache-miss alarms when spam-log.json is absent#28610
pelikhan merged 3 commits intomainfrom
copilot/fix-ai-moderator-cache-miss

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

The AI Moderator was triggering "Cache Configuration Problem" warnings on every run after cache expiry. The system-level cache_memory_prompt.md instructs agents to call missing_data(reason: cache_memory_miss) when expected cache data is absent, but a missing spam-log.json is entirely normal — the cache has retention-days: 1 and the file won't exist on first run or after daily expiry.

Changes

  • ai-moderator.md: Sharpens the spam-log reading instruction to explicitly say the file may be absent due to cache expiry (not just "first run") and to proceed with an empty array without calling missing_data.
-At the start of your analysis, read the spam log file at
- `/tmp/gh-aw/cache-memory/spam-log.json` (it may not exist on the first run).
+At the start of your analysis, try to read the spam log file at
+ `/tmp/gh-aw/cache-memory/spam-log.json`. This file may not exist (it is absent
+ on the first run or whenever the 24-hour cache has expired) — if it is missing,
+ proceed with an empty array and **do not** call `missing_data`.

The lock file was recompiled after the change.

Copilot AI linked an issue Apr 26, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits April 26, 2026 15:43
Copilot AI changed the title [WIP] Fix AI Moderator workflow cache miss issue fix(ai-moderator): stop false cache-miss alarms when spam-log.json is absent Apr 26, 2026
Copilot AI requested a review from pelikhan April 26, 2026 15:49
@pelikhan pelikhan marked this pull request as ready for review April 26, 2026 16:11
Copilot AI review requested due to automatic review settings April 26, 2026 16:11
@pelikhan pelikhan merged commit f1d1369 into main Apr 26, 2026
20 checks passed
@pelikhan pelikhan deleted the copilot/fix-ai-moderator-cache-miss branch April 26, 2026 16:11
@github-actions github-actions Bot mentioned this pull request Apr 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AI Moderator workflow instructions to treat a missing spam-log.json as a normal cache-expiry condition (avoiding repeated “Cache Configuration Problem” warnings), and refreshes embedded action pin metadata.

Changes:

  • Clarify in ai-moderator.md that spam-log.json may be absent after cache expiry and should be treated as an empty log without calling missing_data.
  • Update several pinned GitHub Action versions/SHAs in the embedded action_pins.json.
Show a summary per file
File Description
pkg/workflow/data/action_pins.json Refreshes embedded action pin entries (versions/SHAs) used for deterministic workflow compilation.
.github/workflows/ai-moderator.md Adjusts spam-log read guidance to avoid false cache-miss alarms when the cache has expired.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment on lines +86 to 90
"actions/setup-node@v6.4.0": {
"repo": "actions/setup-node",
"version": "v6.3.0",
"sha": "53b83947a5a98c8d113130e565377fae1a50d02f"
"version": "v6.4.0",
"sha": "48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e"
},
Copy link

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description lists only the ai-moderator.md wording change, but this file also updates several pinned action versions/SHAs (and removes a pin). Please confirm these pin updates are intentional and either mention them explicitly in the PR description or split them into a separate PR to keep the change focused.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] AI Moderator failed

3 participants