fix: restructure cache miss alert template format (#28609)

[Copilot]

Summary

Fixes the cache miss alert template format as described in issue #28609.

Problem: The cache_memory_miss.md template rendered a > [!WARNING] callout block with a <details> section whose <summary> was "How to fix". The issue title ("Cache Configuration Problem") was buried inside the callout, not surfaced as the collapsible summary.

Fix: Restructure the template so:

• The <details> block is nested inside the > [!WARNING] alert
• The cache miss title (Cache Configuration Problem: ...) is the <summary> of the <details> block (no redundant emoji — the WARNING alert already provides the visual warning)
• The how-to-fix content is inside the <details> body

Changes

• actions/setup/md/cache_memory_miss.md: Replaced the flat > [!WARNING] + separate <details><summary>How to fix</summary> pattern with a > [!WARNING] alert wrapping a <details><summary>Cache Configuration Problem: ...</summary> block containing the fix content
• actions/setup/js/handle_agent_failure.test.cjs: Updated mock template strings to match new format, updated assertions to check for > [!WARNING] and <summary>, extracted long strings into named const variables for readability

Before / After

Before:

> [!WARNING]
> **Cache Configuration Problem**: cache miss detected despite cache-memory being configured.

<details>
<summary>How to fix</summary>

...fix content...
</details>

After:

> [!WARNING]
> <details>
> <summary>Cache Configuration Problem: cache miss detected despite cache-memory being configured.</summary>
>
> ...fix content...
>
> </details>

[pelikhan]

@copilot must still be wrapped in a WARNING alert

[Copilot]

Done in 61be0d1 — the <details> block is now nested inside a > [!WARNING] blockquote alert.

[pelikhan]

@copilot remove warning emoji, already in alert title

[Copilot]

Removed in 61be0d1 — summary is now Cache Configuration Problem: cache miss detected despite cache-memory being configured. without the emoji.

[Copilot]

Pull request overview

Restructures the cache-miss warning markdown template so the cache configuration problem title is surfaced as the <details><summary> inside a GitHub [!WARNING] callout (per issue #28609).

Changes:

• Reworked cache_memory_miss.md to nest a <details> block inside the [!WARNING] callout and move the problem title into the <summary>.
• Updated handle_agent_failure unit tests to align mocked template content and assertions with the new markdown structure.
• Updated several embedded action pins (including removal of a github/gh-aw-actions/setup pin entry).

Show a summary per file

File	Description
pkg/workflow/data/action_pins.json	Updates embedded action version/SHA pins (and removes the github/gh-aw-actions/setup pin).
actions/setup/md/cache_memory_miss.md	Restructures warning template to make the cache configuration title the collapsible summary inside the warning callout.
actions/setup/js/handle_agent_failure.test.cjs	Updates mocked template strings/assertions to match the new callout + details format.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 1

[github-actions]

🧪 Test Quality Sentinel Report

Test Quality Score: 93/100

✅ Excellent test quality

Metric	Value
New/modified tests analyzed	2
✅ Design tests (behavioral contracts)	2 (100%)
⚠️ Implementation tests (low value)	0 (0%)
Tests with error/edge cases	2 (100%)
Duplicate test clusters	0
Test inflation detected	No
🚨 Coding-guideline violations	None

---

Test Classification Details

View Test Classification Table

Test	File	Classification	Issues Detected
"appends cache configuration warning when cacheMemoryEnabled is true and cache_memory_miss item present"	actions/setup/js/handle_agent_failure.test.cjs:1137	✅ Design	None — verifies observable output contains correct warning format
"captures reason-only missing_data items (no data_type) and detects cache miss"	actions/setup/js/handle_agent_failure.test.cjs:1164	✅ Design	None — verifies observable output includes > [!WARNING] block

---

Analysis Summary

Both modified tests update expected template content and add a new expect(result).toContain("> [!WARNING]") assertion to track the production change: the cache miss alert template was reformatted from a bare <details> block to a GitHub Markdown > [!WARNING] alert block wrapping the details.

Strengths:

• Both tests verify the observable output of buildMissingDataContext() — a behavioral contract that a consumer (GitHub issue comment) would directly observe
• The new > [!WARNING] assertion correctly anchors the new format requirement, ensuring regressions would be caught
• fs I/O is mocked (acceptable — external side effect), but assertions are on the function's return value, not on mock call counts
• Test additions (9 lines) vs. template file additions (11 lines) — no inflation

Minor note: The score is slightly below 100 because these are format-tracking updates rather than new scenario coverage; no new behavioral edge cases are introduced. The existing test suite already covers the broader buildMissingDataContext logic.

---

Language Support

Tests analyzed:

• 🐹 Go (*_test.go): 0 tests
• 🟨 JavaScript (*.test.cjs): 2 tests (vitest)

---

Verdict

✅ Check passed. 0% of new/modified tests are implementation tests (threshold: 30%). No coding-guideline violations detected.

---

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

• Assert on observable outputs, return values, or state changes
• Cover error paths and boundary conditions
• Would catch a behavioral regression if deleted
• Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

• Assert on internal function calls (mocking internals)
• Only test the happy path with typical inputs
• Break during legitimate refactoring even when behavior is correct
• Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

---

References: §24961102679

🧪 Test quality analysis by Test Quality Sentinel · ● 738.7K · ◷

[github-actions]

✅ Test Quality Sentinel: 93/100. Test quality is excellent — 0% of new/modified tests are implementation tests (threshold: 30%). Both modified tests correctly track the new > [!WARNING] cache miss alert format and assert on observable function output.