Skip to content

fix: correct audit command Use syntax to match codebase convention#28771

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-integration-cmd-tests
Apr 27, 2026
Merged

fix: correct audit command Use syntax to match codebase convention#28771
pelikhan merged 2 commits intomainfrom
copilot/fix-integration-cmd-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

The Integration: CMD Tests job was failing because the audit command's Use field placed ... inside the optional argument brackets ([run-id-or-url...]) instead of outside ([run-id-or-url]...), causing isValidUseSyntax() to reject it. The test's expectedUse also still reflected the old single-argument form.

Changes

  • pkg/cli/audit.go: Fix Use field — [run-id-or-url...][run-id-or-url]... to match the pattern expected by isValidUseSyntax and all other multi-arg commands in the codebase
  • cmd/gh-aw/argument_syntax_test.go: Update expectedUse to "audit <run-id-or-url> [run-id-or-url]..." and correct argsValidator annotation from ExactArgs(1)MinimumNArgs(1)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login &#43; &#34;/&#34; &#43; .name x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env XU8RCguzS GO111MODULE x_amd64/link GOINSECURE lite GOMODCACHE x_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 204414324 Q8gElMZ6A ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm env rtcfg GO111MODULE .cfg GOINSECURE 047627/b006/ GOMODCACHE ache/go/1.25.8/x^remote\..*\.gh-resolved$ (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env rtcfg mMLh2czeP 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env verutil.test GO111MODULE ortcfg.link GOINSECURE fips140/subtle GOMODCACHE 1TrQ_zyaDDimeco612346 (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name HEAD st/dist/workers/forks.js de_modules/.bin/git /tmp/bare-increm/bin/sh gin/full-mode-br-c in/git git diff�� --binary 915d6814aa93e21a6e57752794b1de330a9780c6..3b33488ca6833ee0b96771969f12abcac3d848c3 e/git README.md d5c8373c ache/node/24.14./tmp/gh-aw-test-runs/20260427-175349-52379/test-source-field-variant-601065365/.github/workflows e/git (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -U7HTRxJB GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuTest User /usr/bin/git 047627/b027/_pkgnode om/goccy/go-yaml/opt/hostedtoolcache/node/24.14.1/x64/bin/npm ache/go/1.25.8/xinstall git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv ache/node/24.14.--show-toplevel /test-cwd /usr/bin/git HEAD ache/node/24.14.rev-parse 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git --binary --output=/tmp/gi/opt/hostedtoolcache/node/24.14.1/x64/bin/npm ache/go/1.25.8/xinstall git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv 4907-35535/test-3030521658 -trimpath /usr/bin/git -p main -lang=go1.25 git -C /tmp/shared-actions-test4110440104 rev-parse /usr/bin/git go1.25.8 -c=4 -nolocalimports git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv ere Test User /usr/bin/git --binary 915d6814aa93e21arev-parse tions/setup/node--show-toplevel git rev-�� runs/20260427-175349-52379/test-778429454 git /usr/bin/docker s/test.md LVG0/.diffsize.t-C 8fe86b63..dc57d6/tmp/TestCollectWorkflowFiles_TransitiveImports2697115248/001 docker (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv 1/test1.md bft1/1yO0RzBmJIVi0dFibft1 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE ntio/encoding/as--version GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet env 4907-35535/test-2803952714 GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE /opt/hostedtoolcache/go/1.25.8/xTest User (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/vet /usr/bin/git 5SsZLhVho d/gh-aw-wasm/mai\n ache/go/1.25.8/x: git rev-�� --show-toplevel ortcfg /usr/bin/git edcfg SK0W/BJGJRDpSI4wrev-parse /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git --show-toplevel go /usr/bin/gh git rev-�� --show-toplevel gh /usr/bin/git /repos/actions/ggit s/3/artifacts /opt/hostedtoolc--show-toplevel git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv mplied -trimpath 8198100/b419/vet.cfg -p set -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x2 -o licyMinIntegrityOnlymin-integrittest-logs/run-2 -trimpath /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link -p vendor/golang.orrev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x-importcfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260427-174907-35535/test-2803952714 -trimpath t l main -lang=go1.25 git rev-�� --show-toplevel -dwarf=false (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv bility_SameInputSameOutput1160668081/001/stability-test.md my-default /usr/bin/git -json GO111MODULE 64/bin/go git -C /tmp/TestGuardPolicyTrustedUsersRequiresMinIntegv1.0.0 config /usr/bin/git remote.origin.urgit GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git 047627/b003/impobash Bcts/l-3Xgegn_V4/tmp/gh-aw-test-runs/20260427-174926-38234/test-patch-priority-34157�� e/git-upload-pack git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu-trimpath /usr/bin/git 047627/b207/impogit -trimpath /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/node/24.14.1/x64/bin/node /usr/bin/git CommaSeparatedCobash k/gh-aw/gh-aw/ac/tmp/gh-aw-test-runs/20260427-175353-53442/test-patch-priority-24541�� ache/node/24.14.1/x64/bin/node git rev-�� --show-toplevel k/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/git-receive-pack &#39;/tmp/TestParserev-parse /usr/bin/git sistency_GoAndJagit test-uFgMi7/slowrev-parse e/git git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv optimization)...&#34;; \ BEFORE=$(wc -c &lt; gh-aw.wasm); \ wasm-opt -Oz --enable-bulk-memory gh-aw.wasm -o gh-aw.opt.wasm &amp;&amp; \ mv gh-aw.opt.wasm gh-aw.wasm; \ AFTER=$(wc -c &lt; g -c=4 -nolocalimports -importcfg /tmp/go-build917047627/b231/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/modelcontextprotocol/go-sdk@v1.5.0/internal/xcontext/xcontext.go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build917047627/b240/importcfg -pack /home/REDACTED/go/pkg/mod/golang.org/x/text@v0.36.0/language/coverage.go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ry=1 nF/2rw-RdHCw_apH02zfbN4/KAMAEFRbrev-parse 8198100/b469/_pkg_.a _.a GO111MODULE 64/pkg/tool/linu--show-toplevel /usr/bin/git remo�� -v 64/pkg/tool/linux_amd64/compile /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet _.a xpQFH7LFx 64/pkg/tool/linu--show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --get remote.origin.url /usr/bin/git source-field-vargh tions/setup/js/nrepo bin/go git rev-�� --show-toplevel tions/setup/js/n--jq /usr/bin/git r.go -m in/git git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv runs/20260427-174907-35535/test-322777261 test@example.com /opt/hostedtoolcache/node/24.14.1/x64/bin/node -json GO111MODULE 64/bin/go node /tmp�� /tmp/TestHashConsistency_GoAndJavaScript3946701937/001/test-empty-frontmatter.md go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link -json GO111MODULE x_amd64/compile /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv XznK/-pvV1a_jhTrcvthCXznK 64/pkg/tool/linux_amd64/compile /usr/bin/infocmp _.a GO111MODULE 64/pkg/tool/linu--show-toplevel infocmp 8198�� xterm-color 8198100/b469/_testmain.go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet y_with_repos_arrgit LZuHOSZyr 64/pkg/tool/linu--show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv git-upload-pack &#39;/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmaster_branch869036350/001&#39; git-upload-pack &#39;/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmaster_branch869036350/001&#39; /usr/bin/git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv ry=1 -trimpath 8198100/b420/_pkg_.a =receive internal/syscallrev-parse -lang=go1.25 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/pkg/semverutil/semverutil.go k/gh-aw/gh-aw/pkg/semverutil/semverutil_test.go /usr/bin/git -errorsas -ifaceassert -nilfunc git rev-�� --show-toplevel -tests /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv 8198100/b452/_pkg_.a /home/REDACTED/go/pkg/mod/golang.org/x/text@v0.36.0/internal/format/format.go 8198100/b452=&gt; -json GO111MODULE 64/bin/go git 8198�� runs/20260427-174907-35535/test-322777261 8198100/b444/_testmain.go ache/node/24.14.1/x64/bin/node s/test.md GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go .test -json GO111MODULE 64/bin/go .test Enve�� GOMODCACHE go /usr/bin/git -json GO111MODULE layTitle git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /opt/hostedtoolcache/node/24.14.1/x64/bin/node commit.gpgsign mp ode_modules/.bin--show-toplevel node /tmp�� :latest git /usr/bin/git 511680003/001&#39; 511680003/001&#39; nfig/composer/ve--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linurev-parse /usr/bin/git LsRemoteWithRealgit LsRemoteWithRealrev-parse 64/pkg/tool/linu--show-toplevel /usr/bin/git conf�� --get-regexp ^remote\..*\.gh-resolved$ /usr/bin/git y_only_defaults_git o 64/pkg/tool/linu--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/vet /usr/bin/git onfig.json --output=/tmp/girev-parse k/gh-aw/gh-aw/ac--show-toplevel git rev-�� --show-toplevel git /usr/bin/git mLsRemoteWithReagit mLsRemoteWithRearev-parse 1/x64/bin/node git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv /tmp/TestGuardPolicyMinIntegrityOnlymin-integrittest-logs/run-1 rev-parse /usr/bin/git -json GO111MODULE 64/bin/go git -C /home/REDACTED/work/gh-aw/gh-aw/.github/workflows rev-parse /usr/bin/git -json GO111MODULE x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv -aw/git/ref/tags.artifacts[].name forks.js bject.type] | @tsv commit.gpgsign mp 5c5d4f5a2e438ac9--show-toplevel git rev-�� --show-toplevel git /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet . 1/x64/bin/node ache/uv/0.11.8/x--show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv /tmp/TestGuardPolicyMinIntegrityOnlymin-integrity_with_repos=public_2519950947/001 remote /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv 5349-52379/test-778429454 forks.js bject.type] | @tsv commit.gpgsign mp 5c5d4f5a2e438ac9--show-toplevel git rev-�� --show-toplevel IfJtDcZqMmrF /usr/bin/gh . 1/x64/bin/node 249cd8aed55c9787--show-toplevel gh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created &gt;=2026-04-20 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/asm env -json @v1.1.3/cpu/arm/arm.go x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created &gt;=2026-03-28 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env _.a @v1.19.2/ast/ast.go 64/pkg/tool/linux_amd64/compile GOINSECURE order GOMODCACHE 64/pkg/tool/linuInitial commit (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created &gt;=2026-01-27 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env add-source-path-2644471605/.github/workflows GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu--auto (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name DW6KATJ4J 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env 416011798/.github/workflows qbNVEaFt_ ache/go/1.25.8/x64/pkg/tool/linu-test.short=true GOINSECURE til GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 QyquJZDcH 64/pkg/tool/linux_amd64/compile GOINSECURE /norm GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a aTWjRYknE ck GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name &#39;/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmain_branch3511680003/001&#39; 4322658/b392/vet.cfg -s -w -buildmode=exe /opt/hostedtoolcache/node/24.14.1/x64/bin/node --ex�� runs/20260427-175349-52379/test-1793726091/.github/workflows /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warn--conditions 1/x64/bin/node node --conditions development 1/x64/bin/node (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE aw.test GOINSECURE o 64/src/runtime/a--show-toplevel aw.test 8781�� -json diXaaNED5 ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-trimpath (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 eUCGDzm1t 64/pkg/tool/linux_amd64/vet GOINSECURE 5519 GOMODCACHE 64/pkg/tool/linux_amd64/vet env rtcfg mMLh2czeP 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs sv node --conditions development /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linuremote -o /tmp/go-build2985255301/b001/_pkg_.a -trimpath ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -p main -lang=go1.25 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linu-nolocalimports GOINSECURE wasm.o 64/src/runtime/a--show-toplevel 64/pkg/tool/linu/tmp/go-build2878198100/b456/_testmain.go env -json 3Js0Ri3Dw ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-importcfg (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 nLaxVxxol 64/pkg/tool/linu-nolocalimports GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/tmp/go-build2878198100/b459/_testmain.go env rtcfg 1T9iaPhBz ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-importcfg (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name test-6Oqgpr/complex.go .cfg node --conditions development /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link -V=f�� runs/20260427-175349-52379/test-2138346736/.github/workflows git ache/node/24.14.1/x64/bin/node it git ache/node/24.14.--show-toplevel bash (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name KmEF_rn9z 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a CLJOlIPxV ache/go/1.25.8/x64/pkg/tool/linu-test.short=true GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE 64/pkg/tool/linux_amd64/link GOINSECURE ack GOMODCACHE 64/pkg/tool/linux_amd64/link rtcf�� util.test Hgqea9f-D ortcfg.link GOINSECURE GOMOD GOMODCACHE iUEqf5PFeb3NCkL0nF/2rw-RdHCw_apH02zfbN4/KAMAEFRbrev-parse (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name git 4322658/b401/vet.cfg feature | cat /egit ings.cjs d2e2034c43309e86--show-toplevel /opt/hostedtoolcache/node/24.14.Test User --ex�� runs/20260427-175349-52379/test-1793726091/.github/workflows /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warn--conditions /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet l --conditions development /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name l_test.go 64/pkg/tool/linux_amd64/compile GOINSECURE o 64/src/internal/--show-toplevel 64/pkg/tool/linux_amd64/compile env 416011798/.github/workflows FSSLThW2J k GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu/tmp/file-tracker-test914324535/test2.lock.yml (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE nal/poly1305 GOMODCACHE go rtcf�� tformat RR0X2oXnN ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linushow (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name git At,event,headBranch,headSha,displayTitle feature | cat /egit set d2e2034c43309e86--show-toplevel /opt/hostedtoolcache/node/24.14.test@example.com --ex�� runs/20260427-175349-52379/test-1793726091/.github/workflows /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warn--conditions /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet node --conditions development /opt/hostedtoolcache/go/1.25.8/xremote.origin.url (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name UHEwN-QbQ 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env 416011798 jPRjWWcxh ortcfg.link GOINSECURE GOMOD GOMODCACHE -4GmfpWzsnidAKUU7I/p67f43WHEJUTs4-oiIa1/9KqfPfOCpIDAkxslPM8J (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 h00yucQ7c /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env rtcfg 1iP8YSgUm ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE %H %ct %D (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name git 4322658/b412/vet.cfg s ings.cjs d2e2034c43309e86--show-toplevel /opt/hostedtoolcache/node/24.14.1/x64/bin/node --ex�� /test1.md /test2.lock.yml /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet node --conditions development /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name Cy4PJHJpH 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE Vgol9MA/jtMHmSR1PwQ4sKWnT8ry env rtcfg 7zDW0_L0m ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 m0O72i2Jk /opt/hostedtoolc-nolocalimports GOINSECURE GOMOD GOMODCACHE go env rtcfg vZBL1k16k ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE %H %ct %D (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name git 4322658/b402/vet.cfg =receive ings.cjs odules/npm/node_--show-toplevel (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE s (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 /tmp/go-build2878198100/b431/importcfg -pack /tmp/go-build2878198100/b431/_testmain.go env iant-3315866709 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD bis 64/pkg/tool/linux_amd64/vet env 3429490861 uKJh7UXOD ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build2878198100/b404/cli.test /tmp/go-build2878198100/b404/cli.test -test.testlogfile=/tmp/go-build2878198100/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true -nolocalimports -importcfg /tmp/go-build917047627/b195/importcfg -pack env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /tmp/go-build3024322658/b404/cli.test /tmp/go-build3024322658/b404/cli.test -test.testlogfile=/tmp/go-build3024322658/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true 70a00900..full-m/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/asm (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuremote.origin.url /usr/bin/git 047627/b242/_pkggit k-ff/hcoMcb4nJlDrev-parse ser.test git rev-�� --show-toplevel ser.test /usr/bin/git g9lJ/QNSRYMftluhls -trimpath Name,createdAt,s/tmp/gh-aw/aw-feature-branch.patch git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/link /usr/bin/git SameOutput186666git --output=/tmp/girev-parse ache/node/24.14.--show-toplevel git rev-�� tagedFiles322889137/001/workflow.md ache/node/24.14.1/x64/bin/node /usr/bin/infocmp 926498416/.githuls k/gh-aw/gh-aw/ac-lh /opt/hostedtoolc/tmp/gh-aw/aw-feature-branch.patch infocmp (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv 4907-35535/test-source-field-variant-3525538704 GO111MODULE tartedAt,updatedAt,event,headBranch,headSha,displayTitle GOINSECURE record GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile rtcf�� 047627/b160/_pkg_.a in/yaml/v3@v3.0.4/apic.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE light GOMODCACHE ache/go/1.25.8/x12345 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv tmatter-with-env-template-expressions.md ode_modules/vitemain odules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/go run --auto git git init�� -q BnjJ/.diffsize.tmp it d5c8373c..HEAD 853ddd9da074471d-C /git git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv . LVG0/.diffsize.tmp it run d5c8373c t LPMn3sS/ik7obRPdEdg3h3VrqBfQ _bra�� -q (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv to pkg/actionpins/data/action_pi-p GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv . LVG0/.diffsize.tmp 8fe86b63..dc57d65c5d4f5a2e438ac98f9ec73bc6f203e132 -u d5c8373c es/.bin/git git comm�� Gitmaster_branch869036350/001&#39; Gitmaster_branch869036350/001&#39; bin/git origin d5c8373c 1/x64/bin/node git (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv rtcfg 2XU_VxRq0 ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE rand GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm env 8081/001/stability-test.md efaultBranchFromLsRemoteWithRealGitbranch_with_hyphen102593648/001&#39; ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 047627/b092/ 047627/b015/symatest/race-image:v1.0.0 ache/go/1.25.8/x64/pkg/tool/linumyorg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv . (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuTest User env plorer.md GO111MODULE sv GOINSECURE (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion node --conditions development git rev-�� runs/20260427-175349-52379/test-3340817393/custom/workflows git /usr/lib/git-core/git user.name (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-importcfg env rtcfg GO111MODULE .cfg GOINSECURE 047627/b011/ GOMODCACHE ache/go/1.25.8/x-buildtags (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo cal/bin/git /tmp/bare-incremgit . ules/.bin/git git diff�� --binary 915d6814aa93e21a-c=4 odules/npm/node_-nolocalimports -m ode_modules/viteconfig /git git (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name HEAD st/dist/workers/forks.js es/.bin/git /tmp/bare-increm/bin/sh gin/full-mode-br-c k/gh-aw/node_modgit init git diff�� --binary 915d6814aa93e21a6e57752794b1de330a9780c6..3b33488ca6833ee0b96771969f12abcac3d848c3 git README.md d5c8373c ache/node/24.14.--show-toplevel git (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch rtcfg Y9sJvruy0 ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env rtcfg GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE fips140/sha3 GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuremote.origin.url (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch --show-toplevel (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git conf�� --local --get ode_modules/.bin/git user.name Test User ode_modules/.binfor-each-ref git comm�� -m Initial commit tions/setup/node_modules/.bin/git --bare --initial-branchadd ndor/bin/git git (dns block)
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git e/git init�� es/.bin/git git ode_modules/.bin/git =receive test@example.com--git-dir=/tmp/bare-incremental-mTmJqv /git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Integration: CMD Tests fix: correct audit command Use syntax to match codebase convention Apr 27, 2026
Copilot AI requested a review from pelikhan April 27, 2026 17:55
@pelikhan pelikhan marked this pull request as ready for review April 27, 2026 18:37
Copilot AI review requested due to automatic review settings April 27, 2026 18:37
@pelikhan pelikhan merged commit 0a35ed2 into main Apr 27, 2026
19 checks passed
@pelikhan pelikhan deleted the copilot/fix-integration-cmd-tests branch April 27, 2026 18:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the audit command’s Cobra Use string so it matches the repository’s CLI argument syntax rules and unblocks the failing integration consistency test.

Changes:

  • Update audit command Use syntax to place ... outside the optional bracket ([run-id-or-url]...).
  • Update the integration argument-syntax test expectation for audit to the multi-arg form and align the validator annotation to MinimumNArgs(1).
Show a summary per file
File Description
pkg/cli/audit.go Adjusts the Use string so isValidUseSyntax() accepts the multi-arg optional tail form.
cmd/gh-aw/argument_syntax_test.go Updates expectedUse and the validator description to reflect audit accepting 1+ args.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

🧪 Test Quality Sentinel Report

Test Quality Score: 95/100

Excellent test quality

Metric Value
New/modified tests analyzed 1 (table row in TestArgumentSyntaxConsistency)
✅ Design tests (behavioral contracts) 1 (100%)
⚠️ Implementation tests (low value) 0 (0%)
Tests with error/edge cases 1 (100%)
Duplicate test clusters 0
Test inflation detected No
🚨 Coding-guideline violations None

Test Classification Details

Test File Classification Issues Detected
TestArgumentSyntaxConsistencyaudit row cmd/gh-aw/argument_syntax_test.go:26 ✅ Design None

Analysis

The PR makes two closely related changes:

  1. Production (pkg/cli/audit.go): Fixes the Use syntax from "audit <run-id-or-url> [run-id-or-url...]" to "audit <run-id-or-url> [run-id-or-url]..." — moving the ellipsis outside the brackets to match the codebase convention validated by isValidUseSyntax.

  2. Test (cmd/gh-aw/argument_syntax_test.go): Updates the corresponding table row's expectedUse and argsValidator fields to match the corrected production code behaviour (MinimumNArgs(1) replacing ExactArgs(1)).

The modified test row is a design test: it verifies the public CLI contract — what argument syntax a user sees and what validation they get. Assertion messages are present and descriptive. The //go:build integration tag is correctly on line 1. No mocks, no test inflation, no duplication.

The 5-point deduction is minor: the shouldValidate function only tests the happy path (valid single argument) and does not verify that zero arguments are rejected — but this is an acceptable gap for a syntax-consistency test.


Language Support

Tests analyzed:

  • 🐹 Go (*_test.go): 1 modified test row — integration (//go:build integration)

Verdict

Check passed. 0% of new/modified tests are implementation tests (threshold: 30%).


📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

  • Assert on observable outputs, return values, or state changes
  • Cover error paths and boundary conditions
  • Would catch a behavioral regression if deleted
  • Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

  • Assert on internal function calls (mocking internals)
  • Only test the happy path with typical inputs
  • Break during legitimate refactoring even when behavior is correct
  • Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §25012838601

🧪 Test quality analysis by Test Quality Sentinel · ● 535.1K ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 95/100. Test quality is excellent — 0% of new/modified tests are implementation tests (threshold: 30%). The updated table row correctly enforces the public CLI argument syntax contract.

@github-actions github-actions Bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants