Skip to content

cleanup: remove unused workflowData parameter from IsMCPScriptsEnabled#28813

Merged
pelikhan merged 3 commits intomainfrom
copilot/cleanup-remove-unused-workflowdata-parameter
Apr 28, 2026
Merged

cleanup: remove unused workflowData parameter from IsMCPScriptsEnabled#28813
pelikhan merged 3 commits intomainfrom
copilot/cleanup-remove-unused-workflowdata-parameter

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

IsMCPScriptsEnabled carried a dead workflowData *WorkflowData parameter — the body always ignored it and delegated straight to HasMCPScripts(mcpScripts).

Changes

  • mcp_scripts_parser.go — drop workflowData parameter and remove the stale "backward compatibility" comment
  • 14 call sites across pkg/workflow/ — remove the second argument
  • mcp_scripts_parser_test.go — remove unused workflowData field from table-driven test struct
// Before
func IsMCPScriptsEnabled(mcpScripts *MCPScriptsConfig, workflowData *WorkflowData) bool {
    return HasMCPScripts(mcpScripts)
}
// call site
if IsMCPScriptsEnabled(workflowData.MCPScripts, workflowData) {

// After
func IsMCPScriptsEnabled(mcpScripts *MCPScriptsConfig) bool {
    return HasMCPScripts(mcpScripts)
}
// call site
if IsMCPScriptsEnabled(workflowData.MCPScripts) {

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/vet GOINSECURE _wasm.o 64/src/math/big/--show-toplevel 64/pkg/tool/linux_amd64/vet env 30/001/test-frontmatter-with-arrays.md GO111MODULE .cfg GOINSECURE e GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 3902635751/.github/workflows gmGb0FnMM ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/xremote.origin.url env 127/001/stability-test.md GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x^remote\..*\.gh-resolved$ (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 3902635751/.github/workflows EocudEgAi ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 8BmvF0JImBC3z/ZFrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com env t3337221004 GO111MODULE .yml GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x12346 (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env h ../../../.pret.prettierignore GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git ithub/workflows GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/xtest@example.com /usr/bin/git 20352/b034/_pkg_node om/modelcontextp/opt/hostedtoolcache/node/24.14.1/x64/bin/npm .cfg git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git */*.ts' '**/*.jsgit GO111MODULE 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git -json GO111MODULE ache/go/1.25.8/xinstall git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv 0426-50610/test-3410620392 x_amd64/asm /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -json GO111MODULE x_amd64/compile /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -ato�� -bool -buildtags /usr/bin/git -errorsas -ifaceassert -nilfunc git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv w.md go /usr/bin/git re GO111MODULE 64/bin/go git conf�� user.name Test User /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv 0426-50610/test-339754339/.github/workflows O_e3/jNiaaPEe3F5AUUx1O_e3 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE g/x/crypto/inter--version GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet ortc�� 0426-50610/test-3036389970 stmain.go ingutil.test gh-aw ./cmd/gh-aw 64/bin/go ingutil.test (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuconfig /usr/bin/git 20352/b163/_pkg_tr GO111MODULE ache/go/1.25.8/x: git rev-�� --show-toplevel ache/go/1.25.8/xconfig /usr/bin/git ace-editor.md 4260806/b375/vetrev-parse /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git image:v1.0.0 -extld=gcc /usr/bin/gh git rev-�� --show-toplevel gh /usr/bin/git runs/20260427-23git s/3/artifacts /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv L0nF/R3iUEqf5PFeb3NCkL0nF pkg/mod/golang.org/x/text@v0.36.0/internal/format/format.go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile -p crypto/internal/rev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linuremote.origin.url 4260�� licyMinIntegrityOnlymin-integrity_with_repos=public_3780135677/001 4260806/b424/_testmain.go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile -p golang.org/x/texrev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x-importcfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260427-230426-50610/test-3036389970 -test.v=true ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile l -test.run=^Test -test.short=true--show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile rev-�� 4260806/b452/_pkg_.a -pack 4260806/b452=> --check **/*.cjs 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv . l /usr/bin/git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu-trimpath /usr/bin/git vaScript22042707git -trimpath ache/go/1.25.8/x--oneline git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git /tmp/go-build167git pkg/mod/golang.orev-parse /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv download 1 /usr/bin/git test-logs/run-1 GO111MODULE /opt/hostedtoolcHEAD git rev-�� --show-toplevel go /usr/bin/git runs/20260427-23git GO111MODULE /home/REDACTED/wor--show-toplevel git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build16720352/b131/importcfg -pack /home/REDACTED/go/pkg/mod/github.com/modelcontextprotocol/go-sdk@v1.5.0/mcp/client.go /hom�� --check scripts/**/*.js 64/bin/go .prettierignore ../../../**/*.js-o 64/bin/go go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv prettier --check 64/bin/go **/*.ts **/*.json --ignore-path git -c log.showsignatur-p log 64/bin/go -n1 --format=format:-o --end-of-options/tmp/go-build1414260806/b001/_pkg_.a go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv "prettier" --che-p GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ry=1 64/pkg/tool/linu-extld=gcc 4260806/b469/_pkg_.a mLsRemoteWithReagit mLsRemoteWithRearev-parse 64/pkg/tool/linu--show-toplevel infocmp -1 xterm-color 64/pkg/tool/linuorigin /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet .a YfB4YDUdE 64/pkg/tool/linu--show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv user.name Test User /usr/bin/git 03/001/test-frongit GO111MODULE n-dir/sh git rev-�� f/tags/v6 go sv '**/*.ts' '**/*.git GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /tmp/TestGuardPolicyTrustedUsersRequiresMinIntegrity1552050470/001 remote (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv jbdp/iQdC-QY6gnuLT2Ajjbdp 64/pkg/tool/linux_amd64/compile /usr/bin/gh .a 0/message/catalorev-parse 64/pkg/tool/linu--show-toplevel gh 4260�� download 4260806/b469/_testmain.go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet test-logs/run-1 fG0BeREzZ 64/pkg/tool/linu--show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /tmp/TestHashConsistency_Inlined--workflow go /usr/bin/git -json GO111MODULE 64/bin/go git conf�� --get remote.origin.url /usr/bin/git h ../../../.pretgit GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /tmp/go-build16720352/b065/_pkg_.a pkg/mod/golang.org/x/text@v0.36.0/message/catalog.go 4260806/b419/vet.cfg -p crypto/internal/rev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linuorigin -o licyMinIntegrityOnlymin-integrity_with_repos_array_c559256421/001 -trimpath /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link 01' 01' -lang=go1.21 /opt/hostedtoolcache/go/1.25.8/x-test.v=true (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260427-230426-50610/test-3036389970 -trimpath /usr/bin/git -p github.com/githurev-parse -lang=go1.25 git conf�� -aw/git/ref/tags/v3.0.0 test@example.com bject.type] | @tsv -c=4 -nolocalimports -importcfg git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv sistency_KeyOrdering119141197/001/test2.md --auto /usr/bin/git --detach /bin/sh 64/bin/go git -C /tmp/TestGuardPolicyTrustedUsersRequiresMinIntegrity1552050470/001 config ache/node/24.14.1/x64/bin/node remote.origin.urgit GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ons-test290393329 rev-parse ow-without-reaction.lock.yml -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go 0"}} -json GO111MODULE layTitle node (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv git-upload-pack '/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmaster_branch3628852081/001' l 9380568/b475/vet.cfg -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go epo.git ath ../../../.prinfocmp GO111MODULE 64/bin/go node (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linu-buildtags /usr/bin/git .a verutil.go 64/pkg/tool/linu--show-toplevel /usr/bin/git conf�� --get-regexp ^remote\..*\.gh-resolved$ /usr/bin/git .a DfcRFzBGz util.test git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv /tmp/TestGuardPolicyMinIntegrityOnlymin-integrittest-logs/run-3 rev-parse ache/node/24.14.1/x64/bin/node -json GO111MODULE 64/bin/go git t-16�� k/gh-aw/gh-aw/.github/workflows/agentic-observab-p go /usr/bin/git -json d/cpuid.go x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv run (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv /tmp/TestGuardPolicyMinIntegrityOnlymin-integrittest-logs/run-2 remote /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go ache/node/24.14.1/x64/bin/node -json GO111MODULE x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv GOMODCACHE l /usr/bin/git led-with-body-cogit GO111MODULE 64/bin/go git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-20 GOMOD GOMODCACHE 64/pkg/tool/linuremote.origin.url env .a GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-03-28 GOMOD GOMODCACHE 64/pkg/tool/linuremote.origin.url env y-test.md GO111MODULE 64/pkg/tool/linu-importcfg GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/pkg/stringutil/identifiers.go (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-01-27 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/asm env -json GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name JytyNgNV_ x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env tcfg 7zDW0_L0m ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE %H %ct %D (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 fG0BeREzZ 64/pkg/tool/linux_amd64/compile GOINSECURE t GOMODCACHE 64/pkg/tool/linutest@example.com env g_.a GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-nilfunc GOINSECURE 20352/b015/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-tests (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD erignore go env 0754-71761/test-1264209474/.github/workflows GO111MODULE e/git GOINSECURE GOMOD GOMODCACHE e/git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE /bidi GOMODCACHE 64/pkg/tool/linutest@example.com tcfg�� g_.a JmzP4TwGo x_amd64/link GOINSECURE %H %ct %D (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 m0O72i2Jk 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 3902635751/.github/workflows EocudEgAi ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 8BmvF0JImBC3z/ZFrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet env -json GO111MODULE ache/node/24.14.1/x64/bin/node GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name h00yucQ7c 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env stants.test Ffa_H-Eee ortcfg.link GOINSECURE GOMOD GOMODCACHE GWkazqzAVAIxY_VLl-/SmEOReLVhRl1gTest User (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE go-sdk/internal/init GOMODCACHE 64/pkg/tool/linux_amd64/compile tcfg�� 3902635751 64/src/time/format.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet env -json GO111MODULE (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name uVfRvwDwi x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env tcfg qrk06zUvD ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE r GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-test.v=true tcfg�� 3A5uknFb7 om/segmentio/encoding@v0.5.4/iso-test.run=^Test ache/go/1.25.8/x64/pkg/tool/linu-test.short=true GOINSECURE /atomic GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu/tmp/file-tracker-test3782735718/test2.lock.yml (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD erignore go env -json (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name KmEF_rn9z ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/xTest User env 30/001/test-empty-frontmatter.md GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE eader GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 cuiX4cYAj ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE g GOMODCACHE ache/go/1.25.8/xTest User env ility-kit.md GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 20352/b012/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD ode-gyp-bin/node--show-toplevel go env /ref/tags/v9 GO111MODULE sv GOINSECURE GOMOD GOMODCACHE e/git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name 5-yTJqrnP ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env plorer.md 0kiaYELPw x_amd64/vet wc -c < gh-aw.wagit GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 o 64/pkg/tool/linux_amd64/compile GOINSECURE age/compact GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a GO111MODULE k GOINSECURE til GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-trimpath (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD erignore go env 0754-71761/test-1264209474 GO111MODULE xpires.lock.yml GOINSECURE GOMOD GOMODCACHE e/git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name dAR9m3zY_ x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env tcfg RG6vPflge k GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 bt7zDc9ZF ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu--jq env 3JNRREtYX GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 20352/b012/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name GO111MODULE 1/x64/bin/node GOINSECURE GOMOD erignore go -has�� ithub/workflows/archie.md GO111MODULE Name,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 obyte GOMODCACHE 64/pkg/tool/linu--json tcfg�� -json 57OuoO-7M ache/go/1.25.8/x--created GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuremote.origin.url (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build1414260806/b404/cli.test /tmp/go-build1414260806/b404/cli.test -test.testlogfile=/tmp/go-build1414260806/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true -nolocalimports -importcfg /tmp/go-build16720352/b178/importcfg -pack -c "prettier" --che-p sh 64/bin/go "prettier" --wri/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile go 64/bin/go go (http block)
    • Triggering command: /tmp/go-build1919380568/b404/cli.test /tmp/go-build1919380568/b404/cli.test -test.testlogfile=/tmp/go-build1919380568/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel x2/zg1-jwF1IRoPasY5xy3c/9ezsDU_VWw7VJguVlRAx /usr/bin/git 20352/b001/exe/agit GO111MODULE 20352/b001/impor--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu-goversion /usr/bin/git 20352/b001/_pkg_wc pkg/mod/github.c-l /opt/hostedtoolcache/go/1.25.8/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv 30/001/test-frontmatter-with-nested-objects.md GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env 20352/b112/_pkg_.a GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD 20352/b047/symab--show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv lic_473175283/001 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env 03/001/test-simple-frontmatter.md GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json o x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile er_b�� -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv iant-2204886294 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json 1.5.0/oauthex/auth_meta.go x_amd64/compile GOINSECURE GOMOD runtime/sys/empt/repos/actions/github-script/git/ref/tags/v9 x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json nal.go x_amd64/compile GOINSECURE GOMOD bytealg/equal_wa/tmp/gh-aw-test-runs/20260427-230426-50610/test-3036389970 x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env Gitmain_branch632821449/001' Gitmain_branch632821449/001' 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv 0426-50610/test-source-field-variant-3829631128 om/goccy/go-yaml@v1.19.2/token/token.go k ata/action_pins.git fips140deps/byteinit GOMODCACHE ortcfg sRem�� p/smoke_test_22524436360.go Uv3n/ZHE1REwXxr2AmvwaUv3n ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE /go-yaml/ast GOMODCACHE ache/go/1.25.8/x12345 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv 969079/001 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env 03/001/test-frontmatter-with-arrays.md GO111MODULE n-dir/sh GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/xTest User tcfg�� 348865072/001 om/goccy/go-yaml@v1.19.2/ast/ast-c=4 sv GOINSECURE fips140deps/cpu GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu/tmp/go-build1414260806/b111/vet.cfg (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion m0s GOMOD (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo -importcfg /tmp/go-build1414260806/b434/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/repoutil/repoutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/repoutil/repoutil_test.go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state x_amd64/link GOINSECURE %H %ct %D (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env h ../../../.pret.prettierignore GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch 3A5uknFb7 om/segmentio/encoding@v0.5.4/iso-test.run=^Test ache/go/1.25.8/x64/pkg/tool/linu-test.short=true GOINSECURE /atomic GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu/tmp/file-tracker-test3782735718/test2.lock.yml tcfg�� rdian.md rg/x/text@v0.36.0/internal/number/common.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE fips140/bigmod 20352/b021/symabdownload ache/go/1.25.8/x5 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch /tmp/gh-aw-test-runs/20260427-230754-71761/test-3156423104/.github/workflows remote /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git e/git conf�� --local --get ode_modules/.bin/git =receive Test User ndor/bin/git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI and others added 2 commits April 27, 2026 22:58
Copilot AI changed the title [WIP] Cleanup: remove unused workflowData parameter from IsMCPScriptsEnabled cleanup: remove unused workflowData parameter from IsMCPScriptsEnabled Apr 27, 2026
Copilot AI requested a review from gh-aw-bot April 27, 2026 23:09
@pelikhan pelikhan marked this pull request as ready for review April 28, 2026 00:49
Copilot AI review requested due to automatic review settings April 28, 2026 00:49
@pelikhan pelikhan merged commit 4c1bae3 into main Apr 28, 2026
19 checks passed
@pelikhan pelikhan deleted the copilot/cleanup-remove-unused-workflowdata-parameter branch April 28, 2026 00:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused workflowData parameter from IsMCPScriptsEnabled and updates all internal call sites/tests accordingly, with an additional update to the pinned ruby/setup-ruby action version/sha.

Changes:

  • Simplified IsMCPScriptsEnabled signature to only accept *MCPScriptsConfig and removed the stale backward-compatibility note.
  • Updated all IsMCPScriptsEnabled call sites across MCP setup/detection/env/engine code paths to use the new signature.
  • Updated action pins data to bump ruby/setup-ruby from v1.305.0 to v1.306.0 (including SHA).
Show a summary per file
File Description
pkg/workflow/mcp_scripts_parser.go Drops unused workflowData parameter from IsMCPScriptsEnabled.
pkg/workflow/mcp_scripts_parser_test.go Removes unused workflowData from table tests and updates calls to new signature.
pkg/workflow/mcp_setup_generator.go Updates IsMCPScriptsEnabled call sites in MCP setup generation.
pkg/workflow/mcp_environment.go Updates environment-variable collection gating for mcp-scripts.
pkg/workflow/mcp_detection.go Updates MCP server detection gating call for mcp-scripts.
pkg/workflow/mcp_cli_mount.go Updates CLI-mounted server list gating for mcp-scripts.
pkg/workflow/engine_helpers.go Updates secret collection gating for mcp-scripts.
pkg/workflow/copilot_engine_tools.go Updates Copilot tool-allowlist gating for mcp-scripts.
pkg/workflow/copilot_engine_execution.go Updates env passthrough gating for mcp-scripts secrets.
pkg/workflow/copilot_engine.go Updates required-secret collection gating for mcp-scripts.
pkg/workflow/compiler_yaml_main_job.go Updates log artifact + summary parsing gating for mcp-scripts.
pkg/workflow/codex_mcp.go Updates Codex MCP config rendering gating for mcp-scripts.
pkg/workflow/codex_engine.go Updates env passthrough gating for mcp-scripts secrets.
pkg/workflow/claude_engine.go Updates env passthrough gating for mcp-scripts secrets.
pkg/workflow/data/action_pins.json Bumps ruby/setup-ruby pinned version + SHA.
pkg/actionpins/data/action_pins.json Mirrors the ruby/setup-ruby pin bump in the actionpins dataset.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 16/16 changed files
  • Comments generated: 5

@@ -39,7 +39,7 @@ func HasMCPServers(workflowData *WorkflowData) bool {
}

// Check if mcp-scripts is configured and feature flag is enabled (adds mcp-scripts MCP server)
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says mcp-scripts requires a feature flag, but IsMCPScriptsEnabled only checks whether tools are configured (no feature flag gating). Please update/remove the “feature flag is enabled” wording to match the actual behavior.

Suggested change
// Check if mcp-scripts is configured and feature flag is enabled (adds mcp-scripts MCP server)
// Check if mcp-scripts is configured (adds mcp-scripts MCP server)

Copilot uses AI. Check for mistakes.
@@ -109,7 +109,7 @@ func (e *CopilotEngine) computeCopilotToolArguments(tools map[string]any, safeOu
}

// Handle mcp_scripts MCP server - allow the server if mcp-scripts are configured and feature flag is enabled
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment mentions a feature flag requirement for mcp-scripts, but IsMCPScriptsEnabled only checks for configured tools. Update the comment so it doesn’t imply feature-flag gating that doesn’t exist.

Suggested change
// Handle mcp_scripts MCP server - allow the server if mcp-scripts are configured and feature flag is enabled
// Handle mcp_scripts MCP server - allow the server if mcp-scripts are configured

Copilot uses AI. Check for mistakes.
Comment thread pkg/workflow/codex_mcp.go
@@ -70,7 +70,7 @@ func (e *CodexEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]an
}
case "mcp-scripts":
// Add mcp-scripts MCP server if mcp-scripts are configured and feature flag is enabled
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment indicates mcp-scripts is added only when a feature flag is enabled, but the code path now (and IsMCPScriptsEnabled) only checks for configured tools. Please adjust the comment to reflect the actual enablement criteria.

Suggested change
// Add mcp-scripts MCP server if mcp-scripts are configured and feature flag is enabled
// Add mcp-scripts MCP server if mcp-scripts are configured

Copilot uses AI. Check for mistakes.
Comment on lines 74 to 82
{
name: "with tools and feature flag enabled - enabled (backward compat)",
config: configWithTools,
workflowData: &WorkflowData{
Features: map[string]any{"mcp-scripts": true},
},
name: "with tools and feature flag enabled - enabled (backward compat)",
config: configWithTools,
expected: true,
},
{
name: "with tools and feature flag disabled - still enabled (feature flag ignored)",
config: configWithTools,
workflowData: &WorkflowData{
Features: map[string]any{"mcp-scripts": false},
},
name: "with tools and feature flag disabled - still enabled (feature flag ignored)",
config: configWithTools,
expected: true,
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the workflowData parameter, several table cases here still reference “feature flag …” and are now duplicates of the “with tools” case (they all pass the same config and expect true). Consider renaming/removing the redundant cases so the test intent remains clear.

See below for a potential fix:

			name:     "with tools - enabled",
			config:   configWithTools,
			expected: true,
		},

Copilot uses AI. Check for mistakes.
Comment on lines +171 to 175
"ruby/setup-ruby@v1.306.0": {
"repo": "ruby/setup-ruby",
"version": "v1.305.0",
"sha": "0cb964fd540e0a24c900370abf38a33466142735"
"version": "v1.306.0",
"sha": "c4e5b1316158f92e3d49443a9d58b31d25ac0f8f"
},
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also updates the pinned ruby/setup-ruby action version/sha, but that change isn’t mentioned in the PR title/description. Please either document this additional change in the PR description or split it into a separate PR to keep the change set focused.

Copilot uses AI. Check for mistakes.
@github-actions github-actions Bot mentioned this pull request Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🧪 Test Quality Sentinel Report

Test Quality Score: 80/100

Excellent

Metric Value
New/modified tests analyzed 3
✅ Design tests (behavioral contracts) 3 (100%)
⚠️ Implementation tests (low value) 0 (0%)
Tests with error/edge cases 3 (100%)
Duplicate test clusters 0
Test inflation detected Yes (21 test lines / 1 production line = 21:1 ratio)
🚨 Coding-guideline violations None

Test Classification Details

Test File Classification Issues Detected
TestHasMCPScripts pkg/workflow/mcp_scripts_parser_test.go:9 ✅ Design None — table-driven, covers nil/empty/with-tools
TestIsMCPScriptsEnabled pkg/workflow/mcp_scripts_parser_test.go:46 ✅ Design 4 of 6 rows use identical configWithTools+true; minor redundancy
TestIsMCPScriptsEnabledWithEnv pkg/workflow/mcp_scripts_parser_test.go:101 ✅ Design None — verifies feature-flag env var no longer affects behavior

Notes

Test inflation flag — 21 lines were added to the test file while only 1 line changed in production (mcp_scripts_parser.go), giving a 21:1 ratio. This is expected for a cleanup PR that removes the workflowData parameter: the test file needed to drop all call-sites for that parameter. The inflation is structural, not an actual quality concern.

Minor redundancy in TestIsMCPScriptsEnabled — rows 4–6 ("with tools and feature flag enabled", "with tools and feature flag disabled", "with tools and other features") all use the same configWithTools and expect true. They're documenting that the feature-flag behavior was intentionally removed (backward compat), which is a valid reason to keep them. No action required.


Language Support

Tests analyzed:

  • 🐹 Go (*_test.go): 3 tests — unit (//go:build !integration)
  • 🟨 JavaScript (*.test.cjs, *.test.js): 0 tests

Verdict

Check passed. 0% of new tests are implementation tests (threshold: 30%). All three tests verify the observable boolean return value of HasMCPScripts and IsMCPScriptsEnabled under nil, empty, and populated inputs — solid behavioral coverage for this cleanup change.


📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

  • Assert on observable outputs, return values, or state changes
  • Cover error paths and boundary conditions
  • Would catch a behavioral regression if deleted
  • Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

  • Assert on internal function calls (mocking internals)
  • Only test the happy path with typical inputs
  • Break during legitimate refactoring even when behavior is correct
  • Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §25027682432

🧪 Test quality analysis by Test Quality Sentinel · ● 605.8K ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 80/100. Test quality is acceptable — 0% of new tests are implementation tests (threshold: 30%). All three tests verify observable boolean outputs across nil, empty, and populated MCPScriptsConfig inputs, giving solid behavioral coverage for this cleanup change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup: remove unused workflowData parameter from IsMCPScriptsEnabled

4 participants