fix: add missing debug mock to test files for core.debug calls in sanitize_content_core by Copilot · Pull Request #28824 · github/gh-aw

Copilot · 2026-04-28T00:12:15Z

sanitize_content_core.cjs recently gained core.debug() calls to log redacted URL details, but several test mocks only stub info/warning/error/setOutput — omitting debug. This caused TypeError: core.debug is not a function across multiple test files when URL redaction code paths were hit.

Changes

create_discussion_sanitization.test.cjs — Added missing debug: vi.fn() to mockCore
add_comment.test.cjs — Added missing debug: () => {} to mockCore
add_workflow_run_comment.test.cjs — Added missing debug: vi.fn() to mockCore

All three mocks now align with the full @actions/core interface that sanitize_content_core.cjs relies on.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ebd3eb9a-952b-4fb7-82fc-85a8b1cd87c7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-04-28T00:48:22Z

    // Extract domain for http/ftp/file/ssh/git protocols
    if (domain) {
      const domainLower = domain.toLowerCase();
      const sanitized = sanitizeDomainName(domainLower);


@copilot revert changes in this file

Done in 1c0bac3 — reverted sanitize_content_core.cjs to its original state and fixed the failures by adding debug: vi.fn() / debug: () => {} to the mockCore objects in the three affected test files (add_comment.test.cjs, add_workflow_run_comment.test.cjs, create_discussion_sanitization.test.cjs).

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…nstead Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6d45730d-3a22-4d5b-b159-1d722c5c3272 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-04-28T00:55:26Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

invalid.example.invalid
- Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git conf�� user.name lure ode_modules/.bin/git --bare .diff.tmp odules/npm/node_-b git init�� --bare iff.tmp option-test -b main n-dir/git git (dns block)
- Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git conf�� user.email test@example.com 64/bin/git -M .diff.tmp unning-branch git init�� --bare --initial-branch=main ache/go/1.25.8/x64/bin/git -b terations tions/setup/node-m git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Fixes Vitest failures caused by newly added core.debug() calls in sanitize_content_core.cjs by adding debug to several @actions/core mocks; also updates pinned ruby/setup-ruby action versions.

Changes:

Add debug to core mocks in multiple JS action tests to prevent TypeError: core.debug is not a function.
Bump ruby/setup-ruby pin from v1.305.0 to v1.306.0 (with updated SHA) in two action pin data files.

Show a summary per file

File	Description
pkg/workflow/data/action_pins.json	Updates the pinned `ruby/setup-ruby` version/SHA.
pkg/actionpins/data/action_pins.json	Mirrors the pinned `ruby/setup-ruby` version/SHA update.
actions/setup/js/create_discussion_sanitization.test.cjs	Adds `debug` to the `core` mock via `vi.fn()`.
actions/setup/js/add_workflow_run_comment.test.cjs	Adds `debug` to the global `core` mock via `vi.fn()`.
actions/setup/js/add_comment.test.cjs	Adds `debug` to the `core` mock (no-op function).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 5/5 changed files
Comments generated: 2

+    "ruby/setup-ruby@v1.306.0": {
      "repo": "ruby/setup-ruby",
-      "version": "v1.305.0",
-      "sha": "0cb964fd540e0a24c900370abf38a33466142735"
+      "version": "v1.306.0",
+      "sha": "c4e5b1316158f92e3d49443a9d58b31d25ac0f8f"
    },


+    "ruby/setup-ruby@v1.306.0": {
      "repo": "ruby/setup-ruby",
-      "version": "v1.305.0",
-      "sha": "0cb964fd540e0a24c900370abf38a33466142735"
+      "version": "v1.306.0",
+      "sha": "c4e5b1316158f92e3d49443a9d58b31d25ac0f8f"
    },


github-actions · 2026-04-28T01:03:21Z

🧪 Test Quality Sentinel Report

Test Quality Score: N/A (Infrastructure Fix)

✅ No new test functions — mock setup patched

Metric	Value
New/modified tests analyzed	0
✅ Design tests (behavioral contracts)	0 (N/A)
⚠️ Implementation tests (low value)	0 (N/A)
Tests with error/edge cases	0 (N/A)
Duplicate test clusters	0
Test inflation detected	No
🚨 Coding-guideline violations	None

Change Summary

This PR makes a 1-line fix to three JavaScript test files, adding the missing debug property to the mockCore stub objects in their beforeEach setup:

File	Change
`actions/setup/js/add_comment.test.cjs`	Added `debug: () => {}` to `mockCore`
`actions/setup/js/add_workflow_run_comment.test.cjs`	Added `debug: vi.fn()` to `mockCore`
`actions/setup/js/create_discussion_sanitization.test.cjs`	Added `debug: vi.fn()` to `mockCore`

No new test functions were added; the fix prevents crashes in existing behavioral tests caused by core.debug() being called without a corresponding mock stub. The existing tests themselves are behavioral (asserting on outputs, side-effects, and error paths) — this fix restores their ability to run correctly.

Language Support

Tests analyzed:

🟨 JavaScript (*.test.cjs): 0 new test functions (vitest) — 3 files patched at mock setup level

Verdict

✅ Check passed. No new test functions to evaluate; the change is a targeted infrastructure fix that correctly adds missing mock stubs required for existing tests.

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

Assert on observable outputs, return values, or state changes
Cover error paths and boundary conditions
Would catch a behavioral regression if deleted

Implementation Tests (Low Value) verify how the system does it:

Assert on internal function calls (mocking internals)
Only test the happy path with typical inputs
Break during legitimate refactoring even when behavior is correct

References:

§25027939282

🧪 Test quality analysis by Test Quality Sentinel · ● 795.3K · ◷

github-actions

✅ Test Quality Sentinel: N/A. No new test functions — this PR is a targeted infrastructure fix adding missing debug mock stubs to 3 test files. Existing behavioral tests are unaffected in quality. Check passed.

Initial plan

5375aa3

Copilot AI assigned Copilot and pelikhan Apr 28, 2026

Copilot started work on behalf of pelikhan April 28, 2026 00:12 View session

Copilot AI and others added 2 commits April 28, 2026 00:17

fix: add missing debug mock to create_discussion_sanitization test

24d4848

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ebd3eb9a-952b-4fb7-82fc-85a8b1cd87c7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

fix: use optional chaining for core.debug in sanitize_content_core.cjs

e163b34

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ebd3eb9a-952b-4fb7-82fc-85a8b1cd87c7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix failing GitHub Actions job JS Tests (shard 1/4)~~ fix: use optional chaining for core.debug calls in sanitize_content_core Apr 28, 2026

Copilot AI requested a review from pelikhan April 28, 2026 00:26

Copilot finished work on behalf of pelikhan April 28, 2026 00:26

pelikhan reviewed Apr 28, 2026

View reviewed changes

Copilot started work on behalf of pelikhan April 28, 2026 00:48 View session

Copilot AI and others added 2 commits April 28, 2026 00:52

Update; rm -rf /

c1cc1a0

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

fix: revert sanitize_content_core.cjs, add debug mock to test files i…

1c0bac3

…nstead Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6d45730d-3a22-4d5b-b159-1d722c5c3272 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~fix: use optional chaining for core.debug calls in sanitize_content_core~~ fix: add missing debug mock to test files for core.debug calls in sanitize_content_core Apr 28, 2026

Copilot finished work on behalf of pelikhan April 28, 2026 00:55

Copilot AI requested a review from pelikhan April 28, 2026 00:55

pelikhan approved these changes Apr 28, 2026

View reviewed changes

pelikhan marked this pull request as ready for review April 28, 2026 00:57

Copilot AI review requested due to automatic review settings April 28, 2026 00:57

pelikhan merged commit 0317247 into main Apr 28, 2026
24 checks passed

pelikhan deleted the copilot/fix-js-tests-shard-1-4 branch April 28, 2026 00:57

Copilot started reviewing on behalf of pelikhan April 28, 2026 00:58 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

github-actions Bot mentioned this pull request Apr 28, 2026

[aw] No-Op Runs #28785

Closed

github-actions Bot approved these changes Apr 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing debug mock to test files for core.debug calls in sanitize_content_core#28824

fix: add missing debug mock to test files for core.debug calls in sanitize_content_core#28824
pelikhan merged 5 commits intomainfrom
copilot/fix-js-tests-shard-1-4

Copilot AI commented Apr 28, 2026 •

edited

Loading

Uh oh!

pelikhan Apr 28, 2026

Uh oh!

Copilot AI Apr 28, 2026

Uh oh!

Copilot AI commented Apr 28, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pelikhan Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 28, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

github-actions Bot commented Apr 28, 2026

🧪 Test Quality Sentinel Report

Test Quality Score: N/A (Infrastructure Fix)

Change Summary

Language Support

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 28, 2026 •

edited

Loading