fix: replace manual loop with slices.Contains in isValidWorkflowRunConclusion#29130
Merged
fix: replace manual loop with slices.Contains in isValidWorkflowRunConclusion#29130
Conversation
…Conclusion Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ebd75a62-39f6-4f9d-b984-2c381589bc24 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job lint-go
fix: replace manual loop with slices.Contains in isValidWorkflowRunConclusion
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates isValidWorkflowRunConclusion to satisfy golangci-lint’s modernize/slicescontains by replacing a manual loop with slices.Contains.
Changes:
- Add the standard library
slicesimport. - Replace the manual
for/ifmembership check inisValidWorkflowRunConclusionwithslices.Contains.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/frontmatter_extraction_yaml.go | Uses slices.Contains for workflow run conclusion validation and adds the needed import. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint v2.8.0introduced themodernize/slicescontainsrule, which flagged a manual for-loop inisValidWorkflowRunConclusionthat should useslices.Contains.Changes
pkg/workflow/frontmatter_extraction_yaml.go: Replace manual loop withslices.Containsand add"slices"import