Skip to content

fix: remove unused name field in listFieldCase to fix lint-go CI#29239

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-workflow-failure-on-main
Apr 30, 2026
Merged

fix: remove unused name field in listFieldCase to fix lint-go CI#29239
pelikhan merged 2 commits intomainfrom
copilot/fix-workflow-failure-on-main

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

The lint-go CI job was failing on main due to an unused name string field in the listFieldCase struct introduced in pkg/workflow/config_parsing_helpers_test.go. The unused linter correctly flagged it since no test case ever populated the field — sub-tests already use t.Run("descriptive/name", ...) directly.

Changes

  • pkg/workflow/config_parsing_helpers_test.go: Drop the dead name string field from listFieldCase.
// Before
type listFieldCase struct {
    name      string
    value     any
    wantSlice []string
}

// After
type listFieldCase struct {
    value     any
    wantSlice []string
}

Copilot AI linked an issue Apr 30, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix workflow failure on main branch run #2102 fix: remove unused name field in listFieldCase to fix lint-go CI Apr 30, 2026
Copilot AI requested a review from pelikhan April 30, 2026 03:31
@pelikhan pelikhan marked this pull request as ready for review April 30, 2026 03:49
Copilot AI review requested due to automatic review settings April 30, 2026 03:49
@pelikhan pelikhan merged commit f390946 into main Apr 30, 2026
20 checks passed
@pelikhan pelikhan deleted the copilot/fix-workflow-failure-on-main branch April 30, 2026 03:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused field from a local test-case struct to fix lint-go failures caused by an unused linter warning.

Changes:

  • Remove the dead name string field from the listFieldCase struct in TestAllListEncodingForms.
Show a summary per file
File Description
pkg/workflow/config_parsing_helpers_test.go Drops unused name field from a local test helper struct to satisfy unused linter.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions github-actions Bot mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CGO] Workflow failure on main - Run #2102

3 participants