Remove top-level bots from main JSON schema#29592
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d86e86ac-50a5-4367-a4a9-4e36a2b5c456 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 1, 2026 18:41
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Removes bots as a valid top-level frontmatter property from the main workflow JSON schema to reflect actual compiler behavior (only on.bots is read) and avoid silently ignored configuration.
Changes:
- Deleted the root-level
botsproperty frompkg/parser/schemas/main_workflow_schema.json.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/schemas/main_workflow_schema.json | Removes root-level bots from the schema so only on.bots remains valid, matching compiler behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
8911
to
8914
| "additionalProperties": false | ||
| }, | ||
| "bots": { | ||
| "type": "array", | ||
| "description": "Allow list of bot identifiers that can trigger the workflow even if they don't meet the required role permissions. When the actor is in this list, the bot must be active (installed) on the repository to trigger the workflow.", | ||
| "items": { | ||
| "type": "string", | ||
| "minLength": 1, | ||
| "pattern": "^[A-Za-z0-9._\\[\\]-]+$", | ||
| "description": "Bot identifier/name (e.g., 'dependabot[bot]', 'renovate[bot]', 'github-actions[bot]')" | ||
| } | ||
| }, | ||
| "rate-limit": { | ||
| "type": "object", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
botsas a valid top-level frontmatter property frompkg/parser/schemas/main_workflow_schema.json.Changes
botsproperty definition from the main workflow schemaRationale
The compiler only reads
botsfromon.bots(where the property remains valid). Having it defined at the top level was misleading — any top-levelbotsvalue was silently ignored by the compiler, potentially causing user confusion.