fix: add messages_header.cjs to SAFE_OUTPUTS_FILES in setup.sh#29662
Merged
fix: add messages_header.cjs to SAFE_OUTPUTS_FILES in setup.sh#29662
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ff8a31cc-2aad-43fc-8bd0-cdf6e9f15f23 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job JS Tests (shard 4/4)
fix: add messages_header.cjs to SAFE_OUTPUTS_FILES in setup.sh
May 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes safe-outputs deployment by ensuring messages_header.cjs is included in SAFE_OUTPUTS_FILES, matching the transitive require("./messages_header.cjs") dependency chain (notably via messages.cjs) and unblocking the setup_sh_file_lists.test.cjs coverage check.
Changes:
- Add
messages_header.cjsto theSAFE_OUTPUTS_FILESarray inactions/setup/setup.sh.
Show a summary per file
| File | Description |
|---|---|
actions/setup/setup.sh |
Ensures messages_header.cjs is copied into the safe-outputs deployment set so runtime and dependency-coverage checks include it. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
messages.cjshas arequire('./messages_header.cjs')dependency, butmessages_header.cjswas never added to theSAFE_OUTPUTS_FILESdeployment list insetup.sh. This caused thesetup_sh_file_lists.test.cjstransitive-dependency coverage check to fail.Changes
actions/setup/setup.sh: Added"messages_header.cjs"toSAFE_OUTPUTS_FILES, alongside the othermessages_*.cjsentries.