Conversation
… metrics Add debug logging to 5 files that previously had no log output: - pkg/workflow/awf_config.go: log BuildAWFConfigJSON entry, network domains, API proxy targets, container image tag, and output size - pkg/cli/mcp_argument_validation.go: log intercepted unknown param errors, similarity search start, and match/no-match outcomes - pkg/cli/audit_report_experiments.go: log experiment state file discovery, extraction progress, and per-experiment variant selection - pkg/cli/logs_safe_output_chains.go: log artifact presence check, manifest entry count, temporary ID map status, and computed chain metrics - pkg/workflow/safe_outputs_needs_validation.go: log needs count, available custom jobs, and validation failure reasons Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pelikhan
deleted the
log/add-debug-logging-awf-config-mcp-experiments-69f632ffff152a49
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug logging to 5 files that previously had no log output, following the
pkg:filenamenaming convention from AGENTS.md.Files changed
pkg/workflow/awf_config.go— Newworkflow:awf_configlogger. LogsBuildAWFConfigJSONentry (engine name, allowed domains), network allow/block domain counts, each custom API proxy target added (openai/anthropic/copilot/gemini), container image tag, and final JSON byte count.pkg/cli/mcp_argument_validation.go— Newcli:mcp_argument_validationlogger. Logs when the middleware intercepts an unknown-parameter error (tool name + params), whenfindSimilarParamstarts searching, and whether a match was found above the 0.7 threshold.pkg/cli/audit_report_experiments.go— Newcli:audit_report_experimentslogger. Logs experiment data extraction start, state file discovery (or absence), experiment count, and per-experiment variant selection.pkg/cli/logs_safe_output_chains.go— Newcli:logs_safe_output_chainslogger. Logs when no artifacts are present (early return), manifest entry count, temporary ID map status and mapping count, and the final chain metrics (chained targets, followup actions, delegated, closed).pkg/workflow/safe_outputs_needs_validation.go— Enhances the existingworkflow:safe_outputs_needs_validationlogger (1 call → 4 calls). Adds logging for the declared needs count, available custom jobs count, and per-need validation failures (reserved name / unknown job).Test plan
make build— validates compilation (currently blocked by pre-existing Go toolchain version mismatch: go.mod requires 1.25.8, CI has 1.24.13)make test-unit— runs unit testsDEBUG=workflow:awf_config,cli:mcp_argument_validation,cli:audit_report_experiments,cli:logs_safe_output_chains,workflow:safe_outputs_needs_validation ./gh-aw compile dev— validates debug output appears🤖 Generated with [Claude Code]((claude.com/redacted)