fix(ci): pass github.token via env mapping instead of direct run interpolation#29719
Merged
fix(ci): pass github.token via env mapping instead of direct run interpolation#29719
Conversation
… run block (RGS-008) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/10fad895-6771-48d7-b155-3c87986a598c Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix secret directly interpolated in run block in ci.yml
fix(ci): pass github.token via env mapping instead of direct run interpolation
May 2, 2026
pelikhan
approved these changes
May 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to avoid embedding ${{ github.token }} directly inside a run: script by passing it via the step’s env: mapping, addressing a runner-guard finding (RGS-008).
Changes:
- Add
env: GH_TOKEN: ${{ github.token }}to the “Clone github/gh-aw-marketplace repository” step. - Update the shell script to reference
${GH_TOKEN}instead of inlining the expression.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Moves github.token usage out of the shell script body into env for the marketplace clone step. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+782
to
783
| AUTH_HEADER=$(printf 'x-access-token:%s' "${GH_TOKEN}" | base64 | tr -d '\n') | ||
| git -c http.https://github.com/.extraheader="Authorization: Basic ${AUTH_HEADER}" clone --depth 1 https://github.com/github/gh-aw-marketplace.git |
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly interpolating
${{ github.token }}inside arun:block embeds the token as plain text in the shell script before execution, exposing it to log output, process listings, and shell injection if the value contains metacharacters.Change
Move
github.tokenout of the shell script body and into the step'senv:mapping in the "Clone github/gh-aw-marketplace repository" step ofci.yml.Resolves RGS-008 (runner-guard static analysis finding, severity: High).