Conversation
…d runtime-imports" Agent-Logs-Url: https://github.com/github/gh-aw/sessions/695cc41a-458f-47d5-bc3d-4d944c285ada Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/695cc41a-458f-47d5-bc3d-4d944c285ada Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 2, 2026 17:48
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds best-effort validation for inline sub-agent frontmatter blocks found in imported files and {{#runtime-import}} targets, surfacing unknown-field (and parse) issues as non-fatal warnings.
Changes:
- Introduces
ValidateInlineSubAgentsFrontmatterto scan for inline sub-agents and validate allowed frontmatter keys. - Accumulates and propagates import-traversal warnings via
ImportsResult.Warnings, and prints them during compilation. - Validates runtime-imported files for inline sub-agent frontmatter and emits warnings; adds unit tests for the validator.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/sub_agent_extractor.go | Adds inline sub-agent frontmatter validation + warning generation. |
| pkg/parser/import_field_extractor.go | Invokes validation during import BFS and accumulates warnings. |
| pkg/parser/import_processor.go | Extends ImportsResult to carry collected warnings. |
| pkg/workflow/compiler_orchestrator_tools.go | Emits collected import warnings to stderr and increments warning count. |
| pkg/workflow/runtime_import_validation.go | Validates runtime-imported files for inline sub-agent frontmatter and prints warnings. |
| pkg/parser/sub_agent_validation_test.go | Adds unit tests covering validator behavior across common cases. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 4
| } | ||
|
|
||
| _, subAgents, err := ExtractInlineSubAgents(body) | ||
| if err != nil || len(subAgents) == 0 { |
Comment on lines
+125
to
+128
| // Best-effort: detect and validate inline sub-agent frontmatter in the imported file. | ||
| // Unknown fields in sub-agent frontmatter blocks are surfaced as advisory warnings. | ||
| // Validation failures never abort the import — they are accumulated for later display. | ||
| if agentWarnings := ValidateInlineSubAgentsFrontmatter(rawContent); len(agentWarnings) > 0 { |
Comment on lines
+153
to
+157
| if agentWarnings := parser.ValidateInlineSubAgentsFrontmatter(string(content)); len(agentWarnings) > 0 { | ||
| for _, w := range agentWarnings { | ||
| msg := fmt.Sprintf("runtime-import '%s': %s", filePath, w) | ||
| expressionValidationLog.Printf("%s", msg) | ||
| fmt.Fprintln(os.Stderr, console.FormatWarningMessage(msg)) |
Comment on lines
+143
to
+144
| "sub-agent %q: unknown frontmatter field(s) %v (valid fields: description, model)", | ||
| agent.Name, unknown, |
…validation Captures the decision to validate inline sub-agent frontmatter fields (restricting to 'description' and 'model') as advisory warnings during import BFS traversal and runtime-import resolution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Commit pushed:
|
Contributor
🧪 Test Quality Sentinel ReportTest Quality Score: 86/100✅ Excellent
Test Classification DetailsView all 8 test classifications
Flagged Tests — Requires ReviewNo tests are flagged for behavioral quality. One informational note below. i️ Test Inflation (informational only)The new test file ( However, the test file also implicitly exercises code paths in The 8 tests are genuinely covering distinct scenarios rather than padded variants. No action required; the high test volume reflects meaningful coverage of a purely new function. Language SupportTests analyzed:
Verdict
📖 Understanding Test ClassificationsDesign Tests (High Value) verify what the system does:
Implementation Tests (Low Value) verify how the system does it:
Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators. References:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
@copilot review all comments |
Collaborator
|
@copilot update the instructions file to explain that if a AW plans to modify any top level markdown files, it should exclude them from protected-files in the front matter |
… parse, increment warning counter, comma-join field names Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b194ddc4-3a1a-4f50-9630-f5ac261f3fa8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Addressed all four reviewer comments in commit a0d521a:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot stopped work on behalf of
pelikhan due to an error
May 2, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Go compiler processes
imports:frontmatter entries or{{#runtime-import}}body directives and detects inline sub-agent syntax (## agent: \name``), it now performs best-effort syntax validation of the sub-agent frontmatter blocks in those files.Changes
pkg/parser/sub_agent_extractor.goValidateInlineSubAgentsFrontmatter(markdown string) []string— strips the top-level frontmatter, scans the body for## agent: \name`sections, parses each sub-agent's frontmatter block, and returns warning messages for any unknown fields (descriptionandmodel` are the only valid fields).validateSubAgentFrontmatterFields(internal helper) that validates a singleInlineSubAgent.pkg/parser/import_field_extractor.goValidateInlineSubAgentsFrontmatterfor every file visited during BFS import traversal.warnings []stringfield toimportAccumulatorto collect advisory messages.pkg/parser/import_processor.goWarnings []stringtoImportsResultso collected warnings propagate to the compiler.pkg/workflow/compiler_orchestrator_tools.goimportsResult.Warningsto stderr as console warnings (best-effort, never fails compilation).pkg/workflow/runtime_import_validation.goparser.ValidateInlineSubAgentsFrontmatterfor each runtime-imported file and emits warnings to stderr.pkg/parser/sub_agent_validation_test.go(new)Behavior
⚠ Warning:messages on stderr; compilation always continues.