Conversation
…D; simplification to single-experiment API not recommended Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7a854352-d2c2-4183-aebf-9a5d12532128 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 4, 2026 03:34
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a set of GitHub Actions workflow lockfiles by changing the Copilot CLI --allow-tool shell(...) allowlist entries (and their generated comments), primarily by replacing previously specific commands containing single quotes with shorter “prefix” forms.
Changes:
- Regenerates Copilot CLI tool allowlists in multiple
*.lock.ymlworkflows (notablyfind,grep,git log,jqpatterns). - Updates the corresponding “Copilot CLI tool arguments (sorted)” comment blocks to match the new allowlist entries.
- Normalizes/loosens some command allowlists by removing quoted patterns and paths from the
shell(...)strings.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/workflow-skill-extractor.lock.yml | Updates shell(find ...) / shell(grep ...) allowlist entries and their comment block. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Updates shell(find ...) allowlist entry and corresponding comment. |
| .github/workflows/spec-librarian.lock.yml | Truncates several find/grep/git log allowlist entries to prefix forms; updates comments accordingly. |
| .github/workflows/spec-extractor.lock.yml | Updates find/grep allowlist entries and comments. |
| .github/workflows/layout-spec-maintainer.lock.yml | Simplifies find/grep/yq allowlist entries; updates comments accordingly. |
| .github/workflows/discussion-task-miner.lock.yml | Updates find allowlist entry; updates comments accordingly. |
| .github/workflows/delight.lock.yml | Updates find allowlist entries for docs/workflows; updates comments accordingly. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Truncates find/grep allowlist entries; updates comments accordingly. |
| .github/workflows/daily-safe-output-integrator.lock.yml | Truncates find/grep allowlist entries; updates comments accordingly. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Truncates find/git log/grep/jq allowlist entries; updates comments accordingly. |
| .github/workflows/daily-file-diet.lock.yml | Truncates find/grep allowlist entries; updates comments accordingly. |
| .github/workflows/daily-compiler-quality.lock.yml | Truncates find/git log/grep allowlist entries; updates comments accordingly. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Truncates find pkg -name ... allowlist entry; updates comments accordingly. |
| .github/workflows/ab-testing-advisor.lock.yml | Truncates several find/grep allowlist entries; updates comments accordingly. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 14/14 changed files
- Comments generated: 2
Comment on lines
718
to
722
| # --allow-tool shell(cat) | ||
| # --allow-tool shell(date) | ||
| # --allow-tool shell(echo) | ||
| # --allow-tool shell(find .github/workflows -maxdepth 1 -name '*.md' ! -name 'shared' -type f) | ||
| # --allow-tool shell(find .github/workflows -maxdepth 1 -name) | ||
| # --allow-tool shell(find) |
Comment on lines
+721
to
+726
| # --allow-tool shell(find .github/workflows -maxdepth 1 -name) | ||
| # --allow-tool shell(find) | ||
| # --allow-tool shell(grep -c) | ||
| # --allow-tool shell(grep -l 'experiments:' .github/workflows/*.md) | ||
| # --allow-tool shell(grep -rL 'experiments:' .github/workflows/*.md) | ||
| # --allow-tool shell(grep -rn 'experiments:' .github/workflows/*.md) | ||
| # --allow-tool shell(grep -l) | ||
| # --allow-tool shell(grep -rL) | ||
| # --allow-tool shell(grep -rn) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assessed the repo-branch experiment storage strategy and evaluated whether the API should be collapsed to one experiment per workflow ID.
Branch storage
The current
repostorage mode uses a single branch per workflow (experiments/{sanitizedWorkflowID}) with a singlestate.jsonwhosecountsobject is keyed by experiment name. Multiple experiments per workflow ID are fully supported today — no structural change needed.{ "counts": { "style": { "concise": 5, "detailed": 4 }, "caveman": { "yes": 3, "no": 3 } }, "runs": [{ "run_id": "...", "assignments": { "style": "concise", "caveman": "yes" } }] }All experiments for one workflow share one branch, one
state.json, and onepush_experiments_statejob — cost is fixed regardless of experiment count.Single-experiment API simplification
Not recommended:
state.json,pick_experiment.cjs, andpush_experiments_stateall operate identically whether there is 1 or N experiments. A schema-level restriction would add enforcement code without removing any runtime complexity.The one genuine awkwardness — the
storagereserved-key collision inside theexperimentsmap — could be addressed independently by promotingstorageto a top-level key (e.g.,experiments_storage: repo) without collapsing the multi-experiment capability.