[log] add debug logging to 5 Go packages#30061
Merged
Conversation
…ackages Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
logger.New(...)declarations and meaningfullog.Printf/log.Printcalls to 5 previously unlogged files across theworkflow,parser, andclipackages.Files changed
pkg/workflow/model_identifier.go— logs identifier parse entry, which branch is taken (provider-scoped, glob, bare name), query param count, and final resultpkg/workflow/model_aliases.go— logs import/frontmatter layer merge counts and final alias map sizepkg/workflow/heredoc_validation.go— logs delimiter validation attempts and detected injection attemptspkg/parser/sub_agent_extractor.go— logs extraction entry, marker count, duplicate detection, per-agent extraction, and completion summarypkg/cli/experiments_analyze_statistics.go— logs analysis entry, degenerate-case short-circuit, chi-square balance result, and final recommendationLogger naming convention
All loggers follow the
"pkg:filename"convention already used in the codebase:modelIdentifierLog = logger.New("workflow:model_identifier")modelAliasesLog = logger.New("workflow:model_aliases")heredocLog = logger.New("workflow:heredoc_validation")subAgentLog = logger.New("parser:sub_agent_extractor")experimentsStatsLog = logger.New("cli:experiments_statistics")Testing
make buildfails in this environment due to a pre-existing Go toolchain version constraint (go.modrequires 1.25.8, environment has 1.24.13). The changes are purely additive (new logger var + Printf calls), follow patterns used in hundreds of other files in the codebase, and do not alter any logic paths.