Skip to content

Fix stale $INSTRUCTION assertion in TestEngineArgsIntegrationCodex #30100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
May 4, 2026
+37 −7
Merged

Fix stale $INSTRUCTION assertion in TestEngineArgsIntegrationCodex #30100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ecd893
Initial plan
Copilot May 4, 2026
42c4103
Initial plan for CI fix
Copilot May 4, 2026
e322c08
Fix TestEngineArgsIntegrationCodex: use --prompt-file instead of $INS…
Copilot May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/actionpins/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
"version": "v5.0.5",
"sha": "27d5ce7f107fe9357f9df03efb73ab90386fccae"
},
"actions/cache/save@v4": {
"repo": "actions/cache/save",
"version": "v4",
"sha": "0057852bfaa89a56745cba8c7296529d2fc39830"
},
"actions/cache/save@v5.0.5": {
"repo": "actions/cache/save",
"version": "v5.0.5",
Expand All @@ -48,6 +53,11 @@
"version": "v5.0.5",
"sha": "27d5ce7f107fe9357f9df03efb73ab90386fccae"
},
"actions/checkout@v4": {
"repo": "actions/checkout",
"version": "v4",
"sha": "34e114876b0b11c390a56381ad16ebd13914f8d5"
},
"actions/checkout@v6.0.2": {
"repo": "actions/checkout",
"version": "v6.0.2",
Expand Down Expand Up @@ -88,6 +98,11 @@
"version": "v6.4.0",
"sha": "48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e"
},
"actions/setup-python@v5": {
"repo": "actions/setup-python",
"version": "v5",
"sha": "a26af69be951a213d495a4c3e4e4022e16d87065"
},
"actions/setup-python@v6.2.0": {
"repo": "actions/setup-python",
"version": "v6.2.0",
Expand Down
15 changes: 15 additions & 0 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
"version": "v5.0.5",
"sha": "27d5ce7f107fe9357f9df03efb73ab90386fccae"
},
"actions/cache/save@v4": {
"repo": "actions/cache/save",
"version": "v4",
"sha": "0057852bfaa89a56745cba8c7296529d2fc39830"
},
Comment on lines +41 to +45
"actions/cache/save@v5.0.5": {
"repo": "actions/cache/save",
"version": "v5.0.5",
Expand All @@ -48,6 +53,11 @@
"version": "v5.0.5",
"sha": "27d5ce7f107fe9357f9df03efb73ab90386fccae"
},
"actions/checkout@v4": {
"repo": "actions/checkout",
"version": "v4",
"sha": "34e114876b0b11c390a56381ad16ebd13914f8d5"
},
"actions/checkout@v6.0.2": {
"repo": "actions/checkout",
"version": "v6.0.2",
Expand Down Expand Up @@ -88,6 +98,11 @@
"version": "v6.4.0",
"sha": "48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e"
},
"actions/setup-python@v5": {
"repo": "actions/setup-python",
"version": "v5",
"sha": "a26af69be951a213d495a4c3e4e4022e16d87065"
},
"actions/setup-python@v6.2.0": {
"repo": "actions/setup-python",
"version": "v6.2.0",
Expand Down
14 changes: 7 additions & 7 deletions pkg/workflow/engine_args_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,19 +258,19 @@ This is a test workflow to verify codex engine args injection.

result := string(content)

// Check that the compiled YAML contains the custom args before INSTRUCTION
// Check that the compiled YAML contains the custom args before --prompt-file
if !strings.Contains(result, "--custom-flag value") {
t.Errorf("Expected compiled YAML to contain '--custom-flag value'")
}

// Verify args come before "$INSTRUCTION"
// Verify args come before "--prompt-file" (codex uses harness with --prompt-file)
customFlagIdx := strings.Index(result, "--custom-flag value")
instructionIdx := strings.Index(result, "\"$INSTRUCTION\"")
if customFlagIdx == -1 || instructionIdx == -1 {
t.Fatal("Could not find both --custom-flag and $INSTRUCTION in compiled YAML")
promptFileIdx := strings.Index(result, "--prompt-file")
if customFlagIdx == -1 || promptFileIdx == -1 {
t.Fatal("Could not find both --custom-flag and --prompt-file in compiled YAML")
}
if customFlagIdx > instructionIdx {
t.Error("Expected --custom-flag to come before $INSTRUCTION in compiled YAML")
if customFlagIdx > promptFileIdx {
t.Error("Expected --custom-flag to come before --prompt-file in compiled YAML")
}
}

Expand Down
Loading