Add mattpocock-skills-reviewer agentic workflow

[Copilot]

• Create .github/workflows/mattpocock-skills-reviewer.md workflow that:
  • Triggers on pull_request: types: [ready_for_review]
  • Installs mattpocock/skills via shared/apm.md
  • Uses shared/pr-review-base.md for base PR review setup
  • Analyzes PR changes and selects appropriate mattpocock skills (diagnose, tdd, zoom-out, improve-codebase-architecture, grill-with-docs)
  • Creates up to 10 inline PR review comments with improvement suggestions
  • Submits a PR review (APPROVE / REQUEST_CHANGES / COMMENT)
  • Posts optional summary comment
• Compile the workflow (.github/workflows/mattpocock-skills-reviewer.lock.yml generated)
• Format with make fmt

Security Review

New secrets and actions introduced by this compilation:

Item	Type	Reason it is safe
GH_AW_PLUGINS_TOKEN	Secret	Standard APM optional token for private package access; used by microsoft/apm-action via the existing shared/apm.md shared workflow. Already used by all other workflows that install APM packages (e.g., smoke-claude.md).
microsoft/apm-action	Action	Pinned to microsoft/apm-action@v1.5.0 inside shared/apm.md. Already trusted and used by all APM workflows in this repo. No new action pin introduced.

[github-actions]

Hey @copilot-swe-agent 👋 — great addition of the mattpocock-skills-reviewer workflow! The PR is well-scoped (new workflow source + compiled lock + action pin data updates), the security review table is a nice touch, and the author association is correct for core-team agent PRs.

One thing to address before merging:

• Add tests — the CONTRIBUTING.md requires tests for new functionality, but no test files are included in this diff. The new workflow logic (skill selection, comment generation, review submission) should have corresponding test coverage. Check how other workflow tests are structured in the repo (e.g., alongside existing .md workflows) and add equivalent coverage for mattpocock-skills-reviewer.
• Run make agent-finish — the PR body shows make fmt was run, but the contributing guide requires make agent-finish before completing. Confirm CI checks pass end-to-end.

If you'd like a hand, you can assign this prompt to your coding agent:

Add tests for the new mattpocock-skills-reviewer agentic workflow introduced in .github/workflows/mattpocock-skills-reviewer.md.

1. Look at existing workflow test files in the repository to understand the test patterns used.
2. Write equivalent tests for the mattpocock-skills-reviewer workflow covering:
   - Skill selection logic based on PR change types
   - Inline comment generation (up to 10 comments)
   - Review verdict logic (APPROVE / REQUEST_CHANGES / COMMENT)
3. Ensure `make agent-finish` passes with the new tests included.

Generated by Contribution Check · ● 1.5M · ◷

[Copilot]

Pull request overview

Adds a new agentic workflow that performs skills-based PR reviews using the mattpocock/skills APM package, and updates the repository’s action pin catalogs to include additional commonly-used major-version action refs.

Changes:

• Added mattpocock-skills-reviewer workflow (markdown source) that triggers on pull_request: ready_for_review, installs mattpocock/skills, and produces up to 10 inline review comments plus a submitted PR review via safe-outputs.
• Added the compiled workflow lock file for the new workflow.
• Expanded action pin datasets to include actions/cache/save@v4, actions/checkout@v4, and actions/setup-python@v5.

Show a summary per file

File	Description
pkg/workflow/data/action_pins.json	Adds additional pinned action entries for major-version tags used in workflows/docs.
pkg/actionpins/data/action_pins.json	Mirrors the same new pinned action entries in the actionpins dataset.
.github/workflows/mattpocock-skills-reviewer.md	New Copilot workflow prompt/config for Matt Pocock skills-based PR reviews.
.github/workflows/mattpocock-skills-reviewer.lock.yml	Compiled lock output for the new workflow.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 4/4 changed files
• Comments generated: 0