Conversation
Convert pkg/cli/spec_test.go from internal package test (package cli) to external test package (package cli_test), removing tests for unexported internal functions that violate specification-first testing methodology. Rename TestIsCommitSHA to TestSpec_PublicAPI_IsCommitSHA for consistent naming convention. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR updates specification-driven tests for the following packages:
clipackage clitopackage cli_test; removed internal function testsPackages Reviewed (No Changes Needed)
actionpinsagentdrainChanges Made
pkg/cli/spec_test.go:package cli(internal) topackage cli_test(external) — the correct form for specification-driven testsparseRepoSpec,parseWorkflowSpec,parseSourceSpec,buildSourceStringWithCommitSHA) that violate the spec-first methodologyTestIsCommitSHA→TestSpec_PublicAPI_IsCommitSHAfor consistent naming conventiongithub.com/github/gh-aw/pkg/cliimport andcli.prefixes throughoutTest Derivation
All tests are derived from README.md specifications, not from implementation source code.
Spec-Implementation Mismatches (Previously Documented)
actionpins:GetActionPins()documented in README but not implemented; proxy test viaGetActionPinsByRepoagentdrain:ClusterCount()referenced in README but not implemented;len(Clusters())used insteadRound-Robin State
Auto-generated by Package Specification Enforcer workflow (§25317826810)