Skip to content

feat: Add daily Grafana OTel Instrumentation workflow#30190

Merged
mnkiefer merged 4 commits intomainfrom
add-grafana-reporting
May 4, 2026
Merged

feat: Add daily Grafana OTel Instrumentation workflow#30190
mnkiefer merged 4 commits intomainfrom
add-grafana-reporting

Conversation

@mnkiefer
Copy link
Copy Markdown
Collaborator

@mnkiefer mnkiefer commented May 4, 2026

  • Adds workflow leverages Grafana traces to identify impactful improvements. It generates actionable GitHub issues based on the findings, enhancing observability and developer experience.

@mnkiefer mnkiefer self-assigned this May 4, 2026
@mnkiefer mnkiefer marked this pull request as ready for review May 4, 2026 17:15
Copilot AI review requested due to automatic review settings May 4, 2026 17:15
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new daily agentic workflow that queries Grafana tracing data to evaluate the repository’s OpenTelemetry (OTel) instrumentation and files a single actionable GitHub issue for the highest-impact improvement.

Changes:

  • Introduces a new markdown-based gh-aw workflow definition for a “Daily Grafana OTel Instrumentation Advisor”.
  • Adds the compiled/pinned .lock.yml workflow produced by gh aw compile for scheduled execution in GitHub Actions.
Show a summary per file
File Description
.github/workflows/daily-grafana-otel-instrumentation-advisor.md Defines the workflow prompt, Grafana MCP server configuration, and safe-output behavior (create at most one issue/day).
.github/workflows/daily-grafana-otel-instrumentation-advisor.lock.yml Generated compiled workflow used by GitHub Actions (jobs, permissions, scheduling, safe-outputs handling).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread .github/workflows/daily-grafana-otel-instrumentation-advisor.md Outdated
@github-actions github-actions Bot mentioned this pull request May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Hey @mnkiefer 👋 — great addition! A daily workflow that mines Grafana OTel traces and surfaces actionable GitHub issues sounds like a fantastic observability improvement for the project.

One thing that would help get this across the finish line:

  • Add tests — the new workflow (daily-grafana-otel-instrumentation-advisor.lock.yml, 1,493 lines) doesn't appear to have any associated test coverage. Even a lightweight integration/smoke test or a workflow validation step (e.g., using actionlint or a test workflow that exercises the main job logic) would go a long way toward maintainability. Also, per the contributing guidelines, make sure to run make agent-finish before marking this ready (build, test, recompile, fmt, lint).

If you'd like a hand, you can assign this prompt to your coding agent:

For the new GitHub Actions workflow at .github/workflows/daily-grafana-otel-instrumentation-advisor.lock.yml, do the following:
1. Run `actionlint` (or equivalent YAML linter) on the workflow file and fix any issues reported.
2. Add a companion test workflow (e.g., `.github/workflows/test-daily-grafana-otel-instrumentation-advisor.yml`) that exercises the core job steps using mock/stub inputs so CI can validate the logic without requiring live Grafana credentials.
3. Run `make agent-finish` and fix any build, lint, or formatting issues it surfaces.

Generated by Contribution Check · ● 1.9M ·

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

✅ smoke-ci: safeoutputs CLI comment + comment-memory run (25333190632)

Generated by Smoke CI for issue #30190 ·

@mnkiefer
Copy link
Copy Markdown
Collaborator Author

mnkiefer commented May 4, 2026

@copilot Run make fmt and lint.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

@copilot Run make fmt and lint.

Done. Ran make fmt and make lint — both pass. Commit 0e629df applies the formatting fixes to the lock files.

@mnkiefer mnkiefer merged commit 65f21c8 into main May 4, 2026
@mnkiefer mnkiefer deleted the add-grafana-reporting branch May 4, 2026 18:07
Copilot stopped work on behalf of mnkiefer due to an error May 4, 2026 18:08
Copilot AI pushed a commit that referenced this pull request May 4, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants