Skip to content

fix: add actions: read permission to smoke-water.yml (#investigate-smoke-water-failure)#30197

Merged
pelikhan merged 1 commit intomainfrom
copilot/investigate-smoke-water-failure
May 4, 2026
Merged

fix: add actions: read permission to smoke-water.yml (#investigate-smoke-water-failure)#30197
pelikhan merged 1 commit intomainfrom
copilot/investigate-smoke-water-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

Root Cause

smoke-water.yml has been failing with startup_failure (0 jobs) since April 7, 2026. Every run since then returns startup_failure before any job can execute.

Investigation

The failure was traced to commit d7bd4dce79 (Apr 7) which added actions: read to the activation job's permissions in smoke-workflow-call.lock.yml. However, the calling workflow smoke-water.yml was not updated to grant this permission to the job that calls the reusable workflow.

In GitHub Actions, when using workflow_call, the called workflow's jobs can only use permissions that the caller's job explicitly grants. If a callee job requests a permission not listed in the caller's job permissions block, the entire workflow fails with startup_failure before any jobs run.

Permissions mismatch (before fix):

  • Callee activation job required: actions: read, contents: read
  • Caller smoke-water.yml job granted: contents: read, discussions: write, issues: write, pull-requests: write
  • Missing: actions: read ← caused startup_failure

Fix

Add actions: read to smoke-water.yml's job-level permissions block so the callee's activation job can use it.

…equirements

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/5458d9dc-e5c0-409a-bcf9-ae4c5b1d06c2

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review May 4, 2026 18:33
Copilot AI review requested due to automatic review settings May 4, 2026 18:33
@pelikhan pelikhan merged commit 266d691 into main May 4, 2026
@pelikhan pelikhan deleted the copilot/investigate-smoke-water-failure branch May 4, 2026 18:33
Copilot stopped work on behalf of pelikhan due to an error May 4, 2026 18:33
Copilot AI requested a review from pelikhan May 4, 2026 18:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes smoke-water.yml failing with startup_failure by aligning the caller job’s permissions with the permissions requested by the called reusable workflow.

Changes:

  • Add actions: read to the call-smoke-workflow-call job permissions in .github/workflows/smoke-water.yml.
Show a summary per file
File Description
.github/workflows/smoke-water.yml Grants actions: read at the caller job level so the reusable workflow’s activation job permissions are satisfied, preventing startup_failure.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Copilot AI added a commit that referenced this pull request May 4, 2026
…equirements (#30197)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants