Skip to content

test(parser): improve import_cache_test.go quality per testify-expert criteria #30218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
May 5, 2026
+27 −4
Merged

test(parser): improve import_cache_test.go quality per testify-expert criteria #30218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffb3539
Initial plan
Copilot May 4, 2026
14cc035
test: improve import_cache_test.go per testify-expert criteria
Copilot May 4, 2026
528a8c2
test: fold TestGetCacheDir nested-path case into TestImportCacheDirec…
Copilot May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions pkg/parser/import_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import (
)

func TestImportCache(t *testing.T) {
tempDir := t.TempDir()
cache := NewImportCache(tempDir)
const (
owner = "testowner"
repo = "testrepo"
Expand All @@ -23,19 +21,23 @@ func TestImportCache(t *testing.T) {
testContent := []byte("# Test Workflow\n\nTest content")

t.Run("Set creates file and returns path", func(t *testing.T) {
cache := NewImportCache(t.TempDir())
cachedPath, err := cache.Set(owner, repo, path, sha, testContent)
require.NoError(t, err, "Set should succeed for valid inputs")
require.FileExists(t, cachedPath, "cache file should be created at expected path")
})

t.Run("Get returns cached path after Set", func(t *testing.T) {
cachedPath, _ := cache.Set(owner, repo, path, sha, testContent)
cache := NewImportCache(t.TempDir())
cachedPath, err := cache.Set(owner, repo, path, sha, testContent)
require.NoError(t, err, "Set should succeed for valid inputs")
retrievedPath, found := cache.Get(owner, repo, path, sha)
assert.True(t, found, "cache entry should be found after Set")
assert.Equal(t, cachedPath, retrievedPath, "retrieved path should match path returned by Set")
})

t.Run("Cached file content matches original", func(t *testing.T) {
cache := NewImportCache(t.TempDir())
cachedPath, err := cache.Set(owner, repo, path, sha, testContent)
require.NoError(t, err, "Set should succeed")
content, err := os.ReadFile(cachedPath)
Expand All @@ -44,7 +46,10 @@ func TestImportCache(t *testing.T) {
})

t.Run("New cache instance finds existing entry", func(t *testing.T) {
cachedPath, _ := cache.Set(owner, repo, path, sha, testContent)
tempDir := t.TempDir()
cache := NewImportCache(tempDir)
cachedPath, err := cache.Set(owner, repo, path, sha, testContent)
require.NoError(t, err, "Set should succeed for valid inputs")
cache2 := NewImportCache(tempDir)
retrievedPath2, found := cache2.Get(owner, repo, path, sha)
assert.True(t, found, "cache entry should be found from new cache instance")
Expand All @@ -61,6 +66,14 @@ func TestImportCacheDirectory(t *testing.T) {
expectedDir := filepath.Join(tempDir, ImportCacheDir)
assert.Equal(t, expectedDir, cache.GetCacheDir(), "GetCacheDir should return expected path")

// GetCacheDir works for nested base directories that don't exist yet
t.Run("nested base dir returns correct path", func(t *testing.T) {
nestedBase := filepath.Join(t.TempDir(), "nested", "dir")
nestedCache := NewImportCache(nestedBase)
assert.Equal(t, filepath.Join(nestedBase, ImportCacheDir), nestedCache.GetCacheDir(),
"GetCacheDir should return base dir joined with ImportCacheDir for nested paths")
})

// Create a cache entry to trigger directory creation
testContent := []byte("test")
_, err := cache.Set("owner", "repo", "test.md", "sha1", testContent)
Expand Down Expand Up @@ -156,6 +169,16 @@ func TestSanitizePath(t *testing.T) {
input: "/absolute/path",
expected: "_absolute_path",
},
{
name: "dot-prefixed path cleaned",
input: "./file.md",
expected: "file.md",
},
{
name: "multiple consecutive slashes cleaned",
input: "a//b/file.md",
expected: "a_b_file.md",
},
}

for _, tt := range tests {
Expand Down