fix: remove duplicate repoConfigLog declaration breaking wasm build#30268
Merged
fix: remove duplicate repoConfigLog declaration breaking wasm build#30268
Conversation
…ilure Agent-Logs-Url: https://github.com/github/gh-aw/sessions/554c81f6-fe85-45c4-849d-56af6cfd7983 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 5, 2026 04:43
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the GOOS=js GOARCH=wasm build failure caused by a duplicate repoConfigLog declaration within the workflow package.
Changes:
- Removes the redundant
repoConfigLogdeclaration (and itsloggerimport) fromcompiler_repo_config.goso the package-level variable inrepo_config.gois used instead.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/compiler_repo_config.go | Removes duplicate logger variable/import to eliminate redeclared in this block compilation error for wasm builds. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
3
to
5
| // loadRepoConfig loads and caches repository-level configuration from aw.json. | ||
| func (c *Compiler) loadRepoConfig() (*RepoConfig, error) { | ||
| if c.repoConfigLoaded { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm build (
GOOS=js GOARCH=wasm) failed with aredeclared in this blockerror becauserepoConfigLogwas independently declared in bothrepo_config.goandcompiler_repo_config.gowithin the sameworkflowpackage.Changes
pkg/workflow/compiler_repo_config.go: Remove the duplicatevar repoConfigLogdeclaration and its now-unusedloggerimport — the variable fromrepo_config.gois already in scope across the package.