Skip to content

chore: remove dead parameters from findIncludesInContent and findPreviousSuccessfulWorkflowRuns#30311

Merged
pelikhan merged 2 commits intomainfrom
copilot/chore-remove-dead-parameters
May 5, 2026
Merged

chore: remove dead parameters from findIncludesInContent and findPreviousSuccessfulWorkflowRuns#30311
pelikhan merged 2 commits intomainfrom
copilot/chore-remove-dead-parameters

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 5, 2026

Two functions declared parameters they immediately discarded with _ =, forcing callers to compute and pass values with no effect.

Changes

  • findIncludesInContent (remove_command.go): removed baseDir string and verbose bool; updated both call sites and two test call sites in commands_utils_test.go
  • findPreviousSuccessfulWorkflowRuns (audit_comparison.go): removed verbose bool; updated the single call site
// Before
func findIncludesInContent(content, baseDir string, verbose bool) ([]string, error) {
    _ = baseDir
    _ = verbose
    ...
}
findIncludesInContent(string(content), filepath.Dir(mdFile), verbose)

// After
func findIncludesInContent(content string) ([]string, error) {
    ...
}
findIncludesInContent(string(content))

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name k (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw %H %ct %D (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw er_test ude_engine_test.user.name ude_engine_toolsTest User ache�� uypkflb2T ude_tools.go p/bin/sh ex_engine.go ex_engine_test.gremote r ortcfg (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name h ../../../.prettierignore cfg x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name h ../../../.prettierignore --jq /sh --show-toplevel ache/node/24.14.-atomic /usr/bin/git git rev-�� js/**/*.json' ---errorsas git /usr/bin/gh /ref/tags/v9 git sv gh (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 node sv licyMinIntegritygit ../../../**/*.jsrev-parse /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/xrev-parse /usr/bin/git -bool -buildtags ache/node/24.14./repos/actions/github-script/git/ref/tags/v9 git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv WorkflowFiles_TransitiveImports582095854/001 ache/go/1.25.8/xremote.origin.url /usr/bin/git 044918/b145/vet.gh /tmp/go-build774api 1/x64/lib/node_m/repos/actions/github-script/git/ref/tags/v9 git init�� (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv npx prettier --write '**/*.cjs' '**/*.ts' '**/*.-p x_amd64/vet 64/pkg/tool/linux_amd64/vet '**/*.ts' '**/*.git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel /opt/hostedtoolc--jq /usr/bin/git /tmp/go-build365git -trimpath ache/node/24.14.--show-toplevel git rev-�� --show-toplevel ache/node/24.14.1/x64/bin/node /usr/bin/git --show-toplevel -dwarf=false /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv k/_tool git /usr/bin/infocmp --show-toplevel 64/pkg/tool/linurev-parse /usr/bin/git infocmp -1 xterm-color git /home/REDACTED/.local/bin/node --show-toplevel 64/pkg/tool/linurev-parse /usr/bin/infocmp--show-toplevel node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv bility_SameInputSameOutput3650194421/001/stability-test.md -trimpath ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -p github.com/githu-1 -lang=go1.25 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv :latest x_amd64/vet /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile te '../../../**/git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /tmp/gh-aw-test-runs/20260505-083109-16903/test-3631506712 show r,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,disp--show-toplevel iant-412452100/.git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv /repos/actions/setup-node/git/ref/tags/v4 --jq /usr/bin/git /ref/tags/v9 64/pkg/tool/linurev-parse sv git rev-�� --show-toplevel git /usr/bin/git /tmp/gh-aw-test-git rev-parse /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv tformat cfg x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv rite '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pr**/*.json cfg x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build3654212531/b070/importcfg -pack /tmp/go-build3654212531/b070/_testmain.go /pre�� FETCH_HEAD cfg (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9.0.0
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv --local cfg de (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv --local ckout_step_generator.go x_amd64/vet ude_engine.go ude_engine_netwo-c ude_engine_test."prettier" --write 'scripts/**/*.js' --ignore-path .prettierignore --log-level=error UrXrkKd4vj1_ ache�� h ../../../.prettierignore cfg x_amd64/vet ex_engine.go ex_engine_test.g/home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/prettier r x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv -c=4 -nolocalimports -importcfg /tmp/go-build3654212531/b125/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/main.go /home/REDACTED/work/gh-aw/gh-aw/cmd/gh-aw/capitalization_test.go m/_n�� FETCH_HEAD cfg x_amd64/vet (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel sh /usr/bin/git 1224011898 x_amd64/vet e/git git rev-�� --show-toplevel e/git /usr/bin/git "prettier" --wrigit x_amd64/vet ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 64/pkg/tool/linu-test.v=true sv cfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel 4212531/b425/gitutil.test /usr/bin/infocmp t0 x_amd64/vet e/git infocmp -1 xterm-color e/git /usr/bin/git mplied x_amd64/vet 1/x64/bin/node git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 git bject.type] | @tsv ons-test38317654git rev-parse ow-without-react--show-toplevel git rev-�� /ref/tags/v9 git sv ub/gh-aw.git show 64/pkg/tool/linuxterm-color gh (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260505-083109-16903/test-1837519051 -trimpath (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /tmp/TestHashConsistency_GoAndJavaScript3767790655/001/test-empty-frontmatter.md x_amd64/vet /usr/bin/infocmp w/js/**/*.json' git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv .actor }}, Unsafe: ${{ secrets.TOKEN }} --jq /usr/bin/git json' --ignore-pgit 500812/b154/vet.rev-parse 64/pkg/tool/linu--show-toplevel git conf�� --get l (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv g_.a --jq /usr/bin/gh on' --ignore-patgit flow_test 64/pkg/tool/linu--show-toplevel gh api pICwVUK0A --jq e/git ub/workflows ../../../**/*.jsrev-parse x_amd64/vet ortcfg (http block)
  • https://api.github.com/repos/aws-actions/configure-aws-credentials/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git ithub-script/gitgit rev-parse ps git rev-�� --show-toplevel ps /usr/bin/gh git 64/pkg/tool/linuauth kflow.test gh (http block)
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/node/24.14.1/x64/bin/node /usr/bin/git uts.enforce_all gh rev-parse clusion,workflow/repos/actions/github-script/git/ref/tags/v9 git rev-�� /ref/tags/v9 git sv /ref/tags/v9 config sv gh (http block)
  • https://api.github.com/repos/azure/login/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/azure/login/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/node/24.14.1/x64/bin/node /usr/bin/git orce_all)' config /usr/bin/infocmp--show-toplevel git rev-�� --show-toplevel infocmp /usr/bin/infocmp xterm-color 64/pkg/tool/linu-1 /usr/bin/git infocmp (http block)
  • https://api.github.com/repos/docker/login-action/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/docker/login-action/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/node/24.14.1/x64/bin/node /usr/bin/git --show-toplevel -dwarf=false /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile /usr/bin/git /tmp/go-build365infocmp -trimpath /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linuremote.origin.url /usr/bin/git 1224011898 x_amd64/vet /bin/sh git rev-�� --show-toplevel /bin/sh /usr/bin/git FieldEnforcementinfocmp x_amd64/vet .cfg git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv --get remote.origin.url (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv /v1.0.0 (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-28 -ifaceassert -nilfunc ache/go/1.25.8/xtest@example.com 0449�� mLsRemoteWithRealGitcustom_branch2511947964/001' mLsRemoteWithRealGitcustom_branch2511947964/001' ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-05 (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-02-04 -ifaceassert -nilfunc ache/go/1.25.8/xremote.origin.url itbr�� -unreachable=false /tmp/go-build774500812/b284/vet.cfg n-dir/node re --log-level=egit (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name -tests son ignore (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 -buildtags es/.bin/node -errorsas -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linuorigin ache�� 2191255591 -tests .cfg json' --ignore-pgit (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name infocmp /usr/bin/git e:]]*"\([^"]*\)"gh nly /usr/bin/git git rev-�� --show-toplevel git e_modules/.bin/s--created nore git /usr/bin/gh git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 pkg/cli/commands_utils_test.go x_amd64/link ignore (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name gh n-dir/bash /repos/actions/ggit --jq /usr/bin/infocmpremove git rev-�� mpiledOutput1830293620/001 infocmp k/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/sh nore infocmp /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1234567890
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, (http block)
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, FETCH_HEAD cfg x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, --show-toplevel rk /usr/bin/git --show-toplevel git /usr/bin/gh git rev-�� js/**/*.json' --ignore-path ../../../.prettierignore gh /usr/bin/infocmp /repos/actions/ggit --jq /usr/bin/git infocmp (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 -tests util.test ignore (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name ache/node/24.14.1/x64/bin/npm 86_64/bash nly --jq /usr/bin/git git rev-�� mpiledOutput1830293620/001 git k/gh-aw/gh-aw/actions/setup/js/node_modules/.bin/sh nore /usr/bin/git /usr/bin/gh git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name -tests son ignore (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 -tests k/node_modules/.bin/node (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name gh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 -trimpath k/gh-aw/node_modules/.bin/node -p main -lang=go1.25 /opt/hostedtoolctest@example.com ache�� 2191255591/.github/workflows -dwarf=false /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu--quiet go1.25.8 -c=4 -nolocalimports erignore (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name gh bject.type] | @tsv /repos/actions/ginfocmp nly /usr/bin/git gh api edOutput456126512/001 --jq es/.bin/sh nore git /usr/bin/infocmpadd git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 -importcfg ger.test -s -w -buildmode=exe ger.test 6542�� 2191255591/.github/workflows -extld=gcc .cfg json' --ignore-pgit (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name gh /usr/bin/infocmp /repos/actions/g/usr/bin/git nly /usr/bin/git infocmp -1 edOutput456126512/001 git in/sh nore gh /usr/bin/git gh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 -test.timeout=10m0s in/node -test.run=TestFigit onpins cal/bin/git /opt/hostedtoolcache/go/1.25.8/x^remote\..*\.gh-resolved$ estl�� 3109-16903/test-source-field-variant-1985862891/.github/workflows (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name gh l_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, creat--show-toplevel /repos/actions/g/usr/bin/git nly /usr/bin/git gh api edOutput456126512/001 --jq ache/node/24.14.1/x64/lib/node_modules/npm/node_-nilfunc nore infocmp /usr/bin/git infocmp (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path h ../../../.prettierignore cfg x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 --ignore-path ../../../.pretti/repos/actions/github-script/git/ref/tags/v9 64/pkg/tool/linu--jq -c cfg (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 -ifaceassert -nilfunc 64/pkg/tool/linux_amd64/link -uns�� eutil.test -tests ortcfg.link (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build3654212531/b404/cli.test /tmp/go-build3654212531/b404/cli.test -test.testlogfile=/tmp/go-build3654212531/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true nore (http block)
    • Triggering command: /tmp/go-build2239560911/b404/cli.test /tmp/go-build2239560911/b404/cli.test -test.testlogfile=/tmp/go-build2239560911/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true --show-toplevel git /usr/bin/git git rev-�� ath ../../../.pr**/*.json git bject.type] | @t../../../.prettierignore --show-toplevel git /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel node (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv sRemoteWithRealGitmaster_branch1226389523/001 sRemoteWithRealGitmaster_branch1226389523/002/work g_.a (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv on' --ignore-pat--detach (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv json' --ignore-path ../../../.prettierignore git /usr/bin/git /ref/tags/v9 git sv git ules�� --show-toplevel git x_amd64/compile --show-toplevel 4212531/b473/scrrev-parse /usr/bin/git x_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv on' --ignore-pat--detach (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv on' --ignore-path ../../../.prettierignore 500812/b238/vet.cfg 64/pkg/tool/linux_amd64/vet .prettierignore --log-level=erro-C (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv cfg 500812/b242/vet.owner/repo 64/pkg/tool/linux_amd64/vet .prettierignore --log-level=erro-C (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv on' --ignore-path ../../../.prettierignore 500812/b228/vet.cfg 64/pkg/tool/linux_amd64/vet tierignore (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv /repos/actions/github-script/git--ignore-path --jq /usr/bin/git --show-toplevel git /usr/bin/git git ch_w�� -silent >/dev/nuremote.origin.url git x_amd64/vet --show-toplevel git /usr/bin/git x_amd64/vet (http block)
  • https://api.github.com/repos/google-github-actions/auth/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/google-github-actions/auth/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git /tmp/TestGuardPogit 4212531/b460/_terev-parse /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linuowner/test-repo /usr/bin/git -bool -buildtags /usr/bin/git git (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv 2092154110/001 (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion nore (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion xterm-color git /usr/bin/git git ache�� 2584994617 git ache/node/24.14.1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh --show-toplevel git ode-gyp-bin/node--show-toplevel git (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo /sh (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state /opt/hostedtoolcache/go/1.25.8/x-importcfg json' --ignore-pgit (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name h ../../../.prettierignore cfg x_amd64/vet --detach (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name h ../../../.prettierignore --jq /usr/bin/git --show-toplevel git /usr/bin/git git rev-�� --show-toplevel git /usr/bin/gh /ref/tags/v9 git sv gh (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch t789874806 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch /repos/actions/github-script/git--workflow --jq ache/uv/0.11.9/x86_64/sh xterm-color git /usr/bin/infocmp--show-toplevel infocmp -1 te 'scripts/**/*.js' --ignore-path .prettierignore --log-level=error infocmp k/gh-aw/gh-aw/node_modules/.bin/node /ref/tags/v9 git sv gh (http block)

If you need me to access, download, or install something from one of these locations, you can either:

…iousSuccessfulWorkflowRuns

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f6462f09-743f-4414-9c44-c339c66505c6

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove dead parameters from findIncludesInContent and findPreviousSuccessfulWorkflowRuns chore: remove dead parameters from findIncludesInContent and findPreviousSuccessfulWorkflowRuns May 5, 2026
Copilot AI requested a review from gh-aw-bot May 5, 2026 08:35
@pelikhan pelikhan marked this pull request as ready for review May 5, 2026 12:30
Copilot AI review requested due to automatic review settings May 5, 2026 12:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused parameters from two internal helper functions, eliminating unnecessary work for callers and simplifying the call sites.

Changes:

  • Removed baseDir and verbose parameters from findIncludesInContent, and updated its usages in remove_command.go plus related tests/benchmarks.
  • Removed the unused verbose parameter from findPreviousSuccessfulWorkflowRuns, and updated its single call site in audit_comparison.go.
Show a summary per file
File Description
pkg/cli/remove_command.go Simplifies include parsing by removing unused arguments from findIncludesInContent and updating include analysis call sites.
pkg/cli/commands_utils_test.go Updates tests/benchmark to match the new findIncludesInContent(content string) signature.
pkg/cli/audit_comparison.go Removes unused verbose parameter from findPreviousSuccessfulWorkflowRuns and updates its call site.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@pelikhan pelikhan merged commit 0755cc9 into main May 5, 2026
4 checks passed
@pelikhan pelikhan deleted the copilot/chore-remove-dead-parameters branch May 5, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove dead parameters from findIncludesInContent and findPreviousSuccessfulWorkflowRuns

4 participants