feat: add sandbox-mcp-container-removal codemod (#30370)#30364
Closed
feat: add sandbox-mcp-container-removal codemod (#30370)#30364
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/69af8a72-f90a-4d83-8ac7-3b55fd437e94 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 5, 2026 13:54
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is intended to add an automatic codemod for deprecated sandbox MCP frontmatter so workflows can be migrated away from strict-mode-invalid fields more easily.
Changes:
- Adds a changeset describing automatic removal of
sandbox.mcp.container. - Documents a migration path for affected workflows.
- Surfaces the strict-mode workaround guidance in release notes.
Show a summary per file
| File | Description |
|---|---|
.changeset/patch-add-sandbox-mcp-container-removal-codemod.md |
Adds the release-note entry and migration guidance for the new codemod. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
|
|
||
| **Migration guide:** | ||
| - Remove `sandbox.mcp.container` from your workflow frontmatter | ||
| - Run `gh aw fix` to migrate automatically |
Comment on lines
+5
to
+9
| Added the `sandbox-mcp-container-removal` codemod that automatically removes the deprecated `sandbox.mcp.container` field from workflow frontmatter. The MCP gateway container is now managed internally by gh-aw and cannot be configured by users in strict mode. | ||
|
|
||
| **Migration guide:** | ||
| - Remove `sandbox.mcp.container` from your workflow frontmatter | ||
| - Run `gh aw fix` to migrate automatically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
sandbox-mcp-container-removalcodemod so thatgh aw fix --writecan automatically remove the deprecatedsandbox.mcp.containerfield from workflow frontmatter.Problem
sandbox.mcp.containerwas previously user-configurable but is now an internal implementation detail managed by gh-aw. Workflows that set it explicitly fail in strict mode with:This affects 2/20 top-starred repos (126★ total), including
github/gh-aw-mcpg(125★) andExoshiva/gh-aw-firewall-AWF.Changes
pkg/cli/codemod_sandbox_mcp_internal.go: ImplementsgetSandboxMCPContainerRemovalCodemod()(andgetSandboxMCPVersionRemovalCodemod()) — removes thesandbox.mcp.containerkey and cleans up empty parent blocks (mcp:,sandbox:) when they become empty after removalpkg/cli/fix_codemods.go: Registers the codemod inGetAllCodemods()so it runs as part ofgh aw fix --writepkg/cli/codemod_sandbox_mcp_internal_test.go: Comprehensive unit tests covering removal, no-op cases,strict: falseskip, sibling key preservation, and empty-parent cleanup.changeset/patch-add-sandbox-mcp-container-removal-codemod.md: Changeset documenting the additionBehavior
The codemod:
sandbox.mcp.container, leaving all sibling keys intact (e.g.,sandbox.mcp.port)mcp:andsandbox:parent blocks after removalstrict: falsesetsandbox.mcp.containeris not present