Fix mapsloop lint violation in safe output app permission merge#30480
Merged
Fix mapsloop lint violation in safe output app permission merge#30480
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/498ac309-ad6b-469d-a0ad-72fd63a231e6 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 6, 2026 01:52
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a modernize/mapsloop lint failure by replacing a manual map merge loop with the standard library maps.Copy when applying github-app.permissions overrides during GitHub App token mint-step generation.
Changes:
- Added the
mapsstdlib import topkg/workflow/safe_outputs_app_config.go. - Replaced the manual
for k, v := range ... { ... }map merge withmaps.Copy(...)for permission field overrides.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/safe_outputs_app_config.go | Uses maps.Copy to merge app permission override fields into permissionFields, resolving the lint finding. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lint-gojob was failing onpkg/workflow/safe_outputs_app_config.godue to amodernize/mapsloopfinding. The failure came from manually copying entries from a temporary permission map intopermissionFields.What changed
for k, v := range ...merge withmaps.Copy(...)when applyinggithub-app.permissionsoverrides.mapsimport required for the merge.Why this area
permission-*inputs for GitHub App token minting.Code shape