Remove observability OTLP headers deprecation warning#30590
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0953bf0d-43ad-4fea-955a-123f21d03fc4 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
May 6, 2026 11:39
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecation signaling for the observability.otlp.headers string form, treating both string and map header formats as supported configuration styles.
Changes:
- Simplified OTLP header normalization to return only the normalized header string (no deprecation tracking).
- Simplified OTLP endpoint collection to stop propagating deprecated-state flags.
- Updated workflow tests and reference docs to reflect that both header forms are supported without warnings.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/observability_otlp.go | Removes deprecated-flag plumbing and the stderr deprecation warning; keeps header normalization and endpoint collection behavior. |
| pkg/workflow/observability_otlp_test.go | Updates tests to assert behavior without deprecation flags and keeps coverage for both string/map header forms. |
| pkg/workflow/frontmatter_types.go | Updates OTLP headers field comments to describe supported (not deprecated) forms. |
| pkg/parser/import_field_extractor.go | Updates comment to reflect that both header forms are supported/normalized (no deprecation detection). |
| docs/src/content/docs/reference/frontmatter.md | Removes “preferred/deprecated” wording and the warning note; documents both forms as supported. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 0
Collaborator
|
@copilot merge main and recompile |
…ability-otlp-deprecation # Conflicts: # pkg/workflow/observability_otlp.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecation signaling for
observability.otlp.headersstring form and keep both map and string forms as supported industry-standard configuration styles.Changes
observability.otlp.headersstring usage.Validation
make build && make fmtgo test -v -run "TestNormalizeOTLPHeaders|TestCollectAllOTLPEndpoints|TestInjectOTLPConfig" ./pkg/workflow/make agent-report-progresssecret_scanningon all changed files (no secrets found)parallel_validation(Code Review: no comments; CodeQL: no alerts, scan skipped due to DB size limit)