Conversation
…lateHealthSummary tests Add spec tests for two pure computation functions documented in pkg/cli/README.md that were missing from spec_test.go: CalculateWorkflowHealth (pure health computation for a single workflow) and CalculateHealthSummary (aggregate health computation). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pelikhan
deleted the
spec-enforce-actionpins-agentdrain-cli-2026-05-06-2f4ffa7c44a49cb6
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR updates specification-driven tests for the following packages:
actionpinsagentdraincliTest Derivation
All tests are derived from README.md specifications, not from implementation source code.
Changes
pkg/cli/spec_test.go: Added two new tests for pure computation functions documented in the README spec but absent from the existing spec file:TestSpec_PublicAPI_CalculateWorkflowHealth— validates the documented pure health computation: empty-run N/A display, success/failure counting, SuccessRate as percentage, BelowThresh flag against thresholdTestSpec_PublicAPI_CalculateHealthSummary— validates the documented aggregate computation: period preservation, TotalWorkflows count, HealthyWorkflows threshold filtering, BelowThreshold countSpec-Implementation Mismatches (pre-existing, no change)
GetActionPins() []ActionPinis documented in README but not implemented; existingSPEC_MISMATCHcomment retainedClusterCount()method referenced in README does not exist;len(Clusters())is the equivalent; existingSPEC_MISMATCHcomment retainedRound-Robin State
Auto-generated by Package Specification Enforcer workflow