Fix github-script v8 fallback pin and annotate resolved/source fallback versions#30909
Merged
Fix github-script v8 fallback pin and annotate resolved/source fallback versions#30909
Conversation
…ck version Agent-Logs-Url: https://github.com/github/gh-aw/sessions/593124ad-0049-4811-be65-7b8b43c403e8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/593124ad-0049-4811-be65-7b8b43c403e8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix actions/github-script@v8 pin to correct SHA
Fix github-script v8 fallback pin and annotate source vs resolved fallback versions
May 7, 2026
Collaborator
|
@copilot comment format shoildnbe |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect embedded fallback pin for actions/github-script@v8 (previously resolving to the v9 SHA) and updates pin formatting so lockfile comments preserve the requested/source version while also annotating the concrete fallback version used when they differ.
Changes:
- Add missing embedded pin entry for
actions/github-script@v8.0.0(correct SHA) and sync the pin datasets. - Change fallback pin formatting to append
(resolved: <concrete-tag>)when a non-exact fallback is used. - Update unit tests and wasm golden outputs to reflect the new fallback comment semantics.
Show a summary per file
| File | Description |
|---|---|
pkg/actionpins/actionpins.go |
Adds fallback formatting that annotates source vs resolved versions. |
pkg/workflow/action_pins_test.go |
Updates/extends tests for corrected v8 fallback and new comment format. |
pkg/workflow/data/action_pins.json |
Adds actions/github-script@v8.0.0 pin (correct SHA). |
pkg/actionpins/data/action_pins.json |
Syncs embedded pin dataset with the new v8.0.0 entry. |
.github/aw/actions-lock.json |
Syncs repo cache pin dataset with the new v8.0.0 entry. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden |
Updates golden output for new (resolved: ...) comment format. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden |
Updates golden output for new (resolved: ...) comment format. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.golden |
Updates golden output for new (resolved: ...) comment format. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden |
Updates golden output for new (resolved: ...) comment format. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 2
Comment on lines
+223
to
+228
| func formatPinnedActionWithResolution(repo, sha, sourceVersion, resolvedVersion string) string { | ||
| if sourceVersion == resolvedVersion || resolvedVersion == "" { | ||
| return FormatPinnedActionReference(repo, sha, sourceVersion) | ||
| } | ||
|
|
||
| return FormatPinnedActionReference(repo, sha, sourceVersion+" (resolved: "+resolvedVersion+")") |
Comment on lines
904
to
910
| { | ||
| name: "v7 falls back to v7.0.1 but comment shows v7", | ||
| repo: "actions/github-script", | ||
| requestedVer: "v7", | ||
| expectedComment: "# v7", | ||
| expectedSHA: "3a2844b7e9c422d3c10d287c895573f7108da1b3", | ||
| }, |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/bacd3686-5c71-42a4-8ae4-3971470c735d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/bacd3686-5c71-42a4-8ae4-3971470c735d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Updated to use the requested format in fallback comments: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Fix github-script v8 fallback pin and annotate source vs resolved fallback versions
Fix github-script v8 fallback pin and annotate resolved/source fallback versions
May 7, 2026
Collaborator
|
@copilot merge main and recompile |
…ript-v8-pin Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9215a6aa-2f20-4dac-8481-d2d5a397ae4c Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done. I merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh aw compilecould fall back to the wrong hardcoded SHA when dynamic tag resolution failed:actions/github-script@v8was effectively pinned to the v9 SHA. This also made fallback output ambiguous because lockfile comments did not clearly show both the resolved fallback version and the originally requested source version.Hardcoded pin data corrections
actions/github-script@v8.0.0entry with the correct SHA:ed597411d8f924073f98dfc5c65a23a2325f34cd.github/aw/actions-lock.jsonpkg/actionpins/data/action_pins.jsonpkg/workflow/data/action_pins.jsonFallback output semantics
# vRESOLVED (source vSOURCE)Tests and golden outputs
actions/github-script@v8resolves to the v8 SHABranch sync requested in review
origin/maininto this branch.> [!WARNING]
>
>