Skip to content

agentdrain: remove duplicate NewClusterCreated field from AnomalyReport#30938

Merged
pelikhan merged 4 commits intomainfrom
copilot/remove-duplicate-anomaly-report-field
May 8, 2026
Merged

agentdrain: remove duplicate NewClusterCreated field from AnomalyReport#30938
pelikhan merged 4 commits intomainfrom
copilot/remove-duplicate-anomaly-report-field

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

AnomalyReport had two fields (IsNewTemplate and NewClusterCreated) that were always assigned the same value and documented near-identically. NewClusterCreated was only set in one place and only read in tests; all production logic (buildReason, scoring, logging) used IsNewTemplate exclusively.

Changes

  • types.go: Remove NewClusterCreated bool from AnomalyReport; consolidate its doc comment into IsNewTemplate
  • anomaly.go: Drop NewClusterCreated: isNew from the struct literal in Analyze
  • anomaly_test.go: Remove wantNewCluster field from both TestAnomalyDetector_Analyze and TestAnalyzeEvent test tables, and the corresponding assertions against the now-removed field
  • spec_test.go: Remove _ = report.NewClusterCreated field access check and update spec comment
  • README.md: Remove NewClusterCreated from the AnomalyReport type table

Before:

type AnomalyReport struct {
    IsNewTemplate     bool    // Line created a new cluster
    NewClusterCreated bool    // This event produced a brand-new cluster  ← always == IsNewTemplate
    LowSimilarity     bool
    RareCluster       bool
    AnomalyScore      float64
    Reason            string
}

After:

type AnomalyReport struct {
    IsNewTemplate bool    // Line produced a brand-new log cluster
    LowSimilarity bool
    RareCluster   bool
    AnomalyScore  float64
    Reason        string
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name .cfg (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw er (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name get --local tions/setup/node-nilfunc credential.helpe/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/link /usr/bin/infocmp /test1.md /test2.lock.yml x_amd64/vet infocmp -1 xterm-color x_amd64/vet /usr/bin/git runs/20260508-05gh -trimpath 6544295/b458/_pk/repos/actions/github-script/git/ref/tags/v9 git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 ache/go/1.25.8/x64/pkg/tool/linu--format=%(objectname) sv source-field-vargh 5735760/b098/vetapi 64/pkg/tool/linu/repos/actions/github-script/git/ref/tags/v9 git conf�� --get remote.origin.url /usr/bin/infocmp LsRemoteWithRealgit LsRemoteWithRealrev-parse tartedAt,updated--show-toplevel infocmp (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv runs/20260508-052202-14447/test-source-field-variant-925316466 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv ithub-script/git/ref/tags/v9 git bject.type] | @tsv --show-toplevel ache/go/1.25.8/xrev-parse /usr/bin/git git rev-�� --show-toplevel git /opt/hostedtoolcache/node/24.14.1/x64/bin/node --show-toplevel node /usr/bin/gh node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv HIFr/iLX4908EimRzvG1AHIFr remote /usr/bin/gh go1.25.8 -c=4 -nolocalimports gh 6544�� list 6544295/b458/_testmain.go /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet get --local ode_modules/.bin--show-toplevel /opt/hostedtoolcache/go/1.25.8/x--jq (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv ere git /usr/bin/git */*.json' '!../.git --local _modules/.bin/no--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linu-buildtags /usr/bin/gh 01 .cfg ode_modules/.bin--show-toplevel gh (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv --show-toplevel resolved$ /usr/bin/git ./../pkg/workflogit .cfg x_amd64/vet git remo�� (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv xterm-color git /usr/bin/git user.email test@example.comapi /usr/bin/git git rev-�� --show-toplevel git /usr/bin/infocmp HEAD .github/workflowrev-parse (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv re --log-level=error (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv w/js/**/*.json' --ignore-path --global x_amd64/vet http.https://git/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9.0.0
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv h ../../../.pret.prettierignore r x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9.0.0 --jq [.object.sha, .object.type] | @tsv re --log-level=error 767db1660fabca49b x_amd64/vet (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv /repos/actions/github-script/git/ref/tags/v9 --jq /usr/bin/git 2202-14447/test-gh stmain.go 6544295/b345/vet/repos/actions/github-script/git/ref/tags/v9 git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git -bool -buildtags ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv user.name Test User /usr/bin/git lcs/common.go lcs/doc.go x_amd64/compile git rev-�� --git-dir resolved$ /usr/bin/git se 5735760/b028/vetrev-parse h git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel 6544295/b433/logger.test /usr/bin/infocmp 2050744716 --write .cfg infocmp -1 xterm-color e/git /usr/bin/git -bool -buildtags (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git /tmp/TestGuardPogit remote /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git mpleWorkflow2616infocmp remote.origin.ur-1 /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260508-052202-14447/test-1972837734 --jq /usr/bin/git re --log-level=egh 767db1660fabca49api x_amd64/vet /usr/bin/git remo�� -v x_amd64/vet /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link get --local es/.bin/sh /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /tmp/TestHashConsistency_GoAndJavaScript928504628/001/test-inlined-imports-enablremote.origin.urgit git /usr/bin/git rd --local on: .conclusion,--show-toplevel git conf�� user.email test@example.com /usr/bin/infocmp --local .cfg es/.bin/sh infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv --show-toplevel -goversion /usr/bin/git -c=4 -nolocalimports -importcfg git conf�� user.name Test User /usr/bin/git FETCH_HEAD^{commgit (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv steps.test.outputs.result (http block)
  • https://api.github.com/repos/aws-actions/configure-aws-credentials/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git ithub-script/gitgit remote bject.type] | @t--show-toplevel git rev-�� --show-toplevel git /usr/bin/git /tmp/gh-aw-test-gh remote /usr/bin/git git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/aws-actions/configure-aws-credentials/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel /opt/hostedtoolcache/go/1.25.8/x/tmp/gh-aw-merge-1640043941/new.md /usr/bin/git /tmp/go-build190gh s/12345/artifactapi /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git /tmp/gh-aw-test-git remote /opt/hostedtoolc--show-toplevel git (http block)
  • https://api.github.com/repos/azure/login/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/azure/login/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git /tmp/TestGuardPogit config repository(owne--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git -unreachable=falinfocmp /tmp/go-build190-1 /usr/bin/git git (http block)
  • https://api.github.com/repos/docker/login-action/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/docker/login-action/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git --show-toplevel git /opt/hostedtoolc--show-toplevel git rev-�� /ref/tags/v9 node sv thImports2734504infocmp 64/pkg/tool/linu-1 /usr/bin/git git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv /repos/actions/github-script/git/ref/tags/v9 --jq /usr/bin/gh 6544295/b433/loggh (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 remote.origin.url sv FETCH_HEAD (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-05-01 **/*.json --ignore-path 64/pkg/tool/linux_amd64/vet -c echo "��� JavaScript files formatted" (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-08 **/*.json --ignore-path x_amd64/compile /opt�� run .cfg 64/pkg/tool/linux_amd64/vet nore (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-02-07 **/*.json --ignore-path 64/pkg/tool/linuremote.origin.url /opt�� rdian.md format:pkg-json 64/pkg/tool/linux_amd64/vet nore (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 -trimpath .cfg -p github.com/stretinit erignore /opt/hostedtoolcache/go/1.25.8/xconfig -uns�� te '../../../**/*.json' '!../../remote.origin.url /tmp/go-build1215735760/b162/vet.cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1234567890
    • Triggering command: /usr/bin/gh gh api repos/{owner}/{repo}/actions/runs/1234567890 --jq {databaseId: .id, number: .run_number, url: .html_url, status: .status, conclusion: .conclusion, workflowName: .name, workflowPath: .path, createdAt: .created_at, startedAt: .run_started_at, updatedAt: .updated_at, event: .event, headBranch: .head_branch, /*.js' --ignore--errorsas --local 1/x64/bin/sh credential.usern/tmp/go-build1906544295/b396/actionpins.test (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 .cfg .cfg (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 /tmp/go-build1215735760/b017/vet.cfg 64/pkg/tool/linux_amd64/compile ignore-path ../.git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 /tmp/go-build1215735760/b018/vet.cfg 64/pkg/tool/linux_amd64/link ignore-path ../.git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name -run .cfg ./pkg/agentdraindocker (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 /tmp/go-build1215735760/b013/vet.cfg ortcfg.link ignore-path ../.git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 /tmp/go-build1215735760/b016/vet.cfg ortcfg.link ignore-path ../.git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path get --local ode_modules/.bin-nilfunc credential.helpe/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 ../../../.prettiremote (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build1906544295/b405/cli.test /tmp/go-build1906544295/b405/cli.test -test.testlogfile=/tmp/go-build1906544295/b405/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true HooksPath (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git --get remote.origin.ur-k mple.com/org/rep/tmp/gh-aw/aw-feature-branch.patch git rev-�� --show-toplevel git /usr/bin/gh (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv te '../../../**/*.json' '!../../remote.origin.url /tmp/go-build1215735760/b162/vet.cfg 64/pkg/tool/linux_amd64/vet -c=4 -nolocalimports -importcfg 64/pkg/tool/linux_amd64/vet -c echo "Syncing install-gh-aw.sh to actions/setup-cli/install.sh..-errorsas /home/REDACTED/go/pkg/mod/github.com/stretchr/testify@v1.11.1/asse-ifaceassert 64/pkg/tool/linux_amd64/link (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv fGO1rOfss .cfg x_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv cH3UKJwNI .cfg x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build1906544295/b478/importcfg -pack /tmp/go-build1906544295/b478/_testmain.go add ex-frontmatter-with-tools.md -v x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv te 'scripts/**/*.js' --ignore-pa-errorsas .cfg x_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv : .head_branch, .cfg x_amd64/vet (http block)
  • https://api.github.com/repos/google-github-actions/auth/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/google-github-actions/auth/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv --show-toplevel git /usr/bin/git --show-toplevel git /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/infocmp -unreachable=falgit /tmp/go-build190rev-parse /usr/bin/git infocmp (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv 984388092 /tmp/go-build1215735760/b156/vet.cfg .cfg (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo -nolocalimports -importcfg /tmp/go-build1906544295/b444/importcfg -pack /tmp/go-build1906544295/b444/_testmain.go conf�� json' --ignore-p-errorsas --local 64/pkg/tool/linu-nilfunc pull.rebase (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /../../.prettiergit erignore in/dist/gh-gpgsi--show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -c npx prettier --write '**/*.cjs' '**/*.ts' '**/*.json' --ignore-p-s (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name get --local 1/x64/lib/node_m-nilfunc credential.helpe/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch 2202-14447/test-2329281295/.github/workflows --write 64/pkg/tool/linux_amd64/link **/*.ts **/*.json --ignore-path 64/pkg/tool/linux_amd64/link run es.test --silent ortcfg.link tierignore (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI and others added 2 commits May 8, 2026 05:18
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/1921f014-04f5-4227-b56d-2af2e2b3a53d

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove duplicate field in AnomalyReport struct agentdrain: remove duplicate NewClusterCreated field from AnomalyReport May 8, 2026
Copilot AI requested a review from gh-aw-bot May 8, 2026 05:27
@pelikhan pelikhan marked this pull request as ready for review May 8, 2026 05:55
Copilot AI review requested due to automatic review settings May 8, 2026 05:55
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented May 8, 2026

@copilot merge main and recompile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a redundant AnomalyReport field (NewClusterCreated) that duplicated IsNewTemplate, and updates related tests/docs. The PR also refreshes many workflow lockfiles’ embedded firewall config model allowlists.

Changes:

  • Remove NewClusterCreated from pkg/agentdrain.AnomalyReport and stop populating it in Analyze.
  • Update agentdrain tests/spec/docs to reference only IsNewTemplate.
  • Update numerous .github/workflows/*lock.yml files to include additional gemini/* model patterns in the embedded firewall config JSON.
Show a summary per file
File Description
pkg/agentdrain/types.go Removes the redundant NewClusterCreated field and consolidates documentation onto IsNewTemplate.
pkg/agentdrain/anomaly.go Stops setting the removed NewClusterCreated field in the AnomalyReport literal.
pkg/agentdrain/anomaly_test.go Removes test-table expectations/assertions for NewClusterCreated.
pkg/agentdrain/spec_test.go Updates the spec assertion to match the updated AnomalyReport shape.
pkg/agentdrain/README.md Updates public docs to remove NewClusterCreated from the type listing.
.github/workflows/video-analyzer.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/test-workflow.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/test-project-url-default.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/test-dispatcher.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/super-linter.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/smoke-opencode.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/smoke-gemini.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/smoke-crush.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/smoke-ci.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/security-review.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/repo-tree-map.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/pr-nitpick-reviewer.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/pr-code-quality-reviewer.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/poem-bot.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/pdf-summary.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/notion-issue-summary.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/jsweep.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/issue-triage-agent.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/gpclean.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/github-remote-mcp-auth-test.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/example-permissions-warning.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/dev.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/dependabot-burner.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-team-status.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-skill-optimizer.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-semgrep-scan.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-regulatory.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-malicious-code-scan.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-cli-tools-tester.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/daily-architecture-diagram.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/copilot-token-audit.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/codex-github-remote-mcp-test.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/code-simplifier.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/brave.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/bot-detection.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).
.github/workflows/ace-editor.lock.yml Updates embedded firewall config model allowlist (adds gemini/* patterns).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 124/222 changed files
  • Comments generated: 1

Comment on lines 632 to +635
GH_AW_NODE_BIN=$(command -v node 2>/dev/null || true)
export GH_AW_NODE_BIN
(umask 177 && touch /tmp/gh-aw/agent-stdio.log)
printf '%s\n' '{"$schema":"https://github.com/github/gh-aw-firewall/releases/download/v0.25.41/awf-config.schema.json","network":{"allowDomains":["api.business.githubcopilot.com","api.enterprise.githubcopilot.com","api.github.com","api.githubcopilot.com","api.individual.githubcopilot.com","api.snapcraft.io","archive.ubuntu.com","azure.archive.ubuntu.com","crl.geotrust.com","crl.globalsign.com","crl.identrust.com","crl.sectigo.com","crl.thawte.com","crl.usertrust.com","crl.verisign.com","crl3.digicert.com","crl4.digicert.com","crls.ssl.com","github.com","host.docker.internal","json-schema.org","json.schemastore.org","keyserver.ubuntu.com","ocsp.digicert.com","ocsp.geotrust.com","ocsp.globalsign.com","ocsp.identrust.com","ocsp.sectigo.com","ocsp.ssl.com","ocsp.thawte.com","ocsp.usertrust.com","ocsp.verisign.com","packagecloud.io","packages.cloud.google.com","packages.microsoft.com","ppa.launchpad.net","raw.githubusercontent.com","registry.npmjs.org","s.symcb.com","s.symcd.com","security.ubuntu.com","telemetry.enterprise.githubcopilot.com","ts-crl.ws.symantec.com","ts-ocsp.ws.symantec.com","www.googleapis.com"]},"apiProxy":{"enabled":true,"models":{"auto":["large"],"deep-research":["copilot/deep-research*","copilot/o3-deep-research*","copilot/o4-mini-deep-research*","google/deep-research*","openai/o3-deep-research*","openai/o4-mini-deep-research*"],"gemini-flash":["copilot/gemini-*flash*","google/gemini-*flash*"],"gemini-pro":["copilot/gemini-*pro*","google/gemini-*pro*"],"gpt-4.1":["copilot/gpt-4.1*","openai/gpt-4.1*"],"gpt-5":["copilot/gpt-5*","openai/gpt-5*"],"gpt-5-codex":["copilot/gpt-5*codex*","openai/gpt-5*codex*"],"gpt-5-mini":["copilot/gpt-5*mini*","openai/gpt-5*mini*"],"gpt-5-nano":["copilot/gpt-5*nano*","openai/gpt-5*nano*"],"gpt-5-pro":["copilot/gpt-5*pro*","openai/gpt-5*pro*"],"haiku":["copilot/*haiku*","anthropic/*haiku*"],"large":["sonnet","gpt-5-pro","gpt-5","gemini-pro"],"mini":["haiku","gpt-5-mini","gpt-5-nano","gemini-flash"],"opus":["copilot/*opus*","anthropic/*opus*"],"reasoning":["copilot/o1*","copilot/o3*","copilot/o4*","openai/o1*","openai/o3*","openai/o4*"],"small":["mini"],"sonnet":["copilot/*sonnet*","anthropic/*sonnet*"]}},"container":{"imageTag":"0.25.41,squid=sha256:1260445d25968dbf3ae70143964177a0e5914cf2ce07a6117f7d3caec6c3e3c4,agent=sha256:cb2b565d070116d4b67e355775340528b5a2c3cb18b2c9049638bcc2df681770,api-proxy=sha256:fadd0de387209f69a9a7a1b8722bb5e7fdfb80ba9749a5c60f0e4cd7582a74d0,cli-proxy=sha256:62171f2fa508667b8b0a9e096f826983f312e3da0ce894f80c0f83a875af60fe"}}' > "${RUNNER_TEMP}/gh-aw/awf-config.json" && cp "${RUNNER_TEMP}/gh-aw/awf-config.json" /tmp/gh-aw/awf-config.json
printf '%s\n' '{"$schema":"https://github.com/github/gh-aw-firewall/releases/download/v0.25.41/awf-config.schema.json","network":{"allowDomains":["api.business.githubcopilot.com","api.enterprise.githubcopilot.com","api.github.com","api.githubcopilot.com","api.individual.githubcopilot.com","api.snapcraft.io","archive.ubuntu.com","azure.archive.ubuntu.com","crl.geotrust.com","crl.globalsign.com","crl.identrust.com","crl.sectigo.com","crl.thawte.com","crl.usertrust.com","crl.verisign.com","crl3.digicert.com","crl4.digicert.com","crls.ssl.com","github.com","host.docker.internal","json-schema.org","json.schemastore.org","keyserver.ubuntu.com","ocsp.digicert.com","ocsp.geotrust.com","ocsp.globalsign.com","ocsp.identrust.com","ocsp.sectigo.com","ocsp.ssl.com","ocsp.thawte.com","ocsp.usertrust.com","ocsp.verisign.com","packagecloud.io","packages.cloud.google.com","packages.microsoft.com","ppa.launchpad.net","raw.githubusercontent.com","registry.npmjs.org","s.symcb.com","s.symcd.com","security.ubuntu.com","telemetry.enterprise.githubcopilot.com","ts-crl.ws.symantec.com","ts-ocsp.ws.symantec.com","www.googleapis.com"]},"apiProxy":{"enabled":true,"models":{"auto":["large"],"deep-research":["copilot/deep-research*","copilot/o3-deep-research*","copilot/o4-mini-deep-research*","google/deep-research*","gemini/deep-research*","openai/o3-deep-research*","openai/o4-mini-deep-research*"],"gemini-flash":["copilot/gemini-*flash*","google/gemini-*flash*","gemini/gemini-*flash*"],"gemini-pro":["copilot/gemini-*pro*","google/gemini-*pro*","gemini/gemini-*pro*"],"gpt-4.1":["copilot/gpt-4.1*","openai/gpt-4.1*"],"gpt-5":["copilot/gpt-5*","openai/gpt-5*"],"gpt-5-codex":["copilot/gpt-5*codex*","openai/gpt-5*codex*"],"gpt-5-mini":["copilot/gpt-5*mini*","openai/gpt-5*mini*"],"gpt-5-nano":["copilot/gpt-5*nano*","openai/gpt-5*nano*"],"gpt-5-pro":["copilot/gpt-5*pro*","openai/gpt-5*pro*"],"haiku":["copilot/*haiku*","anthropic/*haiku*"],"large":["sonnet","gpt-5-pro","gpt-5","gemini-pro"],"mini":["haiku","gpt-5-mini","gpt-5-nano","gemini-flash"],"opus":["copilot/*opus*","anthropic/*opus*"],"reasoning":["copilot/o1*","copilot/o3*","copilot/o4*","openai/o1*","openai/o3*","openai/o4*"],"small":["mini"],"sonnet":["copilot/*sonnet*","anthropic/*sonnet*"]}},"container":{"imageTag":"0.25.41,squid=sha256:1260445d25968dbf3ae70143964177a0e5914cf2ce07a6117f7d3caec6c3e3c4,agent=sha256:cb2b565d070116d4b67e355775340528b5a2c3cb18b2c9049638bcc2df681770,api-proxy=sha256:fadd0de387209f69a9a7a1b8722bb5e7fdfb80ba9749a5c60f0e4cd7582a74d0,cli-proxy=sha256:62171f2fa508667b8b0a9e096f826983f312e3da0ce894f80c0f83a875af60fe"}}' > "${RUNNER_TEMP}/gh-aw/awf-config.json" && cp "${RUNNER_TEMP}/gh-aw/awf-config.json" /tmp/gh-aw/awf-config.json
…ate-anomaly-report-field

# Conflicts:
#	.github/workflows/daily-cache-strategy-analyzer.lock.yml
#	.github/workflows/daily-fact.lock.yml
#	.github/workflows/daily-observability-report.lock.yml
#	.github/workflows/duplicate-code-detector.lock.yml
#	.github/workflows/grumpy-reviewer.lock.yml
#	.github/workflows/issue-arborist.lock.yml
#	.github/workflows/schema-feature-coverage.lock.yml
#	.github/workflows/smoke-call-workflow.lock.yml
#	.github/workflows/smoke-codex.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 8, 2026

@copilot merge main and recompile

Done — merged main and recompiled in 335590b.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw jCaQU7U/MyloehxKapi (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv (http block)
  • https://api.github.com/repos/actions/download-artifact/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/download-artifact/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv (http block)
  • https://api.github.com/repos/docker/metadata-action/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/docker/metadata-action/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv (http block)
  • https://api.github.com/repos/docker/setup-buildx-action/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/docker/setup-buildx-action/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv cp .github/aw/actions-lock.json pkg/actionpins/data/action_pins.json; \ cp .github/aw/actions-lgit (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .default_branch (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from pelikhan May 8, 2026 06:01
@pelikhan pelikhan merged commit 4f64876 into main May 8, 2026
@pelikhan pelikhan deleted the copilot/remove-duplicate-anomaly-report-field branch May 8, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agentdrain: AnomalyReport.IsNewTemplate and NewClusterCreated are always set identically — remove the duplicate field

4 participants