Stop emitting unsupported apiProxy.maxEffectiveTokens in generated AWF config#31117
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Dependabot Burner workflow failure due to engine error
Stop emitting unsupported May 9, 2026
apiProxy.maxEffectiveTokens in generated AWF config
Contributor
There was a problem hiding this comment.
Pull request overview
Disables emitting the unsupported apiProxy.maxEffectiveTokens field when generating awf-config.json, to prevent AWF runtime config-load failures.
Changes:
- Removed
MaxEffectiveTokensassignment fromBuildAWFConfigJSON’sapiProxysection. - Updated unit tests to assert
maxEffectiveTokensis not present in generated config JSON. - Updated wasm compile golden fixtures to reflect the new generated config output (without
maxEffectiveTokens).
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/awf_config.go |
Stops including apiProxy.maxEffectiveTokens in generated AWF config JSON. |
pkg/workflow/awf_config_test.go |
Updates expectations to ensure maxEffectiveTokens is absent, including when configured. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden |
Updates expected generated workflow output to remove maxEffectiveTokens from embedded AWF config JSON. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden |
Same golden update: remove maxEffectiveTokens. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.golden |
Same golden update: remove maxEffectiveTokens. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden |
Same golden update: remove maxEffectiveTokens. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
Comment on lines
246
to
250
| // ── API proxy section ───────────────────────────────────────────────────── | ||
| maxEffectiveTokens := constants.DefaultMaxEffectiveTokens | ||
| if config.WorkflowData != nil && config.WorkflowData.EngineConfig != nil { | ||
| maxEffectiveTokens = config.WorkflowData.EngineConfig.GetMaxEffectiveTokens() | ||
| } | ||
| apiProxy := &AWFAPIProxyConfig{ | ||
| Enabled: true, | ||
| MaxEffectiveTokens: maxEffectiveTokens, | ||
| Enabled: true, | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Dependabot Burner on
mainfailed because the generatedawf-config.jsonincludedconfig.apiProxy.maxEffectiveTokens, which the current AWF runtime rejects as unsupported. Per issue guidance, this change disables writing that field until the feature is live.What was the bug?
BuildAWFConfigJSONalways serializedapiProxy.maxEffectiveTokens(default or configured override).config.apiProxy.maxEffectiveTokens is not supported.How did you fix it?
MaxEffectiveTokensassignment from AWF config generation inpkg/workflow/awf_config.go.pkg/workflow/awf_config_test.goto assert the field is absent.maxEffectiveTokens.Example change