Format effective token values in rendered failure messages

[Copilot]

Bug Fix

Rendered message paths still showed raw effective-token integers in ET budget failure context. This change aligns those displays with footer formatting so token values are compact and human-friendly (e.g., 10000000 → 10M).

• What was the bug?

  • ET budget exhaustion messaging rendered effectiveTokens / maxEffectiveTokens as raw strings in user-facing text, while footer paths already used compact formatting.

• How did you fix it?

  • Reused the existing footer formatter (formatET from effective_tokens.cjs) in buildEffectiveTokensRateLimitErrorContext.
  • Formatted both:
    • Effective tokens used
    • Configured ET budget
  • Kept safe fallback behavior: if a value is non-numeric, render it unchanged.
  • Exported the helper for direct unit-level coverage.

• Example

const parsed = Number.parseInt(value || "", 10);
const display = Number.isInteger(parsed) && parsed > 0 ? formatET(parsed) : value;
// "10000000" -> "10M"

• Testing

  • Added targeted tests for compact formatting, non-numeric fallback behavior, and omission of optional lines when values are missing.
  • Merged latest main and recompiled generated workflow artifacts (.github/workflows/approach-validator.lock.yml) per follow-up feedback.

[Copilot]

Pull request overview

Fixes user-facing ET budget exhaustion messaging by rendering effectiveTokens / maxEffectiveTokens in the same compact, human-friendly format already used in footers (e.g., 10000000 → 10M).

Changes:

• Reuses formatET to compact-format effective token values in buildEffectiveTokensRateLimitErrorContext.
• Exports buildEffectiveTokensRateLimitErrorContext for direct unit testing.
• Adds unit tests for compact formatting, fallback behavior, and omission of optional lines; also updates necromancer.lock.yml.

Show a summary per file

File	Description
actions/setup/js/handle_agent_failure.cjs	Formats ET values in the rate-limit failure context using formatET and exports the helper.
actions/setup/js/handle_agent_failure.test.cjs	Adds targeted unit tests for the ET rate-limit context rendering.
.github/workflows/necromancer.lock.yml	Updates generated lock workflow content (includes AWF/container version bumps and related config changes).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 2

[pelikhan]

@copilot Merge main and recompile

[Copilot]

@copilot Merge main and recompile

Done. I merged main (b5403eb) and recompiled the workflows (ab892ca).