[jsweep] Clean missing_messages_helper.cjs#31161
Merged
pelikhan merged 2 commits intoMay 9, 2026
Merged
Conversation
…and tests - Add `// @ts-check` to enable type checking (was the only .cjs file without it) - Existing JSDoc type annotations are sufficient; no type errors introduced - Add 5 new test cases covering noopMessages, reportIncomplete, combined fields, and state mutation scenarios; test count: 7 → 12 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
✅ Necromancer fortified this PR with fresh regression coverage. |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables TypeScript checking (// @ts-check) for missing_messages_helper.cjs and expands the Vitest coverage for getMissingInfoSections() to include noop and report-incomplete scenarios.
Changes:
- Added
// @ts-checktoactions/setup/js/missing_messages_helper.cjs. - Added new Vitest cases for
noopMessages,reportIncomplete, combined fields, and state updates inactions/setup/js/missing_messages_helper.test.cjs.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/missing_messages_helper.cjs | Enables @ts-check, making the file’s JSDoc types part of the effective API contract. |
| actions/setup/js/missing_messages_helper.test.cjs | Adds additional tests for noop/incomplete and repeated updates to collected missings. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
actions/setup/js/missing_messages_helper.test.cjs:172
- These
setCollectedMissingscalls use a partialmissingsshape (nonoopMessages/reportIncomplete). In production the missings object includes those arrays (possibly empty), so consider passing them here as well to better reflect real usage and guard against regressions in the formatter’s handling of empty arrays.
setCollectedMissings({ missingTools: [{ tool: "npm", reason: "Build tool" }], missingData: [] });
const first = getMissingInfoSections();
expect(first).toContain("npm");
setCollectedMissings({ missingTools: [], missingData: [] });
const second = getMissingInfoSections();
- Files reviewed: 2/2 changed files
- Comments generated: 4
Comment on lines
+136
to
+140
| const missings = { | ||
| missingTools: [], | ||
| missingData: [], | ||
| reportIncomplete: [{ reason: "Task not finished" }], | ||
| }; |
| const result = getMissingInfoSections(); | ||
|
|
||
| expect(result).toContain("docker"); | ||
| expect(result).toContain("token"); |
Comment on lines
+119
to
+125
| it("should handle noopMessages", () => { | ||
| const { setCollectedMissings, getMissingInfoSections } = helper; | ||
| const missings = { | ||
| missingTools: [], | ||
| missingData: [], | ||
| noopMessages: [{ message: "No action needed" }], | ||
| reportIncomplete: [], |
| @@ -1,3 +1,4 @@ | |||
| // @ts-check | |||
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 3.4M
Contributor
Author
🧪 Test Quality Sentinel ReportTest Quality Score: 85/100✅ Excellent test quality
Test Classification DetailsView all 12 test classifications
Flagged Tests — Requires Review
|
Contributor
Author
|
Commit pushed:
|
Contributor
Author
|
Necromancer regression pass complete.
|
pelikhan
deleted the
jsweep/missing-messages-helper-ts-check-3d1cd2b463c6a730
branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables
@ts-checkinmissing_messages_helper.cjs— the only.cjssource file inactions/setup/js/that was missing it — and expands its test suite.Changes
missing_messages_helper.cjs//@ts-check`` as the first line to enable TypeScript type checkingmissing_messages_helper.test.cjsshould handle noopMessages— verifiesnoopMessagesarray is forwarded to formattershould handle reportIncomplete messages— verifiesreportIncompletearray is forwardedshould handle all fields simultaneously— exercises all four fields at onceshould reflect updates after setCollectedMissings is called again— state mutation checkValidation
All checks passed:
npx prettier✓ (unchanged)npm run lint:cjs✓npm run typecheck✓ (0 errors after adding@ts-check)