Align ET budget failure diagnostics with firewall-compiled ET totals

[Copilot]

Bug Fix

What was the bug?

Q was reported as ET-budget exhausted (12.2M / 10M) even when firewall-compiled ET state showed usage below budget. The failure path used recomputed ET from token usage/env and could drift from firewall ET compilation, producing false budget-exhaustion diagnostics.

How did you fix it?

• ET source precedence aligned to firewall state
  • Updated resolveEffectiveTokensFailureState() to resolve ET values in this order:
    1. audit log ET fields
    2. firewall reflect ET fields (sandbox/firewall/awf-reflect.json)
    3. env fallbacks
• Reflect-file ET parsing added
  • Added parsing of:
    • effective_tokens.total_effective_tokens
    • effective_tokens.max_effective_tokens
  • Normalized parsed values to positive integer strings for consistent comparison logic.
• Regression coverage for mismatch scenario
  • Added a focused test that reproduces the mismatch case (high env ET + lower firewall ET total) and verifies ET budget exhaustion is suppressed when firewall totals are below max.

const effectiveTokens =
  audit.effectiveTokens ||
  reflect.effectiveTokens ||
  envEffectiveTokens ||
  "";

const maxEffectiveTokens =
  parseMaxEffectiveTokensFromAuditLog() ||
  reflect.maxEffectiveTokens ||
  envMaxEffectiveTokens ||
  "";

[Copilot]

Pull request overview

Fixes misleading “ET budget exhausted” diagnostics by aligning effective-token totals used in the failure path with the AWF firewall-compiled ET state (via awf-reflect.json) rather than potentially-drifting env-derived recomputation.

Changes:

• Add parsing of effective_tokens.total_effective_tokens and effective_tokens.max_effective_tokens from the firewall reflect file and use it as a fallback source between audit log values and env fallbacks.
• Update ET failure-state resolution precedence to prefer audit log → reflect file → env.
• Add a regression test covering the “high env ET, lower firewall reflect ET” mismatch scenario.

Show a summary per file

File	Description
actions/setup/js/effective_tokens_context.cjs	Adds reflect-file parsing and updates ET source precedence in resolveEffectiveTokensFailureState().
actions/setup/js/handle_agent_failure.test.cjs	Adds regression coverage ensuring firewall reflect ET totals suppress false budget-exhaustion signals.
.github/workflows/daily-news.lock.yml	Regenerates the Daily News lock workflow with multiple version/step/env updates.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 2