Skip to content

Reduce compile output noise from container image validation#31232

Merged
pelikhan merged 1 commit into
mainfrom
copilot/reduce-container-validation-verbosity
May 9, 2026
Merged

Reduce compile output noise from container image validation#31232
pelikhan merged 1 commit into
mainfrom
copilot/reduce-container-validation-verbosity

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 9, 2026

✨ Enhancement

Repeated per-workflow container validation success lines were cluttering compile output and obscuring higher-signal messages (e.g., warnings). This update reduces that noise while preserving existing container image validation behavior.

  • What does this improve?
    Compile output no longer emits ℹ ✓ Container image validated: ... for each validated tool image, making workflow-level results and warnings easier to scan.

  • Why is this valuable?
    The previous output duplicated low-value success information across many workflows, increasing log volume without adding actionable signal.

  • Implementation approach:
    Removed the verbose success print in validateContainerImages (pkg/workflow/runtime_validation.go) while leaving validation execution, error collection, and warning/error paths unchanged.

if err := validateDockerImage(containerImage, c.verbose, c.requireDocker); err != nil {
    errors = append(errors, fmt.Sprintf("tool '%s': %v", toolName, err))
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Reduce container image validation verbosity Reduce compile output noise from container image validation May 9, 2026
Copilot AI requested a review from pelikhan May 9, 2026 16:05
@pelikhan pelikhan marked this pull request as ready for review May 9, 2026 16:08
Copilot AI review requested due to automatic review settings May 9, 2026 16:08
@pelikhan pelikhan merged commit 0fc32e8 into main May 9, 2026
2 checks passed
@pelikhan pelikhan deleted the copilot/reduce-container-validation-verbosity branch May 9, 2026 16:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces compile-time log noise by removing per-tool “container image validated” success messages while keeping container image validation logic and error reporting unchanged.

Changes:

  • Removed verbose per-image success output from validateContainerImages.
  • Kept the existing docker validation execution and error aggregation behavior intact.
Show a summary per file
File Description
pkg/workflow/runtime_validation.go Removes verbose per-image success printing during container image validation to reduce compile output clutter.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

@@ -214,8 +214,6 @@ func (c *Compiler) validateContainerImages(workflowData *WorkflowData) error {
// Validate the container image exists using docker
if err := validateDockerImage(containerImage, c.verbose, c.requireDocker); err != nil {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants