Skip to content

Enable inline sub-agents by default; deprecate features.inline-agents; reject inline-sub-agents: false#31235

Merged
pelikhan merged 2 commits into
mainfrom
copilot/enable-inline-sub-agents-default
May 9, 2026
Merged

Enable inline sub-agents by default; deprecate features.inline-agents; reject inline-sub-agents: false#31235
pelikhan merged 2 commits into
mainfrom
copilot/enable-inline-sub-agents-default

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 9, 2026

✨ Enhancement

Inline sub-agents now run as default behavior instead of an opt-in feature flag. This change deprecates the legacy features.inline-agents switch and makes explicit disablement via inline-sub-agents: false a compile-time error.

  • Default behavior shift

    • Inline sub-agent extraction/restore now assumes always-enabled behavior.
    • Removed experimental warning semantics tied to inline sub-agents.
  • Deprecation + migration

    • features.inline-agents remains accepted as deprecated/no-op for compatibility.
    • Updated codemod metadata to support future cleanup of deprecated flag usage (IntroducedIn: 1.0.0).
  • Top-level frontmatter enforcement

    • Added typed/frontmatter support for top-level inline-sub-agents.
    • If inline-sub-agents: false is present, compilation now fails with a clear error.
  • Spec/docs alignment

    • Extended schema to document inline-sub-agents deprecation semantics.
    • Updated docs to reflect:
      • inline sub-agents are default-on,
      • features.inline-agents is deprecated,
      • inline-sub-agents: false is invalid.
---
engine: copilot
inline-sub-agents: false
features:
  inline-agents: true # deprecated/no-op
---

# compile error:
# inline-sub-agents: false is not supported. Inline sub-agents are always enabled.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Enable inline sub-agents by default and deprecate inline-agents feature flag Enable inline sub-agents by default; deprecate features.inline-agents; reject inline-sub-agents: false May 9, 2026
Copilot AI requested a review from pelikhan May 9, 2026 16:19
Comment thread pkg/cli/codemod_inline_agents.go Outdated
@@ -10,7 +10,7 @@ func getInlineAgentsFeatureRemovalCodemod() Codemod {
ID: "features-inline-agents-removal",
Name: "Remove deprecated features.inline-agents",
Description: "Removes deprecated features.inline-agents. Inline sub-agents are now enabled by default.",
IntroducedIn: "1.0.0",
IntroducedIn: "1.1.0",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot what is this version number?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IntroducedIn is the codemod metadata version (when this codemod was introduced). It should be 1.0.0 here, and I fixed it in a01130d.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan May 9, 2026 16:26
@pelikhan pelikhan marked this pull request as ready for review May 9, 2026 16:29
Copilot AI review requested due to automatic review settings May 9, 2026 16:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Shifts inline sub-agent handling to be default-on, deprecates the legacy features.inline-agents toggle as a no-op, and makes inline-sub-agents: false a hard compile-time error while updating schema/docs/tests accordingly.

Changes:

  • Add typed + raw-frontmatter plumbing for top-level inline-sub-agents, and fail compilation when it is explicitly set to false.
  • Remove “experimental feature” warning semantics for inline sub-agents and improve logging.
  • Update schema, codemod metadata test, and docs to reflect the new default-on + deprecation behavior.
Show a summary per file
File Description
pkg/workflow/workflow_builder.go Reads inline-sub-agents from parsed or raw frontmatter and stores the disable intent in WorkflowData.
pkg/workflow/frontmatter_types.go Adds InlineSubAgents *bool to typed frontmatter config with deprecation guidance.
pkg/workflow/frontmatter_types_test.go Adds coverage for parsing inline-sub-agents as a boolean into typed config.
pkg/workflow/frontmatter_serialization.go Ensures inline-sub-agents round-trips via FrontmatterConfig.ToMap() when explicitly present.
pkg/workflow/compiler_validators.go Enforces compile-time error when inline-sub-agents: false is set.
pkg/workflow/compiler_validators_test.go Adds validator test ensuring the new compile-time error is produced.
pkg/workflow/compiler_types.go Introduces InlineSubAgentsDisabled field on WorkflowData to carry the validation signal.
pkg/workflow/compiler_orchestrator_tools.go Removes experimental warning emission; logs extracted inline sub-agent count instead.
pkg/parser/schemas/main_workflow_schema.json Documents inline-sub-agents as deprecated and notes that false triggers a compile error.
pkg/cli/codemod_inline_agents_test.go Asserts codemod IntroducedIn metadata is set (for future cleanup workflows).
docs/src/content/docs/reference/inline-sub-agents.md Updates reference to reflect default-on behavior and deprecation/error semantics.
docs/src/content/docs/patterns/data-ops.md Removes obsolete “enable via features.inline-agents” guidance; clarifies default-on and tool requirement.
.github/aw/subagents.md Removes experimental-warning documentation and documents compile failure for inline-sub-agents: false.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 13/13 changed files
  • Comments generated: 0

@pelikhan pelikhan merged commit 470aa5a into main May 9, 2026
4 checks passed
@pelikhan pelikhan deleted the copilot/enable-inline-sub-agents-default branch May 9, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants