Enable inline sub-agents by default; deprecate features.inline-agents; reject inline-sub-agents: false#31235
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Enable inline sub-agents by default and deprecate inline-agents feature flag
Enable inline sub-agents by default; deprecate May 9, 2026
features.inline-agents; reject inline-sub-agents: false
pelikhan
reviewed
May 9, 2026
| @@ -10,7 +10,7 @@ func getInlineAgentsFeatureRemovalCodemod() Codemod { | |||
| ID: "features-inline-agents-removal", | |||
| Name: "Remove deprecated features.inline-agents", | |||
| Description: "Removes deprecated features.inline-agents. Inline sub-agents are now enabled by default.", | |||
| IntroducedIn: "1.0.0", | |||
| IntroducedIn: "1.1.0", | |||
Contributor
Author
There was a problem hiding this comment.
IntroducedIn is the codemod metadata version (when this codemod was introduced). It should be 1.0.0 here, and I fixed it in a01130d.
Copilot created this pull request from a session on behalf of
pelikhan
May 9, 2026 16:21
View session
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Shifts inline sub-agent handling to be default-on, deprecates the legacy features.inline-agents toggle as a no-op, and makes inline-sub-agents: false a hard compile-time error while updating schema/docs/tests accordingly.
Changes:
- Add typed + raw-frontmatter plumbing for top-level
inline-sub-agents, and fail compilation when it is explicitly set tofalse. - Remove “experimental feature” warning semantics for inline sub-agents and improve logging.
- Update schema, codemod metadata test, and docs to reflect the new default-on + deprecation behavior.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/workflow_builder.go | Reads inline-sub-agents from parsed or raw frontmatter and stores the disable intent in WorkflowData. |
| pkg/workflow/frontmatter_types.go | Adds InlineSubAgents *bool to typed frontmatter config with deprecation guidance. |
| pkg/workflow/frontmatter_types_test.go | Adds coverage for parsing inline-sub-agents as a boolean into typed config. |
| pkg/workflow/frontmatter_serialization.go | Ensures inline-sub-agents round-trips via FrontmatterConfig.ToMap() when explicitly present. |
| pkg/workflow/compiler_validators.go | Enforces compile-time error when inline-sub-agents: false is set. |
| pkg/workflow/compiler_validators_test.go | Adds validator test ensuring the new compile-time error is produced. |
| pkg/workflow/compiler_types.go | Introduces InlineSubAgentsDisabled field on WorkflowData to carry the validation signal. |
| pkg/workflow/compiler_orchestrator_tools.go | Removes experimental warning emission; logs extracted inline sub-agent count instead. |
| pkg/parser/schemas/main_workflow_schema.json | Documents inline-sub-agents as deprecated and notes that false triggers a compile error. |
| pkg/cli/codemod_inline_agents_test.go | Asserts codemod IntroducedIn metadata is set (for future cleanup workflows). |
| docs/src/content/docs/reference/inline-sub-agents.md | Updates reference to reflect default-on behavior and deprecation/error semantics. |
| docs/src/content/docs/patterns/data-ops.md | Removes obsolete “enable via features.inline-agents” guidance; clarifies default-on and tool requirement. |
| .github/aw/subagents.md | Removes experimental-warning documentation and documents compile failure for inline-sub-agents: false. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 13/13 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Enhancement
Inline sub-agents now run as default behavior instead of an opt-in feature flag. This change deprecates the legacy
features.inline-agentsswitch and makes explicit disablement viainline-sub-agents: falsea compile-time error.Default behavior shift
Deprecation + migration
features.inline-agentsremains accepted as deprecated/no-op for compatibility.IntroducedIn: 1.0.0).Top-level frontmatter enforcement
inline-sub-agents.inline-sub-agents: falseis present, compilation now fails with a clear error.Spec/docs alignment
inline-sub-agentsdeprecation semantics.features.inline-agentsis deprecated,inline-sub-agents: falseis invalid.