fix: combine date bounds into a single --created range expression

[Copilot]

Bug Fix

What was the bug?

gh run list treats --created as a StringVarP (single string), so passing it multiple times only keeps the last value. listWorkflowRunsWithPagination was appending one flag per bound:

# What was being constructed — only <=END is applied; >=START is silently dropped
gh run list ... --created ">=START" --created "<=END"

# With pagination — only <BEFORE_DATE survives; StartDate is completely ignored
gh run list ... --created ">=START" --created "<=END" --created "<BEFORE_DATE"

This meant --start-date was never enforced, allowing runs from arbitrarily early dates to be returned.

How did you fix it?

Added buildCreatedFilter(startDate, endDate, beforeDate string) string that collapses all bounds into a single --created value using GitHub's range syntax:

Inputs	Output
startDate + endDate	start..end
startDate + beforeDate (pagination)	start..(beforeDate − 1s)
startDate only	>=start
endDate only	<=end
beforeDate only	<beforeDate

BeforeDate is an exclusive pagination cursor; one second is subtracted before using it as the inclusive upper bound in range syntax, preventing the boundary run from reappearing on the next page.

// Before: three separate --created flags, only the last survives
if opts.StartDate != "" {
    args = append(args, "--created", ">="+opts.StartDate)
}
if opts.EndDate != "" {
    args = append(args, "--created", "<="+opts.EndDate)
}
if opts.BeforeDate != "" {
    args = append(args, "--created", "<"+opts.BeforeDate)
}

// After: single expression, all bounds enforced
if createdFilter := buildCreatedFilter(opts.StartDate, opts.EndDate, opts.BeforeDate); createdFilter != "" {
    args = append(args, "--created", createdFilter)
}

Testing

Unit tests added in logs_github_api_test.go covering all bound combinations, including a dedicated regression test (TestBuildCreatedFilterStartDateAlwaysEnforced) that asserts the lower bound is always present in the emitted filter string.

[Copilot]

Pull request overview

Fixes gh run list date filtering by ensuring all provided date bounds are applied via a single --created flag value (since the upstream flag only retains the last occurrence), including pagination support via an exclusive BeforeDate cursor.

Changes:

• Added buildCreatedFilter(startDate, endDate, beforeDate string) string to collapse multiple date bounds into one GitHub-compatible range expression.
• Updated listWorkflowRunsWithPagination to emit exactly one --created argument built from all applicable bounds.
• Added unit tests covering all bound combinations and a regression test to ensure StartDate is never dropped.

Show a summary per file

File	Description
pkg/cli/logs_github_api.go	Introduces buildCreatedFilter and switches gh run list arg construction to use a single combined --created expression.
pkg/cli/logs_github_api_test.go	Adds unit tests for buildCreatedFilter, including regression coverage for the original “StartDate silently dropped” bug.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0