Add compile-cli-workflows target and CI job for pkg/cli/workflows#31521
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Add CLI workflows compile make target and CI job
Add May 11, 2026
compile-cli-workflows target and CI job for pkg/cli/workflows
Copilot created this pull request from a session on behalf of
pelikhan
May 11, 2026 15:53
View session
pelikhan
reviewed
May 11, 2026
| if: ${{ needs.changes.outputs.has_changes == 'true' }} | ||
| needs: | ||
| - changes | ||
| runs-on: ubuntu-latest |
Collaborator
There was a problem hiding this comment.
@copilot Download the cache containing the built compiler for use in this job.
Contributor
Author
There was a problem hiding this comment.
Addressed in 6e142e6. The compile-cli-workflows job now depends on update, downloads the gh-aw-linux-amd64 artifact, marks it executable, and uses it for compilation instead of rebuilding in that job.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
May 11, 2026 16:14
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated Makefile target and CI job to ensure the workflow fixtures under pkg/cli/workflows are compiled during CI runs, reusing a prebuilt gh-aw binary artifact from the existing update job.
Changes:
- Add
compile-cli-workflowsMakefile target that compiles workflows from a temporary copied directory to avoid mutating tracked fixtures. - Add
compile-cli-workflowsCI job inci.ymlthat downloads the prebuiltgh-aw-linux-amd64artifact and runs the new Makefile target. - Expose the new target via
make help.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds compile-cli-workflows target (and help entry) intended to compile pkg/cli/workflows fixtures using a temporary workspace copy. |
| .github/workflows/ci.yml | Adds a new job that downloads the gh-aw artifact from update and runs make compile-cli-workflows to enforce fixture compilation in CI. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+711
to
+716
| WORKFLOWS=$$(find "$$TMP_WORKFLOWS_DIR/workflows" -maxdepth 1 -type f -name '*.lock.yml' | sed 's/\.lock\.yml$$/.md/' | sort | tr '\n' ' '); \ | ||
| if [ -z "$$WORKFLOWS" ]; then \ | ||
| echo "No workflow files found in pkg/cli/workflows"; \ | ||
| exit 1; \ | ||
| fi; \ | ||
| ./$(BINARY_NAME) compile --fix --no-check-update $$WORKFLOWS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Feature
pkg/cli/workflowscompilation was not enforced by a dedicated CI path. This change adds an explicit Makefile target and a CI job so these workflows are compiled on every run.What does this feature do?
compile-cli-workflowsto compile workflow fixtures frompkg/cli/workflows.gh-awonly if the binary is missing, so prebuilt binaries can be reused in CI.ci.ymlcompile-cli-workflowsjob.gh-aw-linux-amd64artifact from theupdatejob and uses it for compilation.make compile-cli-workflowsto enforce fixture compilation in CI.make help.Why is this feature needed?
pkg/cli/workflowscan drift from compiler behavior.Implementation details