Fix golangci-lint failures in codemod and miner test files#31590
Merged
Conversation
…lint Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job lint-go
Fix golangci-lint failures in codemod and miner test files
May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes golangci-lint violations that were causing the lint-go CI job to fail, without changing the intended runtime behavior.
Changes:
- Refactors the codemod implementation to remove
intrange,wastedassign, andperfsprintlint violations (including dropping an unusedfmtimport). - Updates the codemod fuzz test to avoid unnecessary
fmt.Sprintfusage and remove the unusedfmtimport. - Replaces
require.NoErrorwithassert.NoErrorinside a goroutine inTestConcurrencyto avoidruntime.Goexit()behavior from non-test goroutines.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/codemod_checkout_persist_credentials_false.go | Refactors loop/assignments and simplifies string construction to satisfy golangci-lint. |
| pkg/cli/codemod_checkout_persist_credentials_false_fuzz_test.go | Removes fmt.Sprintf usage and unused import in fuzz test helper. |
| pkg/agentdrain/miner_test.go | Avoids require.* assertions inside goroutines by switching to assert.*. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
The
lint-goCI job was failing with 7 golangci-lint violations across three files introduced by recent changes.How did you fix it?
pkg/cli/codemod_checkout_persist_credentials_false.gointrange: replaced C-style loop withfor i := range stepLineswastedassign: movedisUsesInlineandwithKeyIndentLendeclarations into theifblocks where they're first assigned and used, eliminating dead initial valuesperfsprint: replacedfmt.Sprintf("%spersist-credentials: false", withIndent+" ")withwithIndent + " persist-credentials: false"; removed unused"fmt"importpkg/cli/codemod_checkout_persist_credentials_false_fuzz_test.goperfsprint: replaced twofmt.Sprintf("...: %s", x)calls with string concatenation; removed unused"fmt"importpkg/agentdrain/miner_test.gotestifylint: swappedrequire.NoError→assert.NoErrorinside a goroutine —requirecallsruntime.Goexit()which doesn't behave correctly outside the test goroutine