Reject unused top-level command in main workflow frontmatter schema#31750
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused top-level command schema field
Reject unused top-level May 12, 2026
command in main workflow frontmatter schema
pelikhan
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a schema/compiler mismatch where a top-level command field could pass JSON schema validation but be ignored at compile time, creating a silent misconfiguration. It aligns the main workflow frontmatter schema with the actual trigger semantics (on.slash_command / deprecated on.command) and adds a regression test to prevent reintroducing the issue.
Changes:
- Removed the top-level
commandproperty frompkg/parser/schemas/main_workflow_schema.jsonso it is rejected as an unknown field. - Added a unit test asserting schema validation rejects top-level
commandwith an “Unknown property” error. - Minor formatting-only changes in a JSON data file and Go test file.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/data/ecosystem_domains.json | Formatting-only change to the gh-aw domain list (single-line array). |
| pkg/parser/schemas/main_workflow_schema.json | Removes top-level command from schema properties to ensure validation rejects it. |
| pkg/parser/schema_location_test.go | Adds regression test verifying top-level command is rejected during schema validation. |
| pkg/cli/init_test.go | Formatting-only (gofmt-style indentation) changes in tests. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/4 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
A top-level
commandfield was accepted by schema validation but ignored by compilation, creating a silent misconfiguration path. This change aligns schema behavior with actual parser/compiler semantics (on.slash_command/ deprecatedon.commandunderon).What was the bug?
commandwas defined inpkg/parser/schemas/main_workflow_schema.jsonbut not consumed anywhere in frontmatter extraction.How did you fix it?
commandfrom/pkg/parser/schemas/main_workflow_schema.json.TestValidateMainWorkflowFrontmatterWithSchemaAndLocation_RejectsTopLevelCommandin/pkg/parser/schema_location_test.goto enforce rejection ofcommandat the top level.Testing