Fix lint-go CI failures

[Copilot]

Five golangci-lint violations introduced by recent changes were breaking the lint-go CI job.

Bug Fix

What was the bug?

The following linter errors were reported:

Linter	File	Issue
gofmt	compiler_experiments_sparse_interaction_warning_test.go	Redundant []string type in map[string][]string composite literals
intrange	runtime_detection.go	Classic 3-clause for loop indexing into a slice
modernize	engine_helpers.go	HasSuffix + TrimSuffix pair replaceable with CutSuffix
staticcheck SA6002	workflows.go	sync.Pool.Put called with []byte (non-pointer), causing slice header copies
staticcheck QF1001	firewall_args_test.go	Negated conjunction not simplified via De Morgan's law

How did you fix it?

• gofmt: ran gofmt -s — removes redundant element types in composite literals
• intrange: for i := 0; i < len(words)-1; i++ → for i := range len(words)-1
• modernize: HasSuffix + TrimSuffix → strings.CutSuffix
• SA6002: pool stores *[]byte instead of []byte; defer writes back the (possibly reallocated) slice before returning the pointer
• QF1001: !(A && B && C) → A >= B || B >= C || C >= D

// Before (SA6002)
var workflowTitleScannerBufferPool = sync.Pool{
    New: func() any { return make([]byte, workflowTitleScannerBufferSize) },
}
scannerBuffer := workflowTitleScannerBufferPool.Get().([]byte)
defer workflowTitleScannerBufferPool.Put(scannerBuffer)

// After
var workflowTitleScannerBufferPool = sync.Pool{
    New: func() any { b := make([]byte, workflowTitleScannerBufferSize); return &b },
}
scannerBufferPtr := workflowTitleScannerBufferPool.Get().(*[]byte)
defer func() {
    *scannerBufferPtr = scannerBuffer
    workflowTitleScannerBufferPool.Put(scannerBufferPtr)
}()

[Copilot]

Pull request overview

Fixes lint-go CI failures by addressing five golangci-lint violations introduced in recent changes.

Changes:

• Modernized loops and string handling (intrange, modernize) and applied gofmt -s composite literal simplifications.
• Refactored sync.Pool usage to store *[]byte to satisfy staticcheck SA6002.
• Simplified a negated test condition using De Morgan’s law (staticcheck QF1001).

Show a summary per file

File	Description
pkg/workflow/runtime_detection.go	Replaces an index-based loop with an integer range loop to satisfy intrange.
pkg/workflow/firewall_args_test.go	Simplifies a negated conjunction into ordered >= checks for QF1001.
pkg/workflow/engine_helpers.go	Uses strings.CutSuffix instead of HasSuffix + TrimSuffix (modernize).
pkg/workflow/compiler_experiments_sparse_interaction_warning_test.go	Applies gofmt -s composite literal element type elision.
pkg/cli/workflows.go	Adjusts sync.Pool buffer storage to avoid slice-header copies (SA6002).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 1