Docs/tests: include pre-agent-steps and post-steps in shared import allowlist#31912
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix documentation to include pre-agent-steps in Allowed Import Fields
Docs/tests: include May 13, 2026
pre-agent-steps and post-steps in shared import allowlist
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a docs/runtime mismatch by documenting that shared imports may include pre-agent-steps and post-steps, and adds integration coverage confirming these fields are accepted in shared workflows.
Changes:
- Documented
pre-agent-steps:andpost-steps:as allowed fields for shared workflow imports. - Documented merge behavior for imported
pre-agent-steps(prepended) andpost-steps(appended). - Extended the shared-import allowlist integration test to include
pre-agent-stepsandpost-steps.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/forbidden_fields_import_test.go | Expands allowed-field import success coverage to include pre-agent-steps and post-steps. |
| docs/src/content/docs/reference/imports.md | Updates the allowed import fields list and merge semantics to include pre-agent-steps and post-steps. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| - `runtimes:` - Runtime version overrides (node, python, go, etc.) | ||
| - `secret-masking:` - Secret masking steps | ||
| - `env:` - Workflow-level environment variables | ||
| - `pre-agent-steps:` - Steps that run after artifacts are downloaded and before engine execution |
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
The imports reference omitted
pre-agent-steps(and did not clarifypost-steps) from the shared-workflow Allowed Import Fields list, while compiler behavior already accepts and merges both fields. This created a docs/runtime mismatch for reusable workflow components.How did you fix it?
Docs: Allowed Import Fields
pre-agent-steps:andpost-steps:to/docs/src/content/docs/reference/imports.mdunder shared workflow allowed fields.Docs: Merge semantics
pre-agent-steps:imported entries are prepended to main workflow entries (import order).post-steps:imported entries are appended after main workflow entries (import order).Integration coverage for import acceptance
pkg/workflow/forbidden_fields_import_test.go(TestAllowedFieldsImportSuccess) to include shared imports that define:pre-agent-stepspost-stepsTesting
pre-agent-stepspost-steps