ci: recompile workflows and fix compiler/test regressions#32274
Merged
Conversation
- Fix stringscut lint: simplify strings.Index to strings.Contains in mcp_logs_upload_test.go - Fix TypeScript type error in update_pull_request.cjs (JSDoc cast parentheses) - Fix compiler regression: sanitize run: expressions in custom job steps via extractPinnedJobSteps - Update wasm golden files for mcpg v0.3.6→v0.3.9 and enableTokenSteering changes - Auto-format create_pull_request.cjs via prettier - Update linter-miner.lock.yml (pre-existing recompile diff) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
ci: fix linting, test failures, and update golden files
ci: recompile workflows and fix compiler/test regressions
May 15, 2026
Copilot created this pull request from a session on behalf of
pelikhan
May 15, 2026 03:38
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR recompiles the linter-miner workflow against newer infrastructure and updates compiler/runtime fixtures, while also adjusting a run-step sanitization path and small JS/test cleanups.
Changes:
- Updates generated workflow and golden fixtures for newer mcpg/AWF/Copilot infrastructure output.
- Adds run-step expression sanitization for pinned custom job steps.
- Applies minor JS formatting/type-check and Go test cleanup changes.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/linter-miner.lock.yml |
Regenerated workflow with updated setup flow, versions, env expressions, AWF config, and runtime behavior. |
pkg/workflow/compiler_jobs.go |
Adds sanitization before serializing pinned custom job steps. |
pkg/workflow/mcp_logs_upload_test.go |
Simplifies string existence check. |
actions/setup/js/update_pull_request.cjs |
Adjusts JSDoc cast formatting and return formatting. |
actions/setup/js/create_pull_request.cjs |
Reformats a warning string expression. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden |
Updates golden output for mcpg version and AWF token steering config. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden |
Updates golden output for mcpg version and AWF token steering config. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.golden |
Updates golden output for mcpg version and AWF token steering config. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden |
Updates golden output for mcpg version and AWF token steering config. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 2
Comment on lines
+989
to
+993
| sanitizedMap, warnings, _ := sanitizeRunStepExpressions(finalStepMap) | ||
| for _, w := range warnings { | ||
| compilerJobsLog.Printf("sanitized run: expression in job '%s' step: %s", jobName, w) | ||
| } | ||
| stepYAML, err := ConvertStepToYAML(sanitizedMap) |
| let status; | ||
| if (typeof error === "object" && error !== null && "status" in error) { | ||
| status = /** @type {{status?: number}} */ (error).status; | ||
| status = /** @type {{status?: number}} */ error.status; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recompiles
linter-miner.lock.ymlagainst the current compiler and bumps several infrastructure versions. Also fixes two bugs and updates golden files to match the new output.Changes
Compiler fix — custom job
run:step expression sanitizationextractPinnedJobStepsincompiler_jobs.gowas not callingsanitizeRunStepExpressionsbefore YAML-serializing pinned steps, causing expressions like${{ needs.producer.outputs.value }}to pass through raw in custom jobrun:steps. Now sanitized and warnings logged.Recompiled workflow (
linter-miner.lock.yml)v0.3.6→v0.3.90.25.41→0.25.461.0.40→1.0.43; droppedGH_AW_INFO_CLI_VERSIONgithub/gh-aw-actions/setup@v0.72.1→ inline./actions/setup(now checked out via sparse checkout, removes external setup action pin)check_version_updatesstep removed (no longer emitted by compiler)enableTokenSteering: trueadded toapiProxyGH_AW_GITHUB_EVENT_*vars replaced with hashedGH_AW_EXPR_*vars supportingaw_contextdispatch payload fallback for issue/PR/discussion/comment routingGolden file updates
basic-copilot,smoke-copilot,playwright-cli-mode, andwith-importsgolden fixtures to reflect mcpgv0.3.9andenableTokenSteeringin the AWF config blobMinor cleanup
mcp_logs_upload_test.go: simplifiedstrings.Index(...) == -1to!strings.Contains(...)(linter)update_pull_request.cjs: fixed JSDoc cast parenthesization forunknowntype narrowing (TS error)