fix: use AWFProxyLogsDir constant in generateSquidLogsUploadStep

[Copilot]

Bug Fix

What was the bug?

generateSquidLogsUploadStep hardcoded "/tmp/gh-aw/sandbox/firewall/logs/" while its sibling generateFirewallLogParsingStep correctly used constants.AWFProxyLogsDir. The two sites were accidentally in sync today, but any future change to the constant would silently leave the upload step pointing at a stale path, causing it to upload an empty/missing directory.

How did you fix it?

One-line change in pkg/workflow/engine_firewall_support.go:

// Before
firewallLogsDir := "/tmp/gh-aw/sandbox/firewall/logs/"

// After
firewallLogsDir := constants.AWFProxyLogsDir + "/"

The trailing slash required by actions/upload-artifact's path: field is appended at the use site — consistent with compiler_yaml_main_job.go which does the same (constants.AWFProxyLogsDir + "/").

Testing

All pkg/workflow tests pass. Generated YAML output is unchanged since the constant value matches the former literal.

[Copilot]

Pull request overview

Replaces a hardcoded firewall logs directory path in generateSquidLogsUploadStep with the constants.AWFProxyLogsDir constant to keep the upload step in sync with generateFirewallLogParsingStep and prevent future drift.

Changes:

• Use constants.AWFProxyLogsDir + "/" instead of the hardcoded "/tmp/gh-aw/sandbox/firewall/logs/" literal.
• Regenerated .github/workflows/linter-miner.lock.yml (unrelated compiler output regeneration).

Show a summary per file

File	Description
pkg/workflow/engine_firewall_support.go	Replaces hardcoded firewall logs path with the shared constant.
.github/workflows/linter-miner.lock.yml	Regenerated lock file with various unrelated compiler updates.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0