Make centralized slash-command workflows emit non-required workflow_dispatch inputs by Copilot · Pull Request #32480 · github/gh-aw

Copilot · 2026-05-15T21:16:24Z

Centralized slash-command workflows should not be blocked by workflow_dispatch input requirements, because they are invoked by the router, not manual callers. This change ensures compiled dispatch schemas are compatible with routed slash-command execution.

Compiler behavior (centralized slash commands)
- Updated applyDefaults command-trigger path to normalize on.workflow_dispatch.inputs.*.required to false when on.slash_command.strategy: centralized is active.
- Added setWorkflowDispatchInputsOptional(...) to safely no-op unless workflow_dispatch.inputs is a valid map.
Regression coverage
- Added a focused compile test asserting a source input marked required: true is emitted as required: false in compiled lock YAML for centralized slash-command workflows.

if data.CommandCentralized {
    if len(data.CommandOtherEvents) > 0 {
        maps.Copy(commandEventsMap, data.CommandOtherEvents)
    }
    setWorkflowDispatchInputsOptional(commandEventsMap)
    if _, hasWorkflowDispatch := commandEventsMap["workflow_dispatch"]; !hasWorkflowDispatch {
        commandEventsMap["workflow_dispatch"] = nil
    }
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-05-15T21:36:25Z

@copilot the compiler should raise an error on required: true and slash_command/label_command

…gers Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-05-15T21:59:24Z

@copilot recompile and fix agentic workflows with that error

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

This PR adds compiler validation intended to address workflow_dispatch.inputs.*.required usage in workflows that use slash_command / label_command, along with new tests covering the resulting behavior.

Changes:

Added a new compiler validation step that rejects workflow_dispatch inputs marked required: true when slash_command or label_command triggers are present.
Added compile tests asserting compilation fails when required workflow_dispatch inputs are declared alongside centralized slash_command or label_command.
Introduced a new validation helper (validateCommandWorkflowDispatchInputs) to scan raw frontmatter for required dispatch inputs.

Show a summary per file

File	Description
pkg/workflow/compiler_validators.go	Invokes new validation step during compilation.
pkg/workflow/command_dispatch_validation.go	Implements validation that errors on `required: true` `workflow_dispatch` inputs for command-trigger workflows.
pkg/workflow/slash_command_centralized_compile_test.go	Adds regression tests that expect compilation to fail when required dispatch inputs are present.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 3/3 changed files
Comments generated: 3

+	// Validate workflow_dispatch required inputs with slash/label command triggers.
+	log.Printf("Validating workflow_dispatch input requirements for command triggers")
+	if err := validateCommandWorkflowDispatchInputs(workflowData); err != nil {
+		return formatCompilerError(markdownPath, "error", err.Error(), err)
+	}


+func TestSlashCommandRejectsRequiredDispatchInputs(t *testing.T) {
+	tmpDir := testutil.TempDir(t, "workflow-centralized-slash-dispatch-inputs-test")
+
+	markdownPath := filepath.Join(tmpDir, "scout.md")
+	content := `---
+on:
+  slash_command:
+    name: scout
+    strategy: centralized
+  workflow_dispatch:
+    inputs:
+      topic:
+        description: "Research topic"
+        required: true
+        type: string
+tools:
+  github:
+    allowed: [list_issues]
+---
+
+# Scout
+`
+	require.NoError(t, os.WriteFile(markdownPath, []byte(content), 0644))
+
+	compiler := NewCompiler()
+	err := compiler.CompileWorkflow(markdownPath)
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "on.workflow_dispatch.inputs.topic.required: true is not allowed when using slash_command")
+


+// validateCommandWorkflowDispatchInputs rejects required workflow_dispatch inputs when
+// slash_command or label_command triggers are configured.
+// Returns an error if any workflow_dispatch input has required: true.
+func validateCommandWorkflowDispatchInputs(workflowData *WorkflowData) error {
+	if workflowData == nil || workflowData.RawFrontmatter == nil {
+		return nil
+	}
+
+	hasSlashCommand := len(workflowData.Command) > 0
+	hasLabelCommand := len(workflowData.LabelCommand) > 0
+	if !hasSlashCommand && !hasLabelCommand {
+		return nil
+	}
+
+	onMap, ok := workflowData.RawFrontmatter["on"].(map[string]any)
+	if !ok {
+		return nil
+	}
+
+	workflowDispatchMap, ok := onMap["workflow_dispatch"].(map[string]any)
+	if !ok {
+		return nil
+	}
+
+	inputsMap, ok := workflowDispatchMap["inputs"].(map[string]any)
+	if !ok {
+		return nil
+	}
+
+	for inputName, inputDef := range inputsMap {
+		inputDefMap, ok := inputDef.(map[string]any)
+		if !ok {
+			continue
+		}
+
+		required, ok := inputDefMap["required"].(bool)
+		if ok && required {
+			var triggerNames []string
+			if hasSlashCommand {
+				triggerNames = append(triggerNames, "slash_command")
+			}
+			if hasLabelCommand {
+				triggerNames = append(triggerNames, "label_command")
+			}
+			triggerNamesPhrase := strings.Join(triggerNames, " and ")
+
+			return fmt.Errorf(
+				"on.workflow_dispatch.inputs.%s.required: true is not allowed when using %s; set required: false",
+				inputName, triggerNamesPhrase,


Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-05-15T22:03:35Z

@copilot the compiler should raise an error on required: true and slash_command/label_command

Implemented in a000647: the compiler now errors when on.workflow_dispatch.inputs.*.required: true is used with slash_command or label_command, and no longer rewrites those inputs to optional.

pelikhan · 2026-05-15T22:06:42Z

@copilot review all comments

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-05-15T22:16:05Z

@copilot recompile and fix agentic workflows with that error

Done in b93490c. I fixed the agentic workflows that hit the new validation (scout.md and pdf-summary.md now use workflow_dispatch.inputs.*.required: false) and recompiled workflows successfully, which also updated agentic_commands.yml routing and the corresponding lock files.

Copilot · 2026-05-15T22:23:53Z

@copilot review all comments

Reviewed all comments. The actionable items are addressed in a000647 (compiler now errors on required: true with slash_command/label_command) and b93490c (updated affected agentic workflows and recompiled lock files). I don’t see any remaining actionable comments for this PR.

… @copilot mention default - command-triggers.md: note that workflow_dispatch.inputs.required is normalized to false under strategy: centralized (from #32480) - safe-outputs.md: note that @copilot is always preserved as a default allowed mention alias in add-comment (from #32487)

Initial plan

8268869

Copilot AI assigned Copilot and pelikhan May 15, 2026

Copilot started work on behalf of pelikhan May 15, 2026 21:16 View session

Copilot AI linked an issue May 15, 2026 that may be closed by this pull request

[aw] AW compiler should have required: false for slash commands #32459

Closed

Copilot AI and others added 2 commits May 15, 2026 21:28

Make centralized slash-command dispatch inputs optional

979bea7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Address review feedback on slash-command optional inputs change

fb65a7c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix AW compiler required flag for slash commands~~ Make centralized slash-command workflows emit non-required workflow_dispatch inputs May 15, 2026

Copilot finished work on behalf of pelikhan May 15, 2026 21:30

Copilot AI requested a review from pelikhan May 15, 2026 21:30

Copilot started work on behalf of pelikhan May 15, 2026 21:36 View session

Copilot AI and others added 6 commits May 15, 2026 21:46

Reject required workflow_dispatch inputs for slash/label command trig…

40c4a8e

…gers Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Refine command-trigger dispatch input validation diagnostics

7ea71b9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Polish dispatch-validation diagnostics and test naming

0400ef3

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Simplify trigger-name formatting in dispatch validation

aeaf542

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Apply final review nits in command dispatch validation

fec8d8c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Inline trigger presence check in dispatch validator

b57bf67

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan marked this pull request as ready for review May 15, 2026 21:57

Copilot AI review requested due to automatic review settings May 15, 2026 21:57

Rename dispatch input rejection tests for clarity

1f2ac3e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot started reviewing on behalf of pelikhan May 15, 2026 21:58 View session

Tighten dispatch validation docs and compile-failure assertions

a7f0556

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI reviewed May 15, 2026

View reviewed changes

Copilot AI and others added 2 commits May 15, 2026 22:01

Clarify dispatch-input error context and restore test naming convention

9018f23

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Refine command-trigger dispatch validation error wording

a000647

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan May 15, 2026 22:04

Copilot started work on behalf of pelikhan May 15, 2026 22:04 View session

Copilot AI and others added 2 commits May 15, 2026 22:09

Plan update: investigate PR feedback and CI failures

bfe68b6

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Fix command workflow_dispatch required inputs and recompile workflows

b93490c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan May 15, 2026 22:19

Copilot started work on behalf of pelikhan May 15, 2026 22:19 View session

pelikhan merged commit 276efd4 into main May 15, 2026
1 check failed

pelikhan deleted the copilot/aw-compiler-slash-commands branch May 15, 2026 22:24

Copilot stopped work on behalf of pelikhan due to an error May 15, 2026 22:24
The session was cancelled by the user.

github-actions Bot mentioned this pull request May 16, 2026

[docs] Update documentation for features from 2026-05-16 #32605

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make centralized slash-command workflows emit non-required workflow_dispatch inputs#32480

Make centralized slash-command workflows emit non-required workflow_dispatch inputs#32480
pelikhan merged 15 commits into
mainfrom
copilot/aw-compiler-slash-commands

Copilot AI commented May 15, 2026 •

edited

Loading

Uh oh!

pelikhan commented May 15, 2026

Uh oh!

pelikhan commented May 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

pelikhan commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented May 15, 2026

Uh oh!

pelikhan commented May 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

pelikhan commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 15, 2026 •

edited

Loading