Skip to content

Stabilize Daily Model Inventory Copilot startup by removing fragile quoted jq allow-tool#32505

Merged
pelikhan merged 3 commits into
mainfrom
copilot/aw-daily-model-inventory-checker-failure
May 16, 2026
Merged

Stabilize Daily Model Inventory Copilot startup by removing fragile quoted jq allow-tool#32505
pelikhan merged 3 commits into
mainfrom
copilot/aw-daily-model-inventory-checker-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

Daily Model Inventory Checker intermittently failed before agent execution: Copilot exited immediately with exitCode=1 and no stderr/stdout. The failing run included a quoted jq-filter shell(...) allow-tool argument in the generated Copilot command line.

  • Root-cause mitigation in workflow tool allow-list

    • Removed the high-risk quoted jq-filter allow-tool entry from daily-model-inventory.md.
    • Kept existing access to reflect.json via safer, simpler allowed commands already present (jq . /tmp/gh-aw/model-inventory/reflect.json, cat, etc.).
  • Compiled workflow alignment

    • Updated daily-model-inventory.lock.yml so the generated Copilot invocation no longer includes:
      • --allow-tool 'shell(jq ".endpoints[] | select(.provider == \"copilot\") | .models" /tmp/gh-aw/model-inventory/reflect.json)'
  • Regression guard

    • Extended pkg/workflow/daily_model_inventory_workflow_test.go with an assertion that this quoted jq allow-tool pattern is absent from the compiled lock workflow.
# removed from tool allow-list generation
- "jq \".endpoints[] | select(.provider == \\\"copilot\\\") | .models\" /tmp/gh-aw/model-inventory/reflect.json"

Copilot AI linked an issue May 16, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix daily model inventory checker engine failure Stabilize Daily Model Inventory Copilot startup by removing fragile quoted jq allow-tool May 16, 2026
Copilot AI requested a review from pelikhan May 16, 2026 00:54
Copy link
Copy Markdown
Collaborator

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot allow bash *

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review May 16, 2026 01:04
Copilot AI review requested due to automatic review settings May 16, 2026 01:04
@pelikhan pelikhan merged commit f91a078 into main May 16, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/aw-daily-model-inventory-checker-failure branch May 16, 2026 01:04
Copilot stopped work on behalf of pelikhan due to an error May 16, 2026 01:05
Copilot AI requested a review from pelikhan May 16, 2026 01:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stabilizes the “Daily Model Inventory Checker” Copilot startup by removing a fragile, heavily-escaped jq allow-tool entry that intermittently caused the Copilot CLI to exit early.

Changes:

  • Replaces the workflow’s tools.bash allowlist with a wildcard ("*"), resulting in --allow-all-tools in the compiled Copilot invocation.
  • Updates the compiled lock workflow to remove the previously generated quoted jq --allow-tool shell(...) entry.
  • Extends the Go workflow compilation test to assert --allow-all-tools is present and that the quoted jq allow-tool pattern is absent.
Show a summary per file
File Description
pkg/workflow/daily_model_inventory_workflow_test.go Adds regression assertions around compiled workflow tool flags/patterns.
.github/workflows/daily-model-inventory.md Changes bash tool configuration to wildcard, impacting compiled Copilot permissions.
.github/workflows/daily-model-inventory.lock.yml Reflects the recompiled Copilot invocation without the quoted jq allow-tool entry.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

Comment on lines 301 to 307
tools:
cli-proxy: true
playwright:
mode: cli
bash:
- "cat /tmp/gh-aw/model-inventory/inventory.json"
- "jq . /tmp/gh-aw/model-inventory/inventory.json"
- "jq . /tmp/gh-aw/model-inventory/artifacts/*/models.json"
- "jq . /tmp/gh-aw/model-inventory/artifacts/*/raw.json"
- "jq '[.data[] | keys] | add | unique' /tmp/gh-aw/model-inventory/artifacts/openai-models/raw.json"
- "jq '[.data[] | keys] | add | unique' /tmp/gh-aw/model-inventory/artifacts/anthropic-models/raw.json"
- "jq '[.models[] | keys] | add | unique' /tmp/gh-aw/model-inventory/artifacts/gemini-models/raw.json"
- "jq . /tmp/gh-aw/model-inventory/reflect.json"
- "jq \".endpoints[] | select(.provider == \\\"copilot\\\") | .models\" /tmp/gh-aw/model-inventory/reflect.json"
- "cat /tmp/gh-aw/model-inventory/artifacts/copilot-billing-multipliers/multipliers.json"
- "jq . /tmp/gh-aw/model-inventory/artifacts/copilot-billing-multipliers/multipliers.json"
- "jq '.models[]' /tmp/gh-aw/model-inventory/artifacts/copilot-billing-multipliers/multipliers.json"
- "find /tmp/gh-aw/model-inventory -type f"
- "cat pkg/workflow/data/model_aliases.json"
- "cat pkg/cli/data/model_multipliers.json"
- "*"
github:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Daily Model Inventory Checker failed

3 participants