Skip to content

Prevent Linter Miner runs from completing without a terminal safe output#32531

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-linter-miner-failure
May 16, 2026
Merged

Prevent Linter Miner runs from completing without a terminal safe output#32531
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-linter-miner-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

Linter Miner run 25949820523 succeeded at the agent job level but produced no safe outputs, causing downstream handling to flag the run. The workflow prompt allowed execution paths where sub-agent activity could outlive the parent turn and exit without a terminal safe-output call.

  • Prompt flow hardening

    • Changed Step 2 in .github/workflows/linter-miner.md from parallel sub-agent mining to sequential execution (discussion-miner then code-pattern-scanner) to avoid unfinished child work at parent completion time.
  • Terminal safe-output contract

    • Added explicit completion rules:
      • do not finish while spawned sub-agents are still running,
      • if any sub-agent fails/stalls/incompletes, emit noop with explanation,
      • final turn must emit exactly one safe output: create_pull_request or noop.
  • Behavioral intent

    • Tightens the workflow’s “no silent exit” behavior so no-op outcomes are explicitly represented in safe outputs instead of ending with empty output artifacts.
- Do not finish while any spawned sub-agent is still running.
- If any sub-agent step fails, stalls, or does not complete, call `noop` with a clear explanation instead of ending without output.
- Final turn requirement: call exactly one safe output (`create_pull_request` or `noop`) as your last action before finishing.

Copilot AI linked an issue May 16, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Linter Miner workflow failure Prevent Linter Miner runs from completing without a terminal safe output May 16, 2026
Copilot AI requested a review from pelikhan May 16, 2026 02:40
@pelikhan pelikhan marked this pull request as ready for review May 16, 2026 02:45
Copilot AI review requested due to automatic review settings May 16, 2026 02:45
@pelikhan pelikhan merged commit c76b198 into main May 16, 2026
2 checks passed
@pelikhan pelikhan deleted the copilot/aw-fix-linter-miner-failure branch May 16, 2026 02:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens the linter-miner workflow prompt to prevent runs from completing without a terminal safe output by serializing sub-agent execution and adding explicit completion rules.

Changes:

  • Switches Step 2 sub-agent mining from parallel to sequential to avoid orphaned child work at parent completion.
  • Adds explicit completion rules requiring exactly one terminal safe output (create_pull_request or noop).
Show a summary per file
File Description
.github/workflows/linter-miner.md Sequential sub-agent execution and tightened terminal safe-output contract

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Linter Miner failed

3 participants