[log] Add debug logging to 5 workflow compiler files#32543
Merged
Conversation
Adds strategic debug log calls at function entry, mode-selection branches, and previously unlogged exit paths to improve troubleshooting visibility during workflow compilation. Uses the existing shared package loggers (checkoutManagerLog, mcpRendererLog, maintenanceLog, strictModeValidationLog) so log namespaces stay coherent with neighbouring files. Files touched: - pkg/workflow/checkout_step_generator.go - pkg/workflow/mcp_renderer_github.go - pkg/workflow/side_repo_maintenance.go - pkg/workflow/strict_mode_network_validation.go - pkg/workflow/strict_mode_steps_validation.go Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds strategic debug log calls to 5 files in
pkg/workflow/at function entry, mode-selection branches, and previously unlogged exit paths. Each file uses the existing shared package logger (checkoutManagerLog,mcpRendererLog,maintenanceLog,strictModeValidationLog) so log namespaces stay coherent with neighbouring files in each subsystem.No new logger declarations were introduced; the goal of this PR is purely to fill in coverage gaps in already-instrumented subsystems.
Files touched (5)
pkg/workflow/checkout_step_generator.go— entry log for app token mint/invalidation step builders, refspec branch decisions, wiki default branchpkg/workflow/mcp_renderer_github.go— TOML dispatch, remote vs local mode selection, TOML remote endpoint selectionpkg/workflow/side_repo_maintenance.go— target scan count, generation summary, per-workflow build context, close-expired job inclusionpkg/workflow/strict_mode_network_validation.go— MCP and tools validation skip/scan paths, cache-memory scope checkpkg/workflow/strict_mode_steps_validation.go— overall steps-secrets entry, per-section classification, non-strict warning emissionConstraints respected
*_test.gofiles modifiedTest plan
make buildpassesmake test-unitpasses (exit 0)make recompileregenerates all 229 workflow lock files with no errors🤖 Generated with [Claude Code]((claude.com/redacted)