Skip to content

[log] Add debug logging to 5 workflow compiler files#32543

Merged
pelikhan merged 1 commit into
mainfrom
add-logger-debug-statements-460e3da00e58d546
May 16, 2026
Merged

[log] Add debug logging to 5 workflow compiler files#32543
pelikhan merged 1 commit into
mainfrom
add-logger-debug-statements-460e3da00e58d546

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Summary

Adds strategic debug log calls to 5 files in pkg/workflow/ at function entry, mode-selection branches, and previously unlogged exit paths. Each file uses the existing shared package logger (checkoutManagerLog, mcpRendererLog, maintenanceLog, strictModeValidationLog) so log namespaces stay coherent with neighbouring files in each subsystem.

No new logger declarations were introduced; the goal of this PR is purely to fill in coverage gaps in already-instrumented subsystems.

Files touched (5)

  • pkg/workflow/checkout_step_generator.go — entry log for app token mint/invalidation step builders, refspec branch decisions, wiki default branch
  • pkg/workflow/mcp_renderer_github.go — TOML dispatch, remote vs local mode selection, TOML remote endpoint selection
  • pkg/workflow/side_repo_maintenance.go — target scan count, generation summary, per-workflow build context, close-expired job inclusion
  • pkg/workflow/strict_mode_network_validation.go — MCP and tools validation skip/scan paths, cache-memory scope check
  • pkg/workflow/strict_mode_steps_validation.go — overall steps-secrets entry, per-section classification, non-strict warning emission

Constraints respected

  • 5 files modified (the per-PR cap)
  • No *_test.go files modified
  • Logger arguments are pure formatted strings — no function calls or computed side effects
  • New log calls are placed at meaningful decision points, not as redundant duplicates of existing user-facing console messages

Test plan

  • make build passes
  • make test-unit passes (exit 0)
  • make recompile regenerates all 229 workflow lock files with no errors

🤖 Generated with [Claude Code]((claude.com/redacted)

Generated by 📝 Go Logger Enhancement · ● 53.1M ·

  • expires on May 18, 2026, 4:39 AM UTC

Adds strategic debug log calls at function entry, mode-selection branches,
and previously unlogged exit paths to improve troubleshooting visibility
during workflow compilation. Uses the existing shared package loggers
(checkoutManagerLog, mcpRendererLog, maintenanceLog, strictModeValidationLog)
so log namespaces stay coherent with neighbouring files.

Files touched:
- pkg/workflow/checkout_step_generator.go
- pkg/workflow/mcp_renderer_github.go
- pkg/workflow/side_repo_maintenance.go
- pkg/workflow/strict_mode_network_validation.go
- pkg/workflow/strict_mode_steps_validation.go

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added automation enhancement New feature or request labels May 16, 2026
@pelikhan pelikhan merged commit aa2db70 into main May 16, 2026
@pelikhan pelikhan deleted the add-logger-debug-statements-460e3da00e58d546 branch May 16, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant